Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp901969pxp; Wed, 16 Mar 2022 20:42:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqabd2+uyo2aMRz8GrpRjKQ0gZp4WsFmscSkknVBUm9Z6Q/kQiJbTEPklf2j2K4p6Ha8e/ X-Received: by 2002:a17:90a:bb0d:b0:1bd:3baf:c8b4 with SMTP id u13-20020a17090abb0d00b001bd3bafc8b4mr3104534pjr.15.1647488526422; Wed, 16 Mar 2022 20:42:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647488526; cv=none; d=google.com; s=arc-20160816; b=wgPKvZ/qtslNWzaJxKwXSBL5flkppjwvim4eu8UKVUZp2gHM0IJ2SCA177e5xuPjL+ GeK61W04TTbn4a3FyTlYXV5/rGMkek/0yfoC/bGTyDtQYR1R1PAwF/rbosV3B9X7DrK2 58+T2Gc026hACxcU4jVVNhEvVjsO9FwDwwyK7eRvyLf/R5sHPuRbmSam/FHp2po+F7Cr +M3F43e95Y5B2KRhtb/+n45OwEf4+PBuGTmvJhqo0S4sH7jxiV37TUoUJ2QrL7vqj9Df wafMZ8/gctSjnBzif0B/fBSyqSd8hDINpPkoBxFHT+rEAm3wqzItdEniRoZXR5TxRC05 8exg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l0knb/KfC1qNAUVvEijHwbni8G3RBPitawE5i2CTiXw=; b=gXrpkcT2WixppGG50az85s/FU/DAC/4bHSGd6eRswL4jCKDjmM1iIz8qs/H0wg011W DNM3a4Viif1K3/9N6Hy+EaPIQJYm6Id+Qf8a35EQDIUe6YQ5mVPuhsTiIR4fogjBTqr4 XNokvBhk9KnueHXL5lNJj2atHbWc4gylhDhvIU3Ktm1+o0fwUJiicsLjS/qBIQ80TLO4 zkLRaXmz1ATRUstrJWuMowlS6EbeQR9hreCMS7VL9wkzDyddRDjDF2Ee5S7FJ8QlIRKs 4YNSgQh2ABffuuH22SUc7QPyj5v582FvGqyciiD/y62q/rxVkxE0qQCeng4pmbUl+aDk IJ6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h1yWEwnl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p3-20020a170902e74300b00153a06838b8si3599695plf.486.2022.03.16.20.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 20:42:06 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h1yWEwnl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5FD9E66AEA; Wed, 16 Mar 2022 20:34:48 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346664AbiCPOJm (ORCPT + 99 others); Wed, 16 Mar 2022 10:09:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231887AbiCPOJj (ORCPT ); Wed, 16 Mar 2022 10:09:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259AA3C490 for ; Wed, 16 Mar 2022 07:08:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B55B761209 for ; Wed, 16 Mar 2022 14:08:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94F6EC340E9; Wed, 16 Mar 2022 14:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647439704; bh=bTEAVJzNEOhI/lKmrR9+/svr6T+tjoocmNyfraD9/PY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1yWEwnlFH9tmeVTqd6TZBfZ1MWs508WLTvjXcidNx2MtgliNe3BaY+owDlxLfYke nlw+vGKNgkCtwnxIYzZOm24cpf2hJNJCNGk1A7UNWGyzmiYZ+5kYmugCiBPAsquuf4 sdmKn4DdZCk3RROL2vmCS+fgwUV5HOOfWVddMKYA= Date: Wed, 16 Mar 2022 15:08:20 +0100 From: gregkh To: Xiaoke Wang Cc: "dan.carpenter" , nsaenz , bcm-kernel-feedback-list , linux-rpi-kernel , linux-arm-kernel , linux-staging , linux-kernel Subject: Re: [PATCH v2] staging: mmal-vchiq: add a check for the return of vmalloc() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2022 at 12:23:05AM +0800, Xiaoke Wang wrote: > On Tue, 15 Mar 2022 16:27:38 +0100, Greg KH wrote: > > Your change just crashed the kernel :( > > > > Please be more careful > > I am sorry. I ever been told that vfree(NULL) or kfree(NULL) is safe, Sorry, you are right, I was thinking that there would be an error value there. My mistake. greg k-h