Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Jens Axboe <axboe@kernel.dk>
To:     linux-block@vger.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Christoph Hellwig <hch@lst.de>
Cc:     "James E . J . Bottomley" <jejb@linux.ibm.com>,
        clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        kernel-janitors@vger.kernel.org
In-Reply-To: <20220314150321.17720-1-lukas.bulwahn@gmail.com>
References: <20220314150321.17720-1-lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] sr: simplify the local variable initialization in sr_block_open()
Message-Id: <164737692606.34720.13651107602467649811.b4-ty@kernel.dk>
Date:   Tue, 15 Mar 2022 14:42:06 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 14 Mar 2022 16:03:21 +0100, Lukas Bulwahn wrote:
> Commit 01d0c698536f ("sr: implement ->free_disk to simplify refcounting")
> refactored sr_block_open(), initialized one variable with a duplicate
> assignment (probably an unintended copy & paste duplication) and turned one
> error case into an early return, which makes the initialization of the
> return variable needless.
> 
> So, simplify the local variable initialization in sr_block_open() to make
> the code a bit more clear.
> 
> [...]

Applied, thanks!

[1/1] sr: simplify the local variable initialization in sr_block_open()
      commit: 79d45f57a19537a1ec6ebf836944e968b154f86e

Best regards,
-- 
Jens Axboe