Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <34a38062-cf2f-f76a-cf49-1e59f8a81e2c@intel.com>
Date:   Wed, 16 Mar 2022 18:11:53 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Intel-gfx] [PATCH v11 1/5] drm/i915/gsc: add gsc as a mei
 auxiliary device
Content-Language: en-US
To:     Alexander Usyskin <alexander.usyskin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
CC:     <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Tomas Winkler" <tomas.winkler@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220315131157.3972238-1-alexander.usyskin@intel.com>
 <20220315131157.3972238-2-alexander.usyskin@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220315131157.3972238-2-alexander.usyskin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTY4NEs4WkNQamZOa1gzcE9IQkRPTFlaYkRWeERzYjFHakprVFg4RlFyZVNw?=
 =?utf-8?B?aXlWb3N1a0ZrTkR1Z0JFZmw0Q1ZKdXNqVHhVM25HczRVeEJuY2FSZXpOdzRm?=
 =?utf-8?B?czdyUHpRMitRL0o3N0xRV3FSdFB3RGNiM3Bia1o4eG0rbEprWU1SMFlaQ2pG?=
 =?utf-8?B?Y3FTNnFMb1IzM1YzVmt4V09DRkZzYXQwYjV3MEtNVlRkL1ppZ0w2QlVKTTVC?=
 =?utf-8?B?L09BTWJYNndRVDIxVVoyeFhncVo2Z05LOWdFYnRsVjlWM1Q5ZnVJQ2VDbCtP?=
 =?utf-8?B?dDZkRGZtc1BJZ0NucUh3T2FoR1d5SXJuamZHaStyNGVZc3VxQTh4am43SUFm?=
 =?utf-8?B?eFBRWTFPYk5nTjBleWlkaW9yY01SMTMwSVFFTFBwQ1ZOOVQvRDJ6WExEMmpJ?=
 =?utf-8?B?OEovRk1GaUdHYk5KZUI5S0hvZlcxcDBKWlZpbFpBbmpTSlplMm83SjZMd3E0?=
 =?utf-8?B?aGdxUEsvTTM4Y08rSDdkRXd2QnRTQlErUWkycjUraFg3Qm1FNzhhYlk0U2x1?=
 =?utf-8?B?WE5LYkJDQUNZbW42MkVLNXZkdzZlMC9GbXlyZW5rSFBHenpYaFB2QjUveElp?=
 =?utf-8?B?MnF1Vld0aHZSLzkzUmZaVkQxSysxVkpWekRuclBOQVROYTJoemRLWG1QT1BP?=
 =?utf-8?B?M013bzhsZUdZRm04cU1FTC9DdXVGSDBLVVBOQ2o5WVJkUkVNazJETURtNjhZ?=
 =?utf-8?B?MGo2c0JRTjFFWjgxaVBHNldiMHM0dG5MUXZQRUhLVlp5RlhtdzdTM0FMcE9J?=
 =?utf-8?B?QnBOdUc0RUluejFUMmZPL2VRNTM4NllmcGRabGJaN09IeVM0TCtHcEdlNC8v?=
 =?utf-8?B?M3phSjlyTmlmaUEzM2MrcG5aak9ibURVcmVaa3pZN0Q4bFUyT29HeDU5VUhx?=
 =?utf-8?B?L0xkVUs4d1JZZXF3WFVIeDJzLzMyMmM3ZmNZZ3hzUVRIM1p2TmVBOGNpdHNQ?=
 =?utf-8?B?UkgrbGlGZ0crY1B0YjZJN3hweEdGYTJlTG8zanYzZ2pvaVVickZHRnpXSE9P?=
 =?utf-8?B?UDdyOGwveExLTEhFS2IzNHhwZjdRQzVwM05aUitOd3MwK2laTGxSUHd3aVQz?=
 =?utf-8?B?VjFCOHc3VUNObG94c3VLR3dQZVNCQUU0WkxGSVFwZExRUFJMRlJtSEM0K0l5?=
 =?utf-8?B?cGN3QmpKYkgzSnNrTmJ2N09McUkveGg5YW5qd0JTOEFqM1l3NTVNMnNCbTRo?=
 =?utf-8?B?STBhNGg0TnIvTHZoVDgvZkRUbUlnNG00a3ZVMk9CUXY3c1Z5Kzdqb00zWUZR?=
 =?utf-8?B?ZGJHNktUNWhsQm9WMHhZa29XeVl6L2VJOXUwTWJqQis1QWFnSGhZb01TMU9P?=
 =?utf-8?B?MXlSVFgxZXVyZ0VmaWJBNUJ2U0lXZTdkbCtXbjUrU2tmM3FEWXRPd0hLdzFU?=
 =?utf-8?B?ZHdFcjFra0Z5SEJ0eU1YcThIRDR6WXJ5OHg1UUs4OWJtSS9oS2xybGNod3ZG?=
 =?utf-8?B?VEZNa0RlQXpkV3Z2ZEpueUdVUG9ibmlIT2F4UnJ6aFZLSDZRZitVRXgzeERw?=
 =?utf-8?B?NzI1dDFwSEZFZ1orSE1GWTRjRjBUV0pEeDd0eWp3b1BPSTdIN2Q5UUJMY2tI?=
 =?utf-8?B?bEhwY1hhdlZQVWVRL1I3dmdIQW9aZFZLOUN5ZisvQURXTGlrWmswSHlXY3F0?=
 =?utf-8?B?Z1VMbWVZQm5XdEZSYzVocGdTVkorc2gzcWxhc1JHSy9DdFFhcTNlMFpQTUhG?=
 =?utf-8?B?U0FXMFFNMTZoL3lSamRBd1hGMW1aVnNReG1uK0ZPc2QwbXgzSzZTc1VhRGZo?=
 =?utf-8?B?ZGVNUWtvZEFqaHBYRUtHcHFwWlZYQ285Q2VGMGZ2V1dVcElSUVhIbDRnQzhs?=
 =?utf-8?B?WExpR08wOWhLbjBoQWEzc0JsSVlwOTIzRE0vVTZBd1VncjVKRTQ2NHpxTm4z?=
 =?utf-8?B?Z0Nqait3WmdUZ1B3WFByVnVpTm5rc1prbmsvS2tnQTAwNjJoYWxjb2xIZEtP?=
 =?utf-8?B?YytIK1hndWdEV1JsVW9vdlhvdmFSWTIxeis1b3NZV291VTIxVFlxZXFBQ3Fj?=
 =?utf-8?Q?sZJNTERXJh4WqQXOehCjUnYhEHuYIM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4149baf-1483-4d70-167b-08da07b3211b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 01:11:56.4341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u8riAQFTSsCt9mDzdO/WkSVvcrjgXBK+6BOxYnwDA8smpouxknAAgaYG3Ekh1ktshneiP9IGFwkWJu5I2t5a5Z2CPaqWJMg1ESr1DoL3KtI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1629
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

<snip>

> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index ddbc7a685a50..63c56d668963 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -976,6 +976,8 @@
>   #define GEN12_COMPUTE2_RING_BASE	0x1e000
>   #define GEN12_COMPUTE3_RING_BASE	0x26000
>   #define BLT_RING_BASE		0x22000
> +#define DG1_GSC_HECI1_BASE	0x00258000
> +#define DG1_GSC_HECI2_BASE	0x00259000

You ended up keeping the HECI1 define. Not a blocker, so:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

>   
>   
>   
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index f9b955810593..576d15a04c9e 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -141,6 +141,8 @@ enum intel_ppgtt_type {
>   	func(has_flat_ccs); \
>   	func(has_global_mocs); \
>   	func(has_gt_uc); \
> +	func(has_heci_pxp); \
> +	func(has_heci_gscfi); \
>   	func(has_guc_deprivilege); \
>   	func(has_l3_dpf); \
>   	func(has_llc); \
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> new file mode 100644
> index 000000000000..587f25128848
> --- /dev/null
> +++ b/include/linux/mei_aux.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2022, Intel Corporation. All rights reserved.
> + */
> +#ifndef _LINUX_MEI_AUX_H
> +#define _LINUX_MEI_AUX_H
> +
> +#include <linux/auxiliary_bus.h>
> +
> +struct mei_aux_device {
> +	struct auxiliary_device aux_dev;
> +	int irq;
> +	struct resource bar;
> +};
> +
> +#define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \
> +	container_of(auxiliary_dev, struct mei_aux_device, aux_dev)
> +
> +#endif /* _LINUX_MEI_AUX_H */