Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 15 Mar 2022 18:53:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     xkernel.wang@foxmail.com, nsaenz@kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: mmal-vchiq: add a check for the return of
 vmalloc()
Message-ID: <20220315155314.GQ3293@kadam>
References: <tencent_7F2A8AAFF05125C6FF159033E69B5C108E07@qq.com>
 <YjCwagaijyA2oO8r@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YjCwagaijyA2oO8r@kroah.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kt9+YuVtDlvHybPkD96OrDMqITHk120nduVTncDhFfwG2D6PH0tRZZb/S8IJ?=
 =?us-ascii?Q?OVgenouFNEB3cmavrIlqzADcx4IWrI8i0LtlGoKmATAHhgFoEdJCj91PH9Xr?=
 =?us-ascii?Q?TPnHttlqHSxKZJG1U6MMiJ3ZfJ4jnA6chkzlnJ5AM7SxiI7Zl0+CslnPhb7L?=
 =?us-ascii?Q?OZfIqjF7VJIE5GJC/Uy7+jO9pyC/jrAfjjUZO1FLhoykQH2Is0x/TR6XxOKh?=
 =?us-ascii?Q?sKdi8BII1EempDPElzkkBkgccSkQJg8Pw7Ltn4t8wf+MqnqOH1vjsAMcs7xJ?=
 =?us-ascii?Q?Q8IcDXP1EWIXeisWTAiUgwXFMPFhuWiDc7u1dvqqDTOcw/nvhW2UHj0LWsA5?=
 =?us-ascii?Q?DC5klAc+Y7c/UyYyT+tx26z5pgBDoqQwp/kpz3kxhYEJMy4YrLoqmv4oLlTd?=
 =?us-ascii?Q?k8e/E1xfZFNdu+H5kSyl3S6oIXRCso62CTlCOiW6LK1TTOvKHcUbjtkQ3GU0?=
 =?us-ascii?Q?2z+Sbq+D9tDTaWYFL3KrpK7PEfY8F3MiCWdoLx6+tzaXTt6DUZs9iYu4GvmB?=
 =?us-ascii?Q?E7A6grSaZkQNIvlztuCmZTkHhE+vEXkkssmHPQ5pHl8q6KcyaVkuNnTnjP/k?=
 =?us-ascii?Q?E845m/kZSchN0lqHAYMTb04bvM3eMMRt9hWXXgiq26ivBAwYDR1YxZ/OkM2z?=
 =?us-ascii?Q?TETqbOdUTlchr85YEcvK8gw9bX01Xesiq6yNBJAs4NkyC8EWhTORBcOpzhrW?=
 =?us-ascii?Q?8VoxRhRTRe7o2dStrevBjbS4F8O4XUW0AkUtdMYZ+iHSYJz1D1xpUK6kJvFg?=
 =?us-ascii?Q?X9FqrJ4XptEOXzJvPZoS7c7/32rmXGPcWy4UCtd1dpCFF2YG/fDN5PYCGkmU?=
 =?us-ascii?Q?cGqnGrQR9X03ZC+yJrN0GFJaAVQumCdIJaI7lsYkZL+W0wc74riHifusmgyf?=
 =?us-ascii?Q?0xh1GVhbUw7SZ9eRYhqLr6t9DUzbyliVmfCn5cVSOw1G+kvdgtgKWusZ1ykz?=
 =?us-ascii?Q?Rf/oHLt3DG3u2mG2JGBZRx3H1+bxQ3h5cnScuWqTFNazV97vU0t/1Xf3srts?=
 =?us-ascii?Q?15Wa82uusdcVsuydj/6uIJRkbIjdXLTnFQ1OS/KkgS+yHOXXlwyBQkthCGhZ?=
 =?us-ascii?Q?8rRpmeMIyd2737OtaW4QGyTqQDwBcKL5e0VaQRCnq/p5pbGTJrFsbjowd0dy?=
 =?us-ascii?Q?WWIpIcVWC4xavesXv8WoI3WLZ9nUUebTRm0Ph8rsJKwQeAVoj5ucfc8GdHTE?=
 =?us-ascii?Q?DiBfeHn4SZR9AuKFPzR5+ntUSh3hmImJ5PHkXfIeRx74EQ/F+sYHFWIJApcJ?=
 =?us-ascii?Q?j6i5F8WI7qx+OR9fm43PqN5d34XwYvx5uIiJTgx2x8bJgI8u4jyAdSjohEOw?=
 =?us-ascii?Q?l25E7ZoyFCaR+zaO5Whil7DYpCBX0Em4YQNuLbzGeFrJiCDpiBa5QpsuxUAp?=
 =?us-ascii?Q?vYkJZTTqqOQaTF2vEl9/6dSrKQ4LFSisoxoLyoGLo47CkfuvI7bmeR8yLxzj?=
 =?us-ascii?Q?5iWRLVicGaBFIm6RcGARZBmqI6SNlmVnSuWyuROKMzBNUUNXteloxw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb44bdb3-a70b-47d9-554e-08da069bf894
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 15:53:38.8389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h3Fzls7eSJyVCUl5DAw3a/9b5Cs0EHNny/QmoEJrVn/claEnrCupL6W4RCDOdbPq2I1p3dQu+GE+/jETco6lITF1/ow2akFJ7IWx3j2nuwQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5676
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10287 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203150101
X-Proofpoint-GUID: _VRywCmCWLGFr7NgYkym4ZIxOECg588V
X-Proofpoint-ORIG-GUID: _VRywCmCWLGFr7NgYkym4ZIxOECg588V
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 15, 2022 at 04:27:38PM +0100, Greg KH wrote:
> On Tue, Mar 15, 2022 at 10:42:07PM +0800, xkernel.wang@foxmail.com wrote:
> > From: Xiaoke Wang <xkernel.wang@foxmail.com>
> > 
> > vmalloc() is a memory allocation API which can return NULL when some
> > internal memory errors happen. So it is better to check the return
> > value of it to catch the error in time.
> > 
> > Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> > ---
> > ChangeLog:
> > v1->v2  jump to the proper location and remove redundant instruction.
> >  drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > index 76d3f03..ff4b484 100644
> > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > @@ -1909,6 +1909,10 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance)
> >  	mutex_init(&instance->vchiq_mutex);
> >  
> >  	instance->bulk_scratch = vmalloc(PAGE_SIZE);
> > +	if (!instance->bulk_scratch) {

Is ->bulk_scratch even used anywhere?

regards,
dan carpenter