Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <61684923-30eb-96eb-7c76-bab9119667bd@redhat.com>
Date:   Tue, 15 Mar 2022 22:12:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 3/3] KVM: x86: Trace all APICv inhibit changes and capture
 overall status
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>,
        Chao Gao <chao.gao@intel.com>,
        Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220311043517.17027-1-seanjc@google.com>
 <20220311043517.17027-4-seanjc@google.com> <20220315144249.GA5496@gao-cwp>
 <57c2d5d64f9d65e442744fa8b7f188ed3fd37c1c.camel@redhat.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <57c2d5d64f9d65e442744fa8b7f188ed3fd37c1c.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/15/22 15:48, Maxim Levitsky wrote:
>> Note that some calls may not toggle any bit. Do you want to log them?
>> I am afraid that a VM with many vCPUs may get a lot of traces that actually
>> doesn't change inhibits.
> I also think so.

Let's keep Sean's version for now, it may also be useful to see the 
state changes for all vCPU threads (based on the pid field in the 
trace).  We can always change it later if it's too noisy.

Paolo