Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 14 Mar 2022 12:22:45 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Jim Mattson <jmattson@google.com>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Subject: Re: [RFC PATCH v5 005/104] KVM: x86: Refactor KVM VMX module
 init/exit functions
Message-ID: <20220314192245.GC1964605@ls.amr.corp.intel.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <8a8ec76f1700114d739623b2860630eacd277ab6.1646422845.git.isaku.yamahata@intel.com>
 <d1c7ee86-8093-d04f-747d-aabbc1452801@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d1c7ee86-8093-d04f-747d-aabbc1452801@redhat.com>
Precedence: bulk

Thanks for review.

On Sun, Mar 13, 2022 at 02:54:15PM +0100,
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 3/4/22 20:48, isaku.yamahata@intel.com wrote:
> > -static int __init vmx_init(void)
> > -{
> > -	int r, cpu;
> > +	if (sizeof(struct vcpu_vmx) > *vcpu_size)
> > +		*vcpu_size = sizeof(struct vcpu_vmx);
> > +	if (__alignof__(struct vcpu_vmx) > *vcpu_align)
> > +		*vcpu_align = __alignof__(struct vcpu_vmx);
> 
> Please keep these four lines in vt_init, and rename the rest of
> vmx_pre_kvm_init to hv_vp_assist_page_init.  Likewise, rename
> vmx_post_kvm_exit to hv_vp_assist_page_exit.
> 
> Adjusting the vcpu_size and vcpu_align for TDX (I guess) can be added later
> when TDX ops are introduced.

sure. I'll make it like
  vcpu_size = max(sizeof(struct vcpu_vmx), sizeof(vcpu_tdx));
  ...


Thanks,
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>