Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 16 Mar 2022 16:03:54 +0100 (CET)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Petr Mladek <pmladek@suse.com>
cc:     Chengming Zhou <zhouchengming@bytedance.com>, jpoimboe@redhat.com,
        jikos@kernel.org, joe.lawrence@redhat.com,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        songmuchun@bytedance.com, qirui.001@bytedance.com
Subject: Re: [PATCH v3] livepatch: Don't block removal of patches that are
 safe to unload
In-Reply-To: <YjH7rniD4rBO6JIP@alley>
Message-ID: <alpine.LSU.2.21.2203161602490.6444@pobox.suse.cz>
References: <20220312152220.88127-1-zhouchengming@bytedance.com> <alpine.LSU.2.21.2203161536330.6444@pobox.suse.cz> <YjH7rniD4rBO6JIP@alley>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

> > > + /*
> > > +	 * Only need to set forced flag for the transition patch
> > > +	 * when force transition to KLP_UNPATCHED state, but
> > > +	 * have to set forced flag for all replaced patches
> > > +	 * when force atomic replace transition.
> > > +	 */
> > 
> > How about something like
> > 
> > /*
> >  * Set forced flag for patches being removed, which is the transition
> >  * patch in KLP_UNPATCHED state or all replaced patches when forcing
> >  * the atomic replace transition.
> >  */
> 
> Or just the first sentence:
> 
> 	/* Set forced flag for patches being removed */
> 
> The rest is visible from the code.

True. This would work for me as well.

Miroslav