Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 15 Mar 2022 20:30:37 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     xkernel.wang@foxmail.com
Cc:     gregkh@linuxfoundation.org, nsaenz@kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: mmal-vchiq: clear redundant item named
 bulk_scratch
Message-ID: <20220315173037.GC1841@kadam>
References: <tencent_F721901366AB5C720E008AF7F02DA5D3FF07@qq.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_F721901366AB5C720E008AF7F02DA5D3FF07@qq.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HtiVPw6gW483rHEJidhFxoW8tQyTuO9k43XyfdcMXrHJ08/3NsyCdi4XbZeu?=
 =?us-ascii?Q?5q2efa64S2p/qk3OVZNS7WukslmLRF7piZ3n4BFlVRjBNA01rSJxze5m75/E?=
 =?us-ascii?Q?mUg8MFVSd47BbJTGJoiVkjRiFIE0TWgCBj9r4+9/NnqlOJvUUMUKL4M3QTPt?=
 =?us-ascii?Q?aIbY/7iLo7pjLxwDlIuw2R3iuBzH02B/eDX+HS1BQr16wMaOzrn0FiqhimLx?=
 =?us-ascii?Q?xxwmQPwCZCh0sUK0Qp+lJgV0cZZ5O5E7V7To1KzOR0lj4pm8V4RdXQHZkd0D?=
 =?us-ascii?Q?uZNZXvHcXAcUId4akNGdzoJJLIUeuBmy60l79H6Kh2X9x6yfy9MSsxKA1Oui?=
 =?us-ascii?Q?EpRTO3EuT6NGxfJozQHRn2rT2oRxzHwbkNGK49GdbfZHUbfUnjSCjWutwuHX?=
 =?us-ascii?Q?ZLZNRpehxzsCUrQCFw3vR5HhuNK6WU7Ve6H16oB1DSLwywZdGq+1WjIsysfd?=
 =?us-ascii?Q?TE0nGC1yTPUz87BrGQQL0MmHbb3dAg1vni8HKyMuGjIYWAvKPE+I7Lo4YnKH?=
 =?us-ascii?Q?R2P248PasPyqwhF7SjTEhqRxm1JJ5KE+aws7CqbBQyOyFYENQwFFi+j6Nud/?=
 =?us-ascii?Q?2c2AEi8/WlBCzOXevVe3OqNrOPLO1Xg+YaAfn+NNI6rOFkAyTB5os0lzNQUN?=
 =?us-ascii?Q?Id9XkAZl+p/rE/gU2v2fVycMMu/DgTIHyFEwwEKwsk9YgHtx8ed4xZNF45Ld?=
 =?us-ascii?Q?UhMek3/ytVuO4DhyIH7M3hWXWMo4zCWf6TNm3VNe5dZXygwRF5McDdrByvun?=
 =?us-ascii?Q?azr+jHeT/+jJvRtHjqb5PHTMn8TevP+IRGFp795sJjpv+G/0UAH2ctk7LVY7?=
 =?us-ascii?Q?TfXwa2XEiAGoM1fsxvJEk5lDZbA5On4HaVrHRVxitGHWvCq7s5AeP0vEomp1?=
 =?us-ascii?Q?K4+rUfUMRUMG8W1PFS/xm2LU0XKh4G2En9blz1LDJdLtAwpM1wUFG1fuAV/L?=
 =?us-ascii?Q?9ATvZH4bH7i2wuDLBsl38JSowMtexeaQ6/Bl/tgNbdITNvVCeEEFGkLqF1/g?=
 =?us-ascii?Q?vGCyhwMhOvtSTGrPnmaBuVet6t8CxNEzgu4GmxvlVmS454RGUY3lVfC2hoE2?=
 =?us-ascii?Q?ZvudjJx2Fjnq1DjBgkPaGLuvprDIvGzSAAr528PKd2KcL4hBDwmjsFqFl5Pn?=
 =?us-ascii?Q?l+8VrAEnHGJRR1WRHk+1Fz1C2NcgD4SlPXBNa3nEOzGpVGTKozj5rWEur789?=
 =?us-ascii?Q?rP5JaH+mAGEoRtDQcVDfNMXsLHeGGXXY8xZqa37ksZcnZgIdB85FjgH7218K?=
 =?us-ascii?Q?7+ZaAI/bTthncBEQZEpNfZLqxD6hLv18ch5WTq76oksz1fXE61u1aQWWoZ1Z?=
 =?us-ascii?Q?BWK1z1o/MDbQuSGwtPwZx9l3h5uBVC09zcHZaU2HKttH/4xUW2Osm5xFRQSR?=
 =?us-ascii?Q?tl1taQprmafZzFXeQ/ysxSEuOIzPT4T0sl1nFT97ZNkuzTv0pcfOWqhlL4xg?=
 =?us-ascii?Q?5XqzMtFgkeTny+gNmRsael5T6PLB9a12FMlcOChrcbdAQv8WUFPDGg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ed798b5-c25c-4a7b-fc69-08da06a9920a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 17:30:59.7342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ZXwsQ/431ZQmqymXYVxHMSLbZEjeI3qvVrDOSQBMEhcepW21EXD5LlLV5nioIKVxr7zCpXySIbKANrMDlJ11pMVIa1u4ioAQSNyUId77Gc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3384
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10287 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203150105
X-Proofpoint-GUID: SlAMNMx7PXYi1MG9T2IkvSJG3nNRGP2N
X-Proofpoint-ORIG-GUID: SlAMNMx7PXYi1MG9T2IkvSJG3nNRGP2N
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 16, 2022 at 01:24:12AM +0800, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
> 
> bulk_scratch is not used anywhere and the original allocation of it
> does not have proper check.
> Deleting it directly seems to be a good choice.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter