Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
IronPort-SDR: hbIdOk3vU4FPpo3fQhQ1kONk0mOKX6eMH7WC9iRweOltebpXYYZSDwz9XzQVU5jThQy+2czU8O
 UXF62fW44OLDS/Vd51MqtZmEjNliX53hbpJg/rjXdKVKVQqnb4nbyfatDkVo1JDtSwJaeCXSI1
 xGGaCH6FJ2a6xebTq/wQLDmImuM2oX8okS8kE4Esbn02oavTPv+Zaf/RyxCzTX4HRGLsN1zrtx
 T0uE8ieZbbPs7sTSWAbQYeELj+0V4lnSxGwt9UOgL4EfI+6XlwkaHfSYAKX/SgyUqWeriECoou
 S/77slVith/UqZ0pePD+POhC
IronPort-SDR: kamlRWwlZXu3IeeJikqoJsCsfT4BmoJWwBS932xBtha4MjerxxpBz+gkmKSc8sfRFmuqJxt7+u
 b+nkw1poQo57kadrnrrW2O3MLZE8p2GkEuv2AGaODGU2H9PJJtwv+Gnz+//6T/kvMVsPaR4wqG
 YcRIrilw1bXCv41w8WVHaI4NGR7Pb/P6laf0+zPiJl5aVnc9Bb/HYn2gtRWzcZLsMwEaTYaUsE
 vuQQt4+RTjaevBN9xSEHD6EtrBw6p6Ihd1kBZySV+NVYpnD4zRS8zM3IIs6Fz5p9Q1z25tcZBO
 fLo=
WDCIronportException: Internal
Message-ID: <c44014e6-37ca-8a6b-3e8a-5d659bbe1f1d@opensource.wdc.com>
Date:   Thu, 17 Mar 2022 08:23:03 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH RFC 2/2] libata: Use scsi cmnd budget token for qc tag for
 SAS host
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, Christoph Hellwig <hch@lst.de>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com, bvanassche@acm.org,
        ming.lei@redhat.com, hare@suse.de, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        martin.wilck@suse.com
References: <1647340746-17600-1-git-send-email-john.garry@huawei.com>
 <1647340746-17600-3-git-send-email-john.garry@huawei.com>
 <99541f2d-2aea-6bd7-e3b6-21dbc355875d@opensource.wdc.com>
 <650c667f-ca55-821d-4e0f-29fce69a68fc@huawei.com>
 <20220316083439.GA6701@lst.de>
 <4dfcddff-7736-e01e-7fcf-804de77ac623@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <4dfcddff-7736-e01e-7fcf-804de77ac623@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/16/22 19:46, John Garry wrote:
> On 16/03/2022 08:34, Christoph Hellwig wrote:
>> In addition to the comments from Damien:  I think we should kill
>> ata_qc_new_init as well.  It is a bit pointless and having it in
>> libata-core.c when it pokes into scsi internals also doesn't make sense.
>>
>> So maybe something like:
> 
> Seems reasonable to me at least.

Yep, that will be a nice cleanup.

> 
> But I'd send these as 2x separate patches.
> 
>>    *	sata_async_notification - SATA async notification handler
>>    *	@ap: ATA port where async notification is received
>> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
>> index ed8be585a98f7c..5e0bc7b05a107e 100644
>> --- a/drivers/ata/libata-scsi.c
>> +++ b/drivers/ata/libata-scsi.c
>> @@ -638,24 +638,44 @@ EXPORT_SYMBOL_GPL(ata_scsi_ioctl);
>>   static struct ata_queued_cmd *ata_scsi_qc_new(struct ata_device *dev,
>>   					      struct scsi_cmnd *cmd)
>>   {
> ...
> 
>>   
>> -		if (scsi_cmd_to_rq(cmd)->rq_flags & RQF_QUIET)
>> -			qc->flags |= ATA_QCFLAG_QUIET;
>> +	if (ap->flags & ATA_FLAG_SAS_HOST) {
>> +		/* XXX: add a comment here why SAS is different */
> 
> I think this is simply because SAS hosts have shost.can_queue > 32
> 
>> +		if (WARN_ON_ONCE(cmd->budget_token >= ATA_MAX_QUEUE))
>> +			goto fail;
>> +		tag = cmd->budget_token;
> 
> thanks,
> John


-- 
Damien Le Moal
Western Digital Research