Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <YjDV3n1Xq/EGWU1E@Ansuel-xps.localdomain>
References: <20220313190419.2207-1-ansuelsmth@gmail.com> <20220313190419.2207-2-ansuelsmth@gmail.com> <20220315175520.32E1AC340EE@smtp.kernel.org> <YjDV3n1Xq/EGWU1E@Ansuel-xps.localdomain>
Subject: Re: [PATCH 01/16] clk: permit to define a custom parent for clk_hw_get_parent_index
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Rob Herring <robh+dt@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org
To:     Ansuel Smith <ansuelsmth@gmail.com>
Date:   Tue, 15 Mar 2022 14:30:28 -0700
User-Agent: alot/0.10
Message-Id: <20220315213030.C8E47C340F4@smtp.kernel.org>
Precedence: bulk

Quoting Ansuel Smith (2022-03-15 11:07:26)
> On Tue, Mar 15, 2022 at 10:55:18AM -0700, Stephen Boyd wrote:
> > Quoting Ansuel Smith (2022-03-13 12:04:04)
> > >   */
> > > -int clk_hw_get_parent_index(struct clk_hw *hw)
> > > +int clk_hw_get_parent_index(struct clk_hw *hw, struct clk_hw *parent)
> >=20
> > Please introduce another API vs. tacking on an "output" argument to this
> > API. That makes the patch less invasive. And it can also return a
> > pointer instead of an integer in that case.
> >
>=20
> Any suggestion about the name? clk_hw_fetch_parent_index? That would be
> a direct access of the internal clk_fetch_parent_index.
>=20
> The name is already not that intuitive as is. The alternative is to make
> it extra long, don't know if that's a problem...
> Something like clk_hw_get_parent_index_by_parent? (that is even more
> confusing)

Haha that's a mouthful. clk_hw_get_index_of_parent()? I realize now that
I misread the API because parent wasn't a const pointer. Please make
parent argument const as well and return an int as before.