Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp929123pxp; Wed, 16 Mar 2022 21:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx34blQaG1VqPyn+sFUmq0zX+Ucwoevkd2mVwUtvI0CAZUgjsNx3G9lEUZmKpyiTDv+Tdf+ X-Received: by 2002:aa7:8d54:0:b0:4e0:bd6:cfb9 with SMTP id s20-20020aa78d54000000b004e00bd6cfb9mr3201349pfe.60.1647491949283; Wed, 16 Mar 2022 21:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647491949; cv=none; d=google.com; s=arc-20160816; b=z7oXjvIWnSS8c/CyP1vcbG2shveI/oVSTF2YBN/cq8sIUJguFE1ypFWilFawq3KHYq SPABgVaetc3LhARCfDugso88tVyW2dVaATojfFHkfULFl5DjB0WXaaTw4/XcYNk74FVu FtJ8JEWUHEABgp/PiGO06fpq7YncD+5kKm27AK9NsT0CvfFR9ngJPwTQcWw6JNrxcevj 7au1p88Q+Oy4fGA2KIklllsehVEhvfsSpf/BsuAL3J0YUr5o6paG3qINy9cZeeDt/fV2 bGst8ctF3d503Hamk8x8eA+tZKHqocB34DbmFQ0biIb9YvpTm0SIGa2e6Am7p3q7TO6A C6Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=/XaVbptuosksAOt8Z4HRrBY1zn4OOaD+2OPXbzAwLb0=; b=VB8uDk7HACele3on9cmAYPvD167GpECdLjvPja0yl+q0sPWw8VQb854IuY+MoABVWe PVcXVr1RpGnk6Vei1UFGKEDnKQAQeaHbCrckR/i/nVtu+EUwEyXKiL0RHnAEgx6A5I8A 87P9vIkuEmZODz9wfuJ6KjuBVo3ZF2zL5TwOxJGgBSpjWmAgh4O2gRQN32zoOOECJzFx eOAxrlqB504fC8dFPS+gVoEPi1eobXDGTA7VpG5QEwdqjRyAzB3VsTKzq5x5Ehur6lYx OfAhjra90tc1jTd1yQbWJwFLk5qxsj174S0XVq2Ji4mqkR7SxDEvQxSx+Yc4pcmsbMjK MjPA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h14-20020a170902f54e00b00151cd0009b7si3903916plf.233.2022.03.16.21.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 21:39:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC94C11861F; Wed, 16 Mar 2022 21:04:01 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354438AbiCPIRB (ORCPT + 99 others); Wed, 16 Mar 2022 04:17:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245093AbiCPIQ7 (ORCPT ); Wed, 16 Mar 2022 04:16:59 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A9263502; Wed, 16 Mar 2022 01:15:45 -0700 (PDT) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KJNMg5S0wz67Zgf; Wed, 16 Mar 2022 16:13:51 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 16 Mar 2022 09:15:43 +0100 Received: from [10.47.84.96] (10.47.84.96) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Mar 2022 08:15:42 +0000 Message-ID: <1bde0883-bfbb-ea54-82f0-4e53b884b24b@huawei.com> Date: Wed, 16 Mar 2022 08:15:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 0/2] scsi/libata: A potential tagging fix and improvement To: Damien Le Moal , , , , , , CC: , , , References: <1647340746-17600-1-git-send-email-john.garry@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.84.96] X-ClientProxiedBy: lhreml735-chm.china.huawei.com (10.201.108.86) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2022 03:25, Damien Le Moal wrote:s Hi Damien, > I tested this and it is working fine for me. This actually solves the QD > not changing problem I had detected with the pm80xx driver. > Now, doing this: > > # cat /sys/block/sde/device/queue_depth > 32 > # echo 16 > /sys/block/sde/device/queue_depth > # cat /sys/block/sde/device/queue_depth > 16 > Having this working is down to the first patch. So I will resend that patch today separately so that we may look to have it included in 5.18, even though we're so late in the cycle... > is working as expected. > > See my comments on patch 2 for getting final ack and tested tags:) OK, Thanks, John