Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp929227pxp; Wed, 16 Mar 2022 21:39:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJpREXLQMdnpwg1hAcGRnjoYyeWXBvE9GgDTnrLRsMKh+Q27SCty3Q+6J9Tu+BYD/BK9gZ X-Received: by 2002:a17:902:c94e:b0:151:a988:f3dd with SMTP id i14-20020a170902c94e00b00151a988f3ddmr3260238pla.142.1647491962556; Wed, 16 Mar 2022 21:39:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647491962; cv=none; d=google.com; s=arc-20160816; b=Gyp2Tp2+ssJKAzDd1R2W2PWPBnvnm2uCs/iKwBdVEmQlsi1qnuti43ZWMVPomqZK9b IU4iG9jDQntf/FpSxulJu7hrRzxrVItxK5KQlIUhi7J6W6/ChL558qPvOru7gjR2LCtM KUKhtMuFgOONrmlmR9BAO4f8mhegH4x5kc3kLqVnNteV0k4j/+NyeidNWF0PT1GNHHm6 mGEDJfNxZ99l8S4fi/zTyxdIG48iHk92mep3e/12t+6eJ/cLOaEUkuYVOSFKTy4+TutF a3DSNIVDgxdptmCjfMtyhejb9pMIhmoHn0a4vhc9QSUHicBYCyd5NpJvnymTlh+/T41+ lDyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=kaoO3EP9Ml0rQEmjGQZt3HD7oo3ebXwAGsJomdnH1c8=; b=fGjfWvC16qxxHO11DjV0S4GlbG+LwlybRHC+yg2VkgRa9NFlHdIsw0Q4F8x5HzNTV5 7RTu6mp0BGmifTRfILupgLIFH+SwMYn8Vz/SRCLCJo6In44PJ3INpbUHbZAGWvbrckVw ZK+MM5QRf7V7KqKT7Sh46Ioanrvnhnhx5BdcZJCgnGcfAMV52ZgVIWjOZBNTNdheeA5s nSMvrl9E3DfYRBErKS+rKExEf/4RF23eEkCP0RSVAxb97cN5gvAantOUcsqfJ6BhpOTO SPRBopxO12niUZinnPdzD95FtPV8WWGjbEH5nOS58om6w6JXkmLIGBHtO+AFNi7fa6o0 CB3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VsVC9uix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b13-20020a056a0002cd00b004f6cc611716si3483384pft.241.2022.03.16.21.39.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 21:39:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VsVC9uix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 495AF119863; Wed, 16 Mar 2022 21:04:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343676AbiCNXVZ (ORCPT + 99 others); Mon, 14 Mar 2022 19:21:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237512AbiCNXVX (ORCPT ); Mon, 14 Mar 2022 19:21:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B69F1EAF4; Mon, 14 Mar 2022 16:20:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1DF9CB81091; Mon, 14 Mar 2022 23:20:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDEEBC340F5; Mon, 14 Mar 2022 23:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647300010; bh=2FdC7SwihSVVrZs4phed7Lbrp21pfyud0aUkZsI1zA8=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=VsVC9uixp0hNsOks/Wwq8a2FmoTGO7S63O8uUrVNV/kh39qbr1toIhu88f3ZQ/XAG 5LwAYgVXyVetXSgcBID/TjC/v0LE9wNGm9j5oWY0XeV7ppCaLn52ZfIMR0e+WXShZi 5MqYKBoG9PxvlnARBX9tIIxVTQ7YgzlNQ/FJRNk5ZKQOzXv3DD8+yTKzWRWieGkej5 pdn0xpOC0tsErjYtgD1vkKfpYDfL+p2dlCR56YSd+wcQiqT5hgKg+oJtELhoTWXC8r Ts3AhSxo9t+33I3R0RsFMHJOrVVrgS9fcc4Uu0YWp98+qHPhhW8JvC7EC6SHB1Po05 zTjZnxUDss9wQ== Received: by mail-wr1-f49.google.com with SMTP id b19so4056473wrh.11; Mon, 14 Mar 2022 16:20:10 -0700 (PDT) X-Gm-Message-State: AOAM532qxoVKQ+RmdLklbC7dkbwpqZBDDkarLh+rCJn2rBpudcnfE0kB gDpXt6r5IWqHZ3jOcmIiqMRt4mzAnS1qz8TkfTs= X-Received: by 2002:a05:6000:1d8c:b0:1f1:d8e2:fcb1 with SMTP id bk12-20020a0560001d8c00b001f1d8e2fcb1mr18618922wrb.165.1647300009057; Mon, 14 Mar 2022 16:20:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6000:1d93:0:0:0:0 with HTTP; Mon, 14 Mar 2022 16:20:08 -0700 (PDT) In-Reply-To: References: From: Namjae Jeon Date: Tue, 15 Mar 2022 08:20:08 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] exfat: do not clear VolumeDirty in writeback To: "Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp" , "Yuezhang.Mo@sony.com" Cc: "sj1557.seo@samsung.com" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Andy.Wu@sony.com" , "Wataru.Aoyama@sony.com" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2022-03-11 13:34 GMT+09:00, Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp : > Hi, Yuezhang,Mo > > I think it's good. > It will not be possible to clear dirty automatically, but I think device > life and reliable integrity are more important. > > >> - if (sync) >> - sync_dirty_buffer(sbi->boot_bh); >> + sync_dirty_buffer(sbi->boot_bh); >> + > > Use __sync_dirty_buffer() with REQ_FUA/REQ_PREFLUSH instead to guarantee a > strict write order (including devices). Yuezhang, It seems to make sense. Can you check this ? Thanks! > > BR > T .Kohada