Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp935578pxp; Wed, 16 Mar 2022 21:53:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAt3USGZvgsw7GF47MIhBKinDZ/dK65Gkh3yXPOF++C/92tYF3fgI/8XwyXcP7sXViY2vE X-Received: by 2002:aa7:805a:0:b0:4f6:f223:a459 with SMTP id y26-20020aa7805a000000b004f6f223a459mr3264932pfm.4.1647492791383; Wed, 16 Mar 2022 21:53:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647492791; cv=none; d=google.com; s=arc-20160816; b=GldW73Gj4i7qlmxFRWUKypq1ELmAtIjOCY/IeDQ4Grk2qn8Ib19evHE5imQL8VJd/m fwO9t/x6DN52TCjSr59Onxx6a2WSCIKrTmfoQz8AYoH5N6M5nTs73QyvuNOpjDZ60RiV e3S4DZv9lGvnXKBehLpx+rJD/07PgDRvoSa1GbwqzcR6xc6cCXuzbGGgsE1RRcJT4XHx QGfAtMu4gXv/0hzHHjDX/AAF4C/VP5/y2z4h92+e8PoSz33j5Hg10yQ/P+p2FZdMGPmF nlEOP1x8GoVLW9So5wPdZQLcw26VEErID2VvDF1ghCsWSDvUStMFUMnJQJ9f5SWedQhi Dt+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MJ8g2nsVgOnt1BBZ2rMxwhABfmg3IsPppyoDqT/lTQ8=; b=nFPSE22jobp4fPa6cS/BrLLkcGHV5easy0KUe2w2uCafdOThs91ogH0BUvafsyUnwa qj+r5gmZdgnblVcKJdWxrnLcJuulzbGGSBb9UPCW8wrqTwh9cUySZkX5+m9nqcBeoefI HB5iijdxolzDvbZTpwsa6jHk6HaFxPb3QPqGxltn+I1Cpjn45d7kNgupQPyTCwBPuJ1T pijyCCo6VR01ykVEj1fg/Y+XBpPa1fXWJdXkGVeNYzSzumDWbfU1JIrX3CThqR/d+wPx efLOzUidDBVe9bGHbDdQq07zFJtbKsv/ahBdaAlsNPYO+qZGJHntNXN0CbzSfBy8ALU/ SGtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=T+dcmDZC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id bl29-20020a056a00281d00b004fa282f54easi2256152pfb.102.2022.03.16.21.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 21:53:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=T+dcmDZC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 40098AD13C; Wed, 16 Mar 2022 21:11:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243867AbiCNX1X (ORCPT + 99 others); Mon, 14 Mar 2022 19:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241081AbiCNX1W (ORCPT ); Mon, 14 Mar 2022 19:27:22 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F2D43B551 for ; Mon, 14 Mar 2022 16:26:11 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: alyssa) with ESMTPSA id 379461F433AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647300370; bh=x8lO7dndy69NlEFUnZVKtUz8PSJBYw2u9qurEt77Vsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+dcmDZCNTDph2K+zp5okl/Ae4m+f/HMMa4eOTa7hDDJW0Ns/dkJY4eFiEVciL7lD aVoGX1VRUERwLeiXVd8iipVskwhB67RogoQp2Q9MMrVV3dWWqb958m+DUIq9haf0/U /wdOQGxOXhdjCh+kBLVNEujv45EZXyHQy414JOqgcJ+8uVDHg16AGf6bqc5QdvBe0B 2hkUjdk3EVqHua4taq3f0w/j8zRnRCoh8yVuH0WDF60ljaCssnrcZJo14eQc685dzK hUAJYrb8c6PFlooACVb4xJ+IAvgGDbGWoe/XcIA/tLih9GM6grNdxYzZdXvQHfZIHy f5zYTAOFRmevg== Date: Mon, 14 Mar 2022 19:26:00 -0400 From: Alyssa Rosenzweig To: Dmitry Osipenko Cc: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Steven Price , Alyssa Rosenzweig , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gustavo Padovan , Daniel Stone , virtualization@lists.linux-foundation.org, Dmitry Osipenko Subject: Re: [PATCH v2 8/8] drm/panfrost: Switch to generic memory shrinker Message-ID: References: <20220314224253.236359-1-dmitry.osipenko@collabora.com> <20220314224253.236359-9-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220314224253.236359-9-dmitry.osipenko@collabora.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2022 at 01:42:53AM +0300, Dmitry Osipenko wrote: > Replace Panfrost's memory shrinker with a generic DRM memory shrinker. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/panfrost/Makefile | 1 - > drivers/gpu/drm/panfrost/panfrost_device.h | 4 ---- > drivers/gpu/drm/panfrost/panfrost_drv.c | 19 ++------------- > drivers/gpu/drm/panfrost/panfrost_gem.c | 27 ++++++++++++++-------- > drivers/gpu/drm/panfrost/panfrost_gem.h | 9 -------- > drivers/gpu/drm/panfrost/panfrost_job.c | 22 +++++++++++++++++- > 6 files changed, 40 insertions(+), 42 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/Makefile b/drivers/gpu/drm/panfrost/Makefile > index b71935862417..ecf0864cb515 100644 > --- a/drivers/gpu/drm/panfrost/Makefile > +++ b/drivers/gpu/drm/panfrost/Makefile > @@ -5,7 +5,6 @@ panfrost-y := \ > panfrost_device.o \ > panfrost_devfreq.o \ > panfrost_gem.o \ > - panfrost_gem_shrinker.o \ > panfrost_gpu.o \ > panfrost_job.o \ > panfrost_mmu.o \ I'm not sure you actually deleted gem_shrinker anywhere in this patch? Diff stat is too small.