Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     "trix@redhat.com" <trix@redhat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "nathan@kernel.org" <nathan@kernel.org>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] igb: zero hwtstamp by default
Thread-Topic: [Intel-wired-lan] [PATCH] igb: zero hwtstamp by default
Thread-Index: AQHYNutt+L5RW/R3dE+eXMovLeKQLKzBjDKA
Date:   Wed, 16 Mar 2022 06:14:24 +0000
Message-ID: <BYAPR11MB3367BC9F34175A1D52EB68D4FC119@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220313150210.1508203-1-trix@redhat.com>
In-Reply-To: <20220313150210.1508203-1-trix@redhat.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qAkHyJ2Nrvh4QKhIknWOUIHM1teu49ZZp6GRD5ce0PacH+GVQ+Vp8DITG12x?=
 =?us-ascii?Q?6RzuYClgb3YaVL5Pmhn8abukYQU/fZ76xTTJ1QQdmJgLS0Qa4Ofgx89ZUAiu?=
 =?us-ascii?Q?Fkvfr39XhGIzAEbuuQXob6AKHn06kGq5H7W1iMF4cQ3zu3UNz7Sdzo9zQoaD?=
 =?us-ascii?Q?9ctZSfGdBeYFg54v+KM1r60EVwz9kUCHqrDunCwy/OQotQnEGJV7+hcapC0Q?=
 =?us-ascii?Q?tGMybYPNXCTXGjjwvuCplYGMx0T6/dvPMHmPJ61pI6R/SstIQK7Yac8Zm+rm?=
 =?us-ascii?Q?2BtCQyF0yxC8T5HRXkNb3ypIelrNpPjya0iVNlCLrhNcbP/B12IJuXCvbuMg?=
 =?us-ascii?Q?sHjsCqDDCTIsKISCo/sUaDb5CHZlZ7VW986BsSvtKm2dVR9rW1hehWnn4UEZ?=
 =?us-ascii?Q?Jwn6sCiypibcySYkLgKs1Xb47jrYtwOx4Te6xoOJIK5B1aoTbSTzuP/0788F?=
 =?us-ascii?Q?X1VxM5q5u6VEhNnVGJaVuEGNnOFg8iWVQNUwQwWihqPsfdBuVRmiP5Xberyy?=
 =?us-ascii?Q?+L4CoIsyVESjgg9vogP58hWS0yU9YxAEaJdATwiYufpuouvKBpcFXtpAlliF?=
 =?us-ascii?Q?O5hE5qNV8wvzPD/CxL+r0cHvJqr2xmEZLc2gtDPVqLIsGwb334YTt4bux8tB?=
 =?us-ascii?Q?XKfxI1Vp5+tB6/dMEGyIjIInqi61HfSojffaL7HCMVoJQlTURps8/i2NBzxq?=
 =?us-ascii?Q?jXLNDNAzzRvXWNPL3/fueHr7jFxal6ibwHbX/SyO/W/mDMvqALeMj+wg+o3w?=
 =?us-ascii?Q?h1QsHqYKdHJapqiJYXeoUhAZgFELxEiSMaY5r1Bhq8P9FY/Y/C6IGqABqsP1?=
 =?us-ascii?Q?FOhraD3mhpwF2X11jhnrr4jJIB6xbV21JIAEYh6i/c6xkNl9/BkP+YIjoMsi?=
 =?us-ascii?Q?dTXP8i0zbWl63FKsp6/THBR6gsg6HpyIg12NLezHjpBA8jGEiq5KdgqLBzp7?=
 =?us-ascii?Q?rx3iNOQp6WNP9o0iph4lz3as3nyBFPu4562csGPqqYfTHEZRdioFoCj35bFP?=
 =?us-ascii?Q?yq1e15BzL3O4IvukXR97y9ampAe6sOkXDWX72iuZPqYsVae1LDgeNjuoAQ/y?=
 =?us-ascii?Q?Pf6AoQFKAWWbxd6kzimmL1xPKyj2y8Ui3Ak0/iwRiE6vxdT0GsZ9rBzNZ2LW?=
 =?us-ascii?Q?O9LCnpZrHAViSWKWm9O5aszjHnxKqbMXR0b2Ja/u+m9NvQW+1YoWG2tBpP1T?=
 =?us-ascii?Q?aRr8Einvv5BKiKt8Zwas3MA4EAm0Wt9zDt4zKe3BnRL4KMsGf1GD2JF0V3OW?=
 =?us-ascii?Q?TOlefG1ezzWzM0mjoQiAPbYHAxCa1oaMOKnkA9LJEH2LZS1LNxluxUl5KPuI?=
 =?us-ascii?Q?5B+FvLoFv2VHCiSosL22MzX/xGPrFnbaIQdUyAP1Nqbeeitb4rCiGy0INhbx?=
 =?us-ascii?Q?CmyuLaB8PbFtEY9TmyW2aNWisEhFOU/rEh4OuFbIPn2snZdcfNbWGmZ+Reip?=
 =?us-ascii?Q?wr1hYhI6iAYinGssXLG+wSU/Ab3X0nQh?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 102e11a9-f5c1-4dab-63e5-08da0714380e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 06:14:24.6460
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FZ04nw5ALHR7JUVD8nAEKKO3gtv3eNptDaHMbHhuLt+PLweJnn8tHHB1AxjFeupfpbL0JIGHaaHsOTTHpCBTwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4218
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> trix@redhat.com
> Sent: Sunday, March 13, 2022 8:32 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; davem@davemloft.net; kuba@kernel.org;
> nathan@kernel.org; ndesaulniers@google.com
> Cc: netdev@vger.kernel.org; llvm@lists.linux.dev; intel-wired-
> lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Tom Rix
> <trix@redhat.com>
> Subject: [Intel-wired-lan] [PATCH] igb: zero hwtstamp by default
>=20
> From: Tom Rix <trix@redhat.com>
>=20
> Clang static analysis reports this representative issue
> igb_ptp.c:997:3: warning: The left operand of '+' is a
>   garbage value
>   ktime_add_ns(shhwtstamps.hwtstamp, adjust);
>   ^            ~~~~~~~~~~~~~~~~~~~~
>=20
> shhwtstamps.hwtstamp is set by a call to igb_ptp_systim_to_hwtstamp().  I=
n
> the switch-statement for the hw type, the hwtstamp is zeroed for matches
> but not the default case.  Move the memset out of switch-statement.  This
> degarbages the default case and reduces the size.
>=20
> Some whitespace cleanup of empty lines
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)