Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 14 Mar 2022 23:00:42 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <vincent.mailhol@gmail.com>
Cc:     Max Staudt <max@enpas.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220314220042.vpicmcrwvexxwk3c@pengutronix.de>
References: <20220307214303.1822590-1-max@enpas.org>
 <CAMZ6RqJZObevKPc29jW+m6i0eAgestTbw8KCPXxSGHzSXK7cRg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3ycyvbpbhbranjzf"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqJZObevKPc29jW+m6i0eAgestTbw8KCPXxSGHzSXK7cRg@mail.gmail.com>
Precedence: bulk


--3ycyvbpbhbranjzf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 08.03.2022 16:01:12, Vincent Mailhol wrote:
> > +/* Send a can_frame to a TTY. */
> > +static netdev_tx_t elmcan_netdev_start_xmit(struct sk_buff *skb,
> > +                                           struct net_device *dev)
> > +{
> > +       struct elmcan *elm =3D netdev_priv(dev);
> > +       struct can_frame *frame =3D (struct can_frame *)skb->data;
> > +
> > +       if (skb->len !=3D sizeof(struct can_frame))
> > +               goto out;
>=20
> Isn=E2=80=99t this aleardy guaranteed by the upper layers?

You can always inject packets via the packet socket into the kernel,
bypassing e.g. the CAN RAW layer.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--3ycyvbpbhbranjzf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmIvuwcACgkQrX5LkNig
011hxQf/RQ/sycT5AgFovH7C118vWmXWvYLZt9R+LGEiU/9AfY3b3IChu/WIVZBJ
ZbdnY7Wb9l/KVBGE7KTnpeUNdX3qwgQ4Xfbt+9eFUCFqEyAzUzWgN92NyVDlR3R2
JOowtZ30+EdcjRSGJ5CHOp/VWS4Flc7gHYfLWvC+ef5+IIN3xL47jcD8PjKgvC30
dNLfkxkt2YZo1niaUSNnD49vUqMHin7YDbpgNGv85iYQG0Iz2YU6ORUqCsgoaxd4
nGYj3ImRUFOxxu+c7cMBq7injzXVJlAnci6FIUAoOdmsy8cleNmoz1J6X5d2m+qu
f1UX3f1r6274L20mKBLVKACSdPCp2g==
=H7ZN
-----END PGP SIGNATURE-----

--3ycyvbpbhbranjzf--