Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7ac617f1-0187-c296-bc5a-f3e26ef21488@oracle.com>
Date:   Wed, 16 Mar 2022 09:26:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] scsi:libiscsi: remove unnecessary memset in
 iscsi_conn_setup
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Cc:     Wu Bo <wubo40@huawei.com>, open-iscsi@googlegroups.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zhiqiang Liu <liuzhiqiang26@huawei.com>,
        Feilong Lin <linfeilong@huawei.com>
References: <20220316220936.191013-1-haowenchao@huawei.com>
 <44860f67-e626-411e-5ee6-9055ea2d5723@huawei.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <44860f67-e626-411e-5ee6-9055ea2d5723@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ky9lYkNKdUx6ZUpKazlJaG5BMXNsWU5KYU1BbWR5Q1lpaXVFMzBHNGdPS3Iz?=
 =?utf-8?B?T0YvTllsa3U1UkVJc1JhVXU0RE5XaE9kaHUzRTBMalR3bHhxNDYzc3hTQjFy?=
 =?utf-8?B?dnBUMDVacWJtME5XSW5XRysxTnptbVBYTldlbEo0ODVWSU5COHE3VkdyMEx0?=
 =?utf-8?B?QkYvRituSUhMSnVjYlN3aWF0NXZUc1ZyVjFVRVV4QytrVzZCWVZrd24vR0pv?=
 =?utf-8?B?Sm5WVyt3SEZQUFN2TVNBRllpRERPK2c1MTFpRStFN1NKNi8xWkdWZnc5MEV5?=
 =?utf-8?B?UHkyU1YrVkp5MG1TMGl3UHYwMWhjTkJFWkpSZWs3K09xWmR1SkZUdW5sc3N4?=
 =?utf-8?B?V2NUWU1qaGRNVFdqRDcrWU9abGVTeUNRNStwdVdnSmhjS3o3bGNISWhqSHpG?=
 =?utf-8?B?ZFUrejRVYndSZ1hldk5vaG5JMlVIMzVncGwyWlEzUEhHVkU1SWRrczJ3WDBy?=
 =?utf-8?B?V1l4YzBjOUt2NXJNTlhDa0dpUXJzbHpQalRrKy9YczFPdXduZXJkYkJaL0tB?=
 =?utf-8?B?YVgvaTdpbEJpVzVhMTVWYUtzMGI2dHlqeGRuelR3Zm1hSGRwYWhjSmVhL0t6?=
 =?utf-8?B?NEFVOTBDVFBZSGN4cC9SdFJNM0YzSVoycEMzWDdzOGlneVF1UHExTmlTWEVo?=
 =?utf-8?B?cXp0cG1JWUk2NEZydTJDM01hMzVBclk0c1ZyV21mR2NmczhMcXV3ekltejJB?=
 =?utf-8?B?Z1VST2g3ZS9MS3VpVGlZNFhhdHNabjNDaTZMSFBhWkM2Tm9DVllBNlAvWXdi?=
 =?utf-8?B?YW92UHJoVEJBWkxzTlNnNmcySG1XVE5icXFPU0RyQWhuZmxWT0JtZ2JUaTFn?=
 =?utf-8?B?ZHF2c0QyZHY3UDlUclJtYVFBd3dyWjVpUlNjSzAzNytGM0Y5amRjOTQ4NFgw?=
 =?utf-8?B?bHdQSjdrYU53dXJxM1podWtpa1UxRFZCU3JIZDVteFExL1BPNnBWbXdXcS9G?=
 =?utf-8?B?NkFtZi8zS1BVVEJvcE8vQ3VqZWxuQWhCMjNYcWJMYXpDTHVWdUwyaXZzT05r?=
 =?utf-8?B?WmpIQlR4VVhJWlFBa3UrYmhxcUJFc2pET1dXbUpMQzVRcVdSazRuUXZyNVZs?=
 =?utf-8?B?R1ZFNnRlK1d2b1lIV1I1dlBpUkwxb1JHN3Ryc014clF3MkRYVDRYd3ZhbTJm?=
 =?utf-8?B?NnVKMlRRczh0ZDVNbEw3ZDNsYjRzc0R6bXpjd2JXMG5TZ1dyOHVwVHQ1N1NF?=
 =?utf-8?B?OVlCK3U2VGVVMTZHeFB5Q21uc205QW1RNWdrcUQwTnZ2ZFFGaHluV2s0TSt4?=
 =?utf-8?B?UzVmOVVJUTQyZGJNV1Zhb1JCc28rdzNISnlVRUs1Vk92SzJtRTh0WExMUGRi?=
 =?utf-8?B?NmFyMUJtMC9KVWFmUnVBKzRVZksrcGt6aUNCUStEcVpoMHJBMzNnOGRFTUFX?=
 =?utf-8?B?bE9aSDdTU3B4RitxNUlsUDd2V1pCc3ZPWXB0QWJMWXJGQ2NBVFVJdnVKd08z?=
 =?utf-8?B?aWQwdE5VSUwxQXJHVXhIbnNOR09uOEJYZTFGOVEzUUN6emxJbmdzMkhQdFNL?=
 =?utf-8?B?cXQ5a2RFWFpHOTIxQ05CbENFSkt2KzI3NjhCRVc1eE5HL2Z3c0R3RExBYS9G?=
 =?utf-8?B?cmx1RmdRbGZyYTZFUGlpWWRtc0hJamdtNzY5UFkvdEN1WnFNdDFsMDhMRDY4?=
 =?utf-8?B?eUNrTUw4RXFYcURHa3dPUlB6L3VBNlBPNmpaakRMWlVqSWptWW54QStRdnI5?=
 =?utf-8?B?djlNRVZOY1B4aWpUSkdFMEhiRUY5ZUtNNDVHdGRxdWttOXM1UnFvVGVaVllr?=
 =?utf-8?B?anQyV1FhTzFzT3lVQkdpekNKSThObjFQRDl1NE9pZmhUeXI4cTE5RUd0UVQ1?=
 =?utf-8?B?N3lVWUcxSzVNOWhHT0M5clVTc0NkdFQ0TzFOUVp2TTdOdmVFRU1yWWpzSzc1?=
 =?utf-8?B?czZvMWE2TE5oNWN2ZkliQUNMdHdkYzlTUjlIZjJXUVRvQmJDTXByWDRsYldX?=
 =?utf-8?B?RDExS210bjBualA5UkRmVGcyY1JYcDAvZ3NpNUNobjNHTDRHQnhpYmUrRWpU?=
 =?utf-8?B?MGpTYTBBRE9nPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20cc759b-a132-408b-0158-08da0758f1e3
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 14:26:22.4923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GdjMsm7iRVTLkU0daqBrgnQNSDvEEi6spHWVF3FIGTE11D2zcmRMHGvuK+3SUL1M93wmVBs2hZniSTbJm02nkkFQjY5rfmK38f4zmn+orwk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4955
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10287 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=976 phishscore=0
 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203160090
X-Proofpoint-ORIG-GUID: qiaz-3doKAGmGvVIvmC7bJPEKtTgxhap
X-Proofpoint-GUID: qiaz-3doKAGmGvVIvmC7bJPEKtTgxhap
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/16/22 4:02 AM, Wenchao Hao wrote:
> cc open-iscsi@googlegroups.com linux-scsi@vger.kernel.org
> 
> On 2022/3/17 6:09, Wenchao Hao wrote:
>> iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is
>> zero filled already including the dd_data. So it is unnecessary to
>> call memset again.
>>
>> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
>> Reviewed-by: Wu Bo <wubo40@huawei.com>
>> ---
>>   drivers/scsi/libiscsi.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
>> index d09926e6c8a8..cf4211c6500d 100644
>> --- a/drivers/scsi/libiscsi.c
>> +++ b/drivers/scsi/libiscsi.c
>> @@ -3045,7 +3045,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size,
>>       if (!cls_conn)
>>           return NULL;
>>       conn = cls_conn->dd_data;
>> -    memset(conn, 0, sizeof(*conn) + dd_size);
>>         conn->dd_data = cls_conn->dd_data + sizeof(*conn);
>>       conn->session = session;
>>
> 

The removal of the memset is ok, but you should resend the original
to the list because the formatting got messed up, and I think Martin
can't track this (The patch doesn't show up in patchwork/lore type of
things).