Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 15 Mar 2022 20:05:49 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     iommu@lists.linux-foundation.org,
        LKML <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Jacob Pan <jacob.jun.pan@intel.com>,
        Raj Ashok <ashok.raj@intel.com>,
        "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH v2 5/8] iommu: Add PASID support for DMA mapping API users
Message-ID: <20220315230549.GP11336@nvidia.com>
References: <20220315050713.2000518-1-jacob.jun.pan@linux.intel.com>
 <20220315050713.2000518-6-jacob.jun.pan@linux.intel.com>
 <20220315143535.GX11336@nvidia.com>
 <20220315093810.4b4c5ebf@jacob-builder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220315093810.4b4c5ebf@jacob-builder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KiXI/WBgXyf7+3Rk9PaCrK+xtJ9TFlRwqHLpuaSugKHaQsdUrWoGA+8O6zue?=
 =?us-ascii?Q?QESSRGdAMy2DsLLwNH6IJKWh7Qm2TTvcve/c4SS02JVmNWwCFvwQ4rphSGu+?=
 =?us-ascii?Q?BWDrHqnIDi5c2Bje4IpgrNPv9dCHMAg1ar+WfCWwaqtD0JCknk7bGR18k3W3?=
 =?us-ascii?Q?a0w0BQZtpu5oMJYWsfCpd878O5Zss1Slmk9xPIkvTh7VEEfHG7LhiiN5XpIQ?=
 =?us-ascii?Q?CVKa/hV4ENnhSLwMpuDGy3Oj6Iq3WYYtwgrv3BXUDm4a/AKlW5gC6SYWamxt?=
 =?us-ascii?Q?CoZlwIu3jdyqUgV9T1FV62Fg7wpZzA8abE0iwvIxMrBCjXRS9nc6QwYIe+Nz?=
 =?us-ascii?Q?m1ez5TALjTLr++VWoNO8NLrsaXdOkylb1nziiWWG7qcfe3+EKWyRAXH7zNbo?=
 =?us-ascii?Q?PTnFIvAYtdsu1prJIKkHHDbr9/NHZ73Z3EzEbjmZWEBAJ4IORXwIpo/+Ugme?=
 =?us-ascii?Q?a+BfHw9LGjqlMx64T4oQ1ApOZjFZO0qTjGFJYVsde/Ulh4P4xUGmZzXFePVR?=
 =?us-ascii?Q?WzVugdNAh/mI/BRUVi42DYckKm4sn9TM4ykh64bWhKB/cmnUADHAZEHUbShh?=
 =?us-ascii?Q?A7tqqJEzBPHi1CH8Scn/uFIGKIRzjMcsBjchRknh9R3Avn76dpxv5b5OvKyV?=
 =?us-ascii?Q?li05K1MB+Z68uzd8fV/nKsnsP8H9pIqc8SZ+B6wiNGm+mctU82Ba33JfBLEa?=
 =?us-ascii?Q?5z9plbHTmmUQOrH8Jo/4xQKCP8+3BNYjwDnDFsP/lhf1yW9FGIJTbpk5gFBX?=
 =?us-ascii?Q?KItqiMQyvpn4C/dST2UDpJvbxYxQGDd3NOERnpWUjsBJKMQKYmXZcnx9WSel?=
 =?us-ascii?Q?ILv2NUdLCV9+VjELJnKAUWp3Oylhff2nVA4zr5Ghc+DL3TTVMqCbCK1QOBhD?=
 =?us-ascii?Q?bE7ylDcKSkuAfPZRpJNhx2zk9RZ0/B/1R06vjK0XBCANZoixMAPP4fShtDGR?=
 =?us-ascii?Q?y9uEKy9hMO2AnJ8jgJ+1WyHkBXpktesKPVzxPNJvzQuQDHYq4Wj7Lt9O4RR+?=
 =?us-ascii?Q?MCrr3XU/glSCaVHEElaPHLZawmeK142PPIaRrukaWDOx7nsxvr6s0KL05RbX?=
 =?us-ascii?Q?b9v4bZJKA6/wW0W3fntGxzjwn25uXMdK1WMe2DOvi0OQCY1/sK9fEeT0WuL+?=
 =?us-ascii?Q?WjjSAGePQKNuwiH2Y/mw00uDhnM9/nRJzZ4klBtqF2aHfAcUx99yO4Mv/4mZ?=
 =?us-ascii?Q?bWBzwmUtD+GXs/b+xfjBTPcZ+Bmyw8BcL/srDAfWrz+dle0SN4WzxhIpuJSy?=
 =?us-ascii?Q?iGpFcWWJVFcBwMcl3eRlxhWmfBbUpjX43DMEimHMaKA2azy62HJPcHMIOiiB?=
 =?us-ascii?Q?qGHbv/NStXhcKunrihBQPEKxeYrZ4x3w2Di4S0M8Nc0bHeqa61K+ZnATbg1Q?=
 =?us-ascii?Q?aeMYhGTL+wh8rroZzlQBcQZ4ccayPl6NdXrXHbX8QNs68CLAI6nFN2bMTtXD?=
 =?us-ascii?Q?1/eR2b9RSTFslqBxjAe82MJAU4dQcm9M?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96029072-f972-41b0-1593-08da06d85925
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4181.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 23:05:50.6057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PvRoNkV1K240iGXxkScI+VG3Trsc3H+t5icdy0KhLMbRo9mcVAMLEpsFcqZqU/Rc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2558
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 15, 2022 at 09:38:10AM -0700, Jacob Pan wrote:
> > > +int iommu_enable_pasid_dma(struct device *dev, ioasid_t *pasid)
> > > +{
> > > +	struct iommu_domain *dom;
> > > +	ioasid_t id, max;
> > > +	int ret;
> > > +
> > > +	dom = iommu_get_domain_for_dev(dev);
> > > +	if (!dom || !dom->ops || !dom->ops->attach_dev_pasid)
> > > +		return -ENODEV;  
> > 
> > Given the purpose of this API I think it should assert that the device
> > has the DMA API in-use using the machinery from the other series.
> > 
> > ie this should not be used to clone non-DMA API iommu_domains..
> > 
> Let me try to confirm the specific here. I should check domain type and
> rejects all others except IOMMU_DOMAIN_DMA type, right? Should also allow
> IOMMU_DOMAIN_IDENTITY.
> 
> That makes sense.

That is one way, the other is to check the new group data that Lu's
patch added.

Jason