Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp952782pxp; Wed, 16 Mar 2022 22:28:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw9HwWBFZrqLvBrfZ+ItG6RhLxN4jeKPeEKtij3uVWDDVhg5aXshVdPqDR/FjTZ7eVVGVc X-Received: by 2002:a63:105f:0:b0:37f:f637:7adb with SMTP id 31-20020a63105f000000b0037ff6377adbmr2325738pgq.201.1647494883627; Wed, 16 Mar 2022 22:28:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647494883; cv=none; d=google.com; s=arc-20160816; b=OWwba/91FiziHVrQsTbT9TvDiSTKLRpwwGsG99pkZDMKRJKcMkJ+NP0v/hyFGK4IDy JJxIO9uRs4diEyEpdeZPihy/PUjCUiQPKzrd55qcP8qUNeUV6PlI7SairOCPJ08rL8/9 VPSaYrEm6W0ceu2kMsmEoHFhbQ+viP0lqIQrmBEG1zwNNnjO+La/t6xxrzVCiOBg5sro pjTWbcbX3X6XIrhVLv+raD1mnf5eI8kNnNjsFw8FxsaGU8AuVBFb+kRIENg7T96TeNmr Ddb4DnM/Tm73dmJhrvmItwFSvc2coP0uNkVVEHgvj7rUfHwpLspRGXyLTx39MZdX+rAX 5vUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=508jFcvN0UpUX+6aytOfQ3pYs9WHkzMNEjzA8savm3Q=; b=VHZgTIooGnPignPs0MbmjSyMvfCyMECV8kFdqg4eCNxWQpfKBJisLQeE8PHvICK0tD NvA6Ac2Jl+MQ2dw1YcMJJvoHdaWlpOAPhCy/NLtHTqDlHe22EE1kyYoYXbtgHvl70F5B mXHk2RFcI4lAeFqLYTsFPrcDtzxn9b34FJEXpSBIA6Hq8UQDnq5QjJlvxpxefk1yyB5a E92wnwbOJTLrZ2zvynqJXqP+ycr4jB7/T9npisAB2qvloFwuacOOoZYx0nEqT0Fh0fhv DIkxLIikISCE027xm71HebtJlqqIfOJbPGn5dbFexEzdcVT9wrKy/psWQ9khV4jp5KSg lBNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rVo60Uau; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id w14-20020aa7954e000000b004f6ded4bc59si3609471pfq.320.2022.03.16.22.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 22:28:03 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rVo60Uau; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F0528223207; Wed, 16 Mar 2022 21:29:04 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350204AbiCQC32 (ORCPT + 99 others); Wed, 16 Mar 2022 22:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231821AbiCQC31 (ORCPT ); Wed, 16 Mar 2022 22:29:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCC91D0E3; Wed, 16 Mar 2022 19:28:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3A46BB81A71; Thu, 17 Mar 2022 02:28:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74890C340E9; Thu, 17 Mar 2022 02:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647484087; bh=508jFcvN0UpUX+6aytOfQ3pYs9WHkzMNEjzA8savm3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rVo60UauBBVFJetcQppsANNRhdrZ7f2HT8w/7OmI0RsFKWSPFMfl3LvrolwwNUJ0a 2hIIEWQXkkFA5rgEh0R9HkL2aN/dwmlZBbB+jshq/g1iClqVuzXT13hAkvz141KA0G /9edxx1V8cewAJB5ZwolZsUJe/V2JHXkvurLoexMATkLb44RWKPrs5YK6Py7cJDSpy uCpRQNuP5EYa9HoLDi8HPCa7B/jNf+tQzuwHBYN7n104MBbmS2aGLGnxNbyyz79M7u lo7giJr+9soD6Xe9mtCYl4RV4hUxHO9Oi6boysQKlwrZGNHi7uLyYE4YVnwF0uyX3Y h+v0l+wAyV65A== Date: Wed, 16 Mar 2022 19:28:06 -0700 From: Jakub Kicinski To: Aleksander Jan Bajkowski Cc: davem@davemloft.net, jgg@ziepe.ca, yangyingliang@huawei.com, arnd@arndb.de, rdunlap@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: lantiq_etop: add stats support Message-ID: <20220316192806.1ebc120c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220315232733.134340-1-olek2@wp.pl> References: <20220315232733.134340-1-olek2@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2022 00:27:33 +0100 Aleksander Jan Bajkowski wrote: > This patch adds support for software packet and byte counters. On a quick look this driver supports multiple queues, so bumping per-device stats without holding locks (on the rx side) seems racy. Plus the netdev->stats are deprecated. The "modern" way of implementing stats is to add the appropriate members to the ring / channel structure and implement .ndo_get_stats64()