Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef12136f-fc4d-05c5-a7bd-66ade28957e4@huawei.com>
Date:   Thu, 17 Mar 2022 11:52:32 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH -next] bus: mhi: ep: remove useless judgement in
 mhi_ep_ring_add_element
Content-Language: en-US
To:     <linux-kernel@vger.kernel.org>
CC:     <manivannan.sadhasivam@linaro.org>, <liwei391@huawei.com>
References: <20220317033117.367027-1-liaoyu15@huawei.com>
From:   Yu Liao <liaoyu15@huawei.com>
In-Reply-To: <20220317033117.367027-1-liaoyu15@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Manivannan, I found that 'ret = ' has been removed. If this is intentional,
the check of 'ret' is redundant.

Thanks,

Yu
On 2022/3/17 11:31, Yu Liao wrote:
> Remove the check of 'ret' that is impossible to be non-zero.
> 
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
>  drivers/bus/mhi/ep/ring.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/bus/mhi/ep/ring.c b/drivers/bus/mhi/ep/ring.c
> index ac2043e71943..161505cd628f 100644
> --- a/drivers/bus/mhi/ep/ring.c
> +++ b/drivers/bus/mhi/ep/ring.c
> @@ -131,8 +131,6 @@ int mhi_ep_ring_add_element(struct mhi_ep_ring *ring, struct mhi_ring_element *e
>  
>  	mhi_cntrl->write_to_host(mhi_cntrl, (void __iomem *)el, ring->rbase + (old_offset *
>  				 sizeof(*el)), sizeof(*el));
> -	if (ret < 0)
> -		return ret;
>  
>  	return 0;
>  }