Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 16 Mar 2022 00:07:53 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     "Colin King (gmail)" <colin.i.king@gmail.com>
Cc:     Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" ->
 "vendor"
Message-ID: <20220315230753.6xymu77uirjbnn3u@pali>
References: <20220315223700.2961660-1-colin.i.king@gmail.com>
 <20220315224645.ytcf7y7awc3q2y6j@pali>
 <5ea0e154-e06e-32b4-be86-f38ce07b8bec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5ea0e154-e06e-32b4-be86-f38ce07b8bec@gmail.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote:
> On 15/03/2022 22:46, Pali Rohár wrote:
> > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > > There are several spelling mistakes in comments, function names
> > > and literal strings. Fix these.
> > 
> > I do not think that there are mistakes.
> > 
> > Please look at page 29 of the official bq24150 datasheet:
> > https://www.ti.com/lit/ds/symlink/bq24150.pdf
> 
> Looks like TI are redefining the spelling in the language :-)

Well, that could be truth, or maybe it just means something different.
It is about 10 years ago and I do not remember more details about it.
Anyway, in any case register name is vender and kernel code should match
official register naming for which driver was written...

> > 
> > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > > ---
> > >   drivers/power/supply/bq2415x_charger.c | 10 +++++-----
> > >   1 file changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
> > > index 5724001e66b9..b35700071966 100644
> > > --- a/drivers/power/supply/bq2415x_charger.c
> > > +++ b/drivers/power/supply/bq2415x_charger.c
> > > @@ -71,7 +71,7 @@
> > >   #define BQ2415X_BIT_OTG_PL		1
> > >   #define BQ2415X_BIT_OTG_EN		0
> > > -/* vender register */
> > > +/* vendor register */
> > >   #define BQ2415X_MASK_VENDER		(BIT(5)|BIT(6)|BIT(7))
> > >   #define BQ2415X_SHIFT_VENDER		5
> > >   #define BQ2415X_MASK_PN			(BIT(3)|BIT(4))
> > > @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
> > >   	return -1;
> > >   }
> > > -/* return chip vender code */
> > > -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
> > > +/* return chip vendor code */
> > > +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
> > >   {
> > >   	int ret;
> > > @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
> > >   		sprintf(revstr, "1.%d", ret);
> > >   	bq->model = kasprintf(GFP_KERNEL,
> > > -				"chip %s, revision %s, vender code %.3d",
> > > +				"chip %s, revision %s, vendor code %.3d",
> > >   				bq2415x_chip_name[chip], revstr,
> > > -				bq2415x_get_vender_code(bq));
> > > +				bq2415x_get_vendor_code(bq));
> > >   	if (!bq->model) {
> > >   		dev_err(bq->dev, "failed to allocate model name\n");
> > >   		return -ENOMEM;
> > > -- 
> > > 2.35.1
> > > 
>