Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp960576pxp; Wed, 16 Mar 2022 22:42:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0jZPOFUegVDfGtiJ3GbZzi9Zm2CP249jDavN3UxFa9tUeWa61LZ8klAARp6taKVcxfVu0 X-Received: by 2002:a17:902:9046:b0:14d:5c9d:e7df with SMTP id w6-20020a170902904600b0014d5c9de7dfmr3421408plz.65.1647495764877; Wed, 16 Mar 2022 22:42:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647495764; cv=none; d=google.com; s=arc-20160816; b=nOPaD/7XMTEViNwimheD0gJFmwLjDrzDm2O/vD7Jpfov316E5yO7r/jOHsFvks2Se4 PLnURr0/L3YeOCqr4BqZouagiLaRsKIRnEuTQ9uSK+i5fMXE7vtgWUoK4f9Aso4wf1pJ mGZGSlGKVCOBU/HFCXxWqUb8M60TaqNq/M7fob0QiWrNM2PUbIIPaCCuYNLyNSnLCAlY +MpatCaPUoS+xNRUFysfbsx1HbrXNkLm/HEaxJk1hjBEEjG/iB+oMCVnLuNvbN3/kguN BGai1X+8xXkaqyzB3oq6OKOhOkOwAYckureA86xVHP7DJtiF6cfwr1aNKHH7tG1RMq5g cSug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=+AIKKSZIjMc6QKuxTqNc6KROVjqMgKNhOn1AnwMZg6U=; b=lfpXTmSH6IyZRucH02y2ljp2UbtCfCDap/uGRKz+rbUN5GL1MynlOgTNEa5zNZzYiU ZqmJo43RC53Oe+X4h0Z8cuQUCw8l5ImWktScNAMKjZEk5xiGMPmATAvh6ytUW8m39Z5c f0Nc7cBh65tgDiYOVsirfgQ+MOxakaM0AqeQOYhxHWJLy6V3BmbK5kj2c6Ym0cR86ckA y8NhrSjtaO/nzoRMwUmgRod2L2So+JrioQFzfeWgwkP+zBQ3MMmHATIMdGOPflqAB8Z7 aNb5FwP5k09GPg1ZJKIsJasphLoo/ZZwDhTiTm6/1bjIsIg0c1CLNcKOzhdT1OQ3s2dT wV0g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d21-20020a17090abf9500b001bd14e01fcfsi6484466pjs.189.2022.03.16.22.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 22:42:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EF46A1AD1E7; Wed, 16 Mar 2022 21:52:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358257AbiCQBZq (ORCPT + 99 others); Wed, 16 Mar 2022 21:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350066AbiCQBZk (ORCPT ); Wed, 16 Mar 2022 21:25:40 -0400 Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5019E1E3CA; Wed, 16 Mar 2022 18:24:21 -0700 (PDT) X-IronPort-AV: E=Sophos;i="5.90,188,1643641200"; d="scan'208";a="114675301" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 17 Mar 2022 10:24:21 +0900 Received: from localhost.localdomain (unknown [10.226.36.204]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 58DFD41A45A3; Thu, 17 Mar 2022 10:24:18 +0900 (JST) From: Lad Prabhakar To: Thomas Gleixner , Marc Zyngier , Rob Herring , Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Philipp Zabel Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Lad Prabhakar Subject: [RFC PATCH v4 3/5] gpio: gpiolib: Allow free() callback to be overridden Date: Thu, 17 Mar 2022 01:24:02 +0000 Message-Id: <20220317012404.8069-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220317012404.8069-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20220317012404.8069-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow free() callback to be overridden from irq_domain_ops for hierarchical chips. This allows drivers to free any resources which are allocated during populate_parent_alloc_arg(). Signed-off-by: Lad Prabhakar --- drivers/gpio/gpiolib.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index defb7c464b87..aede442f610d 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1187,15 +1187,18 @@ static void gpiochip_hierarchy_setup_domain_ops(struct irq_domain_ops *ops) ops->activate = gpiochip_irq_domain_activate; ops->deactivate = gpiochip_irq_domain_deactivate; ops->alloc = gpiochip_hierarchy_irq_domain_alloc; - ops->free = irq_domain_free_irqs_common; /* - * We only allow overriding the translate() function for + * We only allow overriding the translate() and free() function for * hierarchical chips, and this should only be done if the user - * really need something other than 1:1 translation. + * really need something other than 1:1 translation for translate() + * callback and free if user wants to free up any resources which + * were allocated during callbacks for example populate_parent_alloc_arg. */ if (!ops->translate) ops->translate = gpiochip_hierarchy_irq_domain_translate; + if (!ops->free) + ops->free = irq_domain_free_irqs_common; } static int gpiochip_hierarchy_add_domain(struct gpio_chip *gc) -- 2.17.1