Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <57c2d5d64f9d65e442744fa8b7f188ed3fd37c1c.camel@redhat.com>
Subject: Re: [PATCH 3/3] KVM: x86: Trace all APICv inhibit changes and
 capture overall status
From:   Maxim Levitsky <mlevitsk@redhat.com>
To:     Chao Gao <chao.gao@intel.com>,
        Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 15 Mar 2022 16:48:12 +0200
In-Reply-To: <20220315144249.GA5496@gao-cwp>
References: <20220311043517.17027-1-seanjc@google.com>
         <20220311043517.17027-4-seanjc@google.com> <20220315144249.GA5496@gao-cwp>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-03-15 at 22:42 +0800, Chao Gao wrote:
> On Fri, Mar 11, 2022 at 04:35:17AM +0000, Sean Christopherson wrote:
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -9053,15 +9053,29 @@ bool kvm_apicv_activated(struct kvm *kvm)
> > }
> > EXPORT_SYMBOL_GPL(kvm_apicv_activated);
> > 
> > +
> 
> stray newline.
> 
> > +static void set_or_clear_apicv_inhibit(unsigned long *inhibits,
> > +				       enum kvm_apicv_inhibit reason, bool set)
> > +{
> > +	if (set)
> > +		__set_bit(reason, inhibits);
> > +	else
> > +		__clear_bit(reason, inhibits);
> > +
> > +	trace_kvm_apicv_inhibit_changed(reason, set, *inhibits);
> 
> Note that some calls may not toggle any bit. Do you want to log them?
> I am afraid that a VM with many vCPUs may get a lot of traces that actually
> doesn't change inhibits.

I also think so.

Best regards,
	Maxim Levitsky

> 
> Anyway, this series looks good to me.
>