Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 15 Mar 2022 14:55:36 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Meng Tang <tangmeng@uniontech.com>
Cc:     t.sailer@alumni.ethz.ch, davem@davemloft.net, kuba@kernel.org,
        linux-hams@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hamradio: Fix wrong assignment of 'bbc->cfg.loopback'
Message-ID: <20220315115536.GN3293@kadam>
References: <20220315074851.6456-1-tangmeng@uniontech.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220315074851.6456-1-tangmeng@uniontech.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dr7RwxnWvsG1ypZAZ5c08Qv0sICiHTw5FDgClHcVGIAzMZ3McJBprk0tbUA9?=
 =?us-ascii?Q?kq9XEXgKN3RCcylu6cbOGKq5UnFodvERP/ir230frS9wC3jva7fQQ790RT/x?=
 =?us-ascii?Q?7m11lKHqsRrFuhlpJwKEmdlNSIKDCMhdS3fravY/1HzRwM+QuN9YnShapU/Y?=
 =?us-ascii?Q?6pCGA1h2A/ZqEq2U5zLynG8T8FCYwMllGRFnkB4nrMdTjtJ5rLxDLQ++l4Ws?=
 =?us-ascii?Q?xT6cxOgAVtKQxjiDOBJ9U2JuggMls1NNmuF5mDBFo76ZC56j52h8DazAzdGT?=
 =?us-ascii?Q?O9tHRCjuyM1/1VoHFpnPS/ylj4sRskN9yGME1kkWtaVidlV+DVJuPZOhmoRR?=
 =?us-ascii?Q?IAVmGA7bfr2o+OKnB0wpl3erXlxRfCaE2Q5iQpm79QzBwmaGcUoo4wzqZzPA?=
 =?us-ascii?Q?vOFnyoUE77FdwOTyrQ0aTKKGWjOJoB1/w2AmziquvNn1qnYSMgzfPZ6eccIz?=
 =?us-ascii?Q?GjHzdf9LzzWIoOw6X+iK/tYFB88+DCb6kyABJSVQCZ3qBmt726LTiy+s9VJ2?=
 =?us-ascii?Q?SUEAALVWAa9mVTcA8xMGJBcR8/M7y8wUO6rYprWFZldQsKO9pTc2IcZwhxrA?=
 =?us-ascii?Q?lDbRSIVrwe+q84PAZ2zZtFFszqIVl8nEO2x4gI1HAqkiRwvBtGaxL9+2X/4z?=
 =?us-ascii?Q?As/7CFsw9nxU5jZ/HxgHvczXuThqort6A7ZkSSCtF5hFV7bb/PQHJnJ/xLrq?=
 =?us-ascii?Q?bcwiGFGcL9XKUcRZrtNDlHhwu1b2JLkcRLbFXncyxkTk6CwO6PWlpxQafwQd?=
 =?us-ascii?Q?cCiXOmdpJmc0XF05AT0+V+MzWZebvlpQ/LN4qJCeIla/Rc0iUHGrKVmLeB+p?=
 =?us-ascii?Q?meS4VbqibA3pRy9MJlabDYih5pv6CLiUcCZ513csA/FEtgBUYPA8cVrt+cFh?=
 =?us-ascii?Q?35frRYt7P4nA+glybR2y8DdvUQFre2XKuEa023zivLdWEfWDs1HdpaVr1ISh?=
 =?us-ascii?Q?Khby1YkPh8ZMYa7Y6hvXaSeLR3dhNonf/RMqJOzqX+w5N6znxNW7prgnknXb?=
 =?us-ascii?Q?6pBUkHKKu+35JZG1+/PNvRCExYgQEb5+KP7V5gEZGBbjtJshn2l7aqFdWmbm?=
 =?us-ascii?Q?qRqxkbb6LBiGoETBmpucCqb53vEJjOzMYpwVLxsHQ8F9Vg8NMIA9lu2fwHbY?=
 =?us-ascii?Q?O9SAjUaqPzk82kQ2j5LAlcHos9E0fYJXKDZwn7/C2syqn5HHfqLMADco5GxP?=
 =?us-ascii?Q?Hbi8B1PXHIXrA6MWs/3SkVWW39PoVOukf9rbq7J4YEHOStJKpzTSzti1SbgL?=
 =?us-ascii?Q?o+gI4ZSZMCjxCTlDkTGfPCSTX1Lhs9ERU3Dsu1XPsoWdLVDMwZbmM0KIyOTp?=
 =?us-ascii?Q?kuxeyqYFzUgfh91NqE5GDtdg1Tn3VC/S6IRwmUzx85UCTYshwKku0tc79+eC?=
 =?us-ascii?Q?DkJCXLexy6XeYUJssedFByEsRTEOagKNeBj+YqhOuPS1nap6V+J6MtV7Eir4?=
 =?us-ascii?Q?MYt49Qs62D8jkTLRC+X30p9WKmtlSxl34ihLruWFtpvJeuhXXUnmuQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97ac4284-3360-453d-c4be-08da067ac463
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 11:55:58.0745
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yGlJDsTia5BSfXWjpDQUapgJIFe5ip7D2FlMRiCYkfR3+PeWOUvhYXQU6vlmRI8+B/o7ko2IvXbtc2A/GadFhLMJwwA7WXCW5mCyWUdjglI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1714
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10286 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203150078
X-Proofpoint-GUID: U4sXCmhNIhlhlaSguec04rvEsC_jNcpR
X-Proofpoint-ORIG-GUID: U4sXCmhNIhlhlaSguec04rvEsC_jNcpR
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 15, 2022 at 03:48:51PM +0800, Meng Tang wrote:
> In file hamradio/baycom_epp.c, the baycom_setmode interface, there
> is a problem with improper use of strstr.
> 
> Suppose that when modestr="noloopback", both conditions which are
> 'strstr(modestr,"noloopback")' and 'strstr(modestr,"loopback")'
> will be true(not NULL), this lead the bc->cfg.loopback variable
> will be first assigned to 0, and then reassigned to 1.
> 
> This will cause 'bc->cfg.loopback = 0' will never take effect. That
> obviously violates the logic of the code, so adjust the order of
> their execution to solve the problem.
> 
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

This bug predates git.  :P  Did you find it by testing or reviewing the
code?

regards,
dan carpenter