Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
CC:     "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH v2 2/8] iommu: Add attach/detach_dev_pasid domain ops
Thread-Topic: [PATCH v2 2/8] iommu: Add attach/detach_dev_pasid domain ops
Thread-Index: AQHYOCoYv35DknzN5kqPD8yptRL1a6zATtaAgAAEIvA=
Date:   Tue, 15 Mar 2022 11:49:57 +0000
Message-ID: <BN9PR11MB5276D5B88C05B509C2C790A98C109@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220315050713.2000518-1-jacob.jun.pan@linux.intel.com>
 <20220315050713.2000518-3-jacob.jun.pan@linux.intel.com>
 <YjB4AyrgsnbUrlLe@myrica>
In-Reply-To: <YjB4AyrgsnbUrlLe@myrica>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K7fyT7Xxpy3js0XuNqQR7pVFdmwbAidD34bA6g0PCtluk4iZRQCBibMNCF0h?=
 =?us-ascii?Q?xxPAk+/vy9DhH6qgxreabfhX4+5kcStvTiPY0ddQKwca9N5WboVz6nisNtqN?=
 =?us-ascii?Q?p5+/3uhEz2P/dTxBUjkkjPDqkWeAwf04nM6Bvvz4wMPbcSaAMb2Dp2zl9glR?=
 =?us-ascii?Q?ocYc0a6QlWssSy0dJZLlq0XMf/aTLEDfT4cMv96ffjPR03ZGLJqa7qXzPeK+?=
 =?us-ascii?Q?iHY2CrQI1L55i7MVw68METPc1/jGu1ZD7X4uM6V4EmqKl4Fw5/WN3gkE/Up4?=
 =?us-ascii?Q?CtKD39tjaq/DMdKSwcjIEsxsgJYORlTvgyFkAUDes6kaqzKcDABzhvRbqId8?=
 =?us-ascii?Q?ZmyVrluHdZKiLcjtE0pRAnU45sf9AbrGa1/jx8TiTuDhnk8SQfRAECpjGB6P?=
 =?us-ascii?Q?eiracePQgFIl+kpKl3cwMVywqETr7Wfr99zpP+yz7AiqrOZgn7dgBH3hFN2+?=
 =?us-ascii?Q?DVjc6LY4EdpSaNAbPq/Qyz4EXzYNXfXUqgtXHLpcUaaRazY/IpEPmTYcOlch?=
 =?us-ascii?Q?ddI2zJ67hBqMbafTj3FxcUcIM5m2kHyJ+j1riUY19ZK5si3MMXh9r+fC/QrW?=
 =?us-ascii?Q?irUzyutYvkhlHdAZ+0cROaeOkLy4soLBgRhXyZ0VnIwtLI1icoa2eXXuY09x?=
 =?us-ascii?Q?CbTFQhZnwftEIxJNLN92nP8mdT3nqqHqhvn8wCY/NSWt3ZpRAUP3d/LVj9zB?=
 =?us-ascii?Q?DuZ/RNCDevuxL8bP9JBQAKTaR/9o69MDocegrIHFN9kLEaYYpQ3yy8YCFw41?=
 =?us-ascii?Q?0uZgda0vN7adbMTPdk1N2gHdIVdWRIy5APwbW/2C4DVSykk9+UD0fs7GvY1o?=
 =?us-ascii?Q?XSrqeVUHn8ah3HDkYqDnZ4RjgBqZ6epw+wHqJLNQDZDpQq3f6Hqq4DIYlIjD?=
 =?us-ascii?Q?VMalw2WyfZIl6ebf0JGMuY3z757t7omMwS2/Uj6OJoRPJ1PvIOyPFt782+u5?=
 =?us-ascii?Q?nKyYom3KELm2T6KyC2jnQ1Qb1Wi/u8wRIreWmrT6fYKx5FVmNgRqMU86RmOg?=
 =?us-ascii?Q?sfwITU+oPF12/ymFL45ZiqB3ShxpIt+iqD0bkeU6suBQf2Zsd7Myg78Q0TC2?=
 =?us-ascii?Q?o0lp1LETr81QaZe3Z10IeefJ68kIJvztna4ZGdUYkFC8k6lscDQaemmxKObh?=
 =?us-ascii?Q?jnkzDhUF/qcBlsMUQINv42grZmsObRoix0Jfde+4r8UiPiYuk2JIlFOZtrj3?=
 =?us-ascii?Q?/jvV1INN5rvqMtHXpe88EmZZ8OpBKellEdHUTrq1qvVSk1ayOCORT/3YENeE?=
 =?us-ascii?Q?CaEezXGWvXv1ZAACE96xMRJ7T6mwks3ZmHviRGpQpNNpxfDDqXIk1TpTNSk+?=
 =?us-ascii?Q?HNIuyZ9wPtR3M4IYHvT3TE8dc5bgBAzRsFhziaTMhr3avTvREwKP5IazTI1k?=
 =?us-ascii?Q?if35d3tajz1G8XTyFWWOFNO3aK0BxoRYprMka3ny9yepHqpWmwMKet6wlZwH?=
 =?us-ascii?Q?yGLqVGdd/OGdXQbsCyqtrPKDEodKHaoA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 130de06b-a1a5-4763-05f1-08da0679ed85
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 11:49:57.0667
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PBIozWutrrfJlI7DGXGV9KQK/r1CjQX3DiTVd6bUSsSxdMdNZfUVwEzraaDowin36x++Z+an+EY0pnP4vghMDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2805
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Sent: Tuesday, March 15, 2022 7:27 PM
>=20
> On Mon, Mar 14, 2022 at 10:07:06PM -0700, Jacob Pan wrote:
> > From: Lu Baolu <baolu.lu@linux.intel.com>
> >
> > An IOMMU domain represents an address space which can be attached by
> > devices that perform DMA within a domain. However, for platforms with
> > PASID capability the domain attachment needs be handled at device+PASID
> > level. There can be multiple PASIDs within a device and multiple device=
s
> > attached to a given domain.
> > This patch introduces a new IOMMU op which support device, PASID, and
> > IOMMU domain attachment. The immediate use case is for PASID capable
> > devices to perform DMA under DMA APIs.
> >
> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > ---
> >  include/linux/iommu.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> > index 369f05c2a4e2..fde5b933dbe3 100644
> > --- a/include/linux/iommu.h
> > +++ b/include/linux/iommu.h
> > @@ -227,6 +227,8 @@ struct iommu_iotlb_gather {
> >   * @aux_get_pasid: get the pasid given an aux-domain
> >   * @sva_bind: Bind process address space to device
> >   * @sva_unbind: Unbind process address space from device
> > + * @attach_dev_pasid: attach an iommu domain to a pasid of device
> > + * @detach_dev_pasid: detach an iommu domain from a pasid of device
>=20
> Isn't that operation "assign a PASID to a domain" instead?  In patch 5,
> the domain is already attached to the device, so set_domain_pasid() might
> be clearer and to the point. If the IOMMU driver did the allocation we
> could also avoid patch 1.

iiuc this API can also work for future SIOV usage where each mdev attached
to the domain has its own pasid. "assigning a PASID to a domain" sounds
like going back to the previous aux domain approach which has one PASID
per domain and that PASID is used on all devices attached to the aux domain=
...

>=20
> If I understand correctly this series is not about a generic PASID API
> that allows drivers to manage multiple DMA address spaces, because there
> still doesn't seem to be any interest in that. It's about the specific
> IDXD use-case, so let's focus on that. We can introduce a specialized cal=
l
> such as (iommu|dma)_set_device_pasid(), which will be easy to consolidate
> later into a more generic "dma_enable_pasid()" API if that ever seems
> useful.
>=20
> Thanks,
> Jean
>=20
> >   * @sva_get_pasid: Get PASID associated to a SVA handle
> >   * @page_response: handle page request response
> >   * @cache_invalidate: invalidate translation caches
> > @@ -296,6 +298,10 @@ struct iommu_ops {
> >  	struct iommu_sva *(*sva_bind)(struct device *dev, struct mm_struct
> *mm,
> >  				      void *drvdata);
> >  	void (*sva_unbind)(struct iommu_sva *handle);
> > +	int (*attach_dev_pasid)(struct iommu_domain *domain,
> > +				struct device *dev, ioasid_t id);
> > +	void (*detach_dev_pasid)(struct iommu_domain *domain,
> > +				 struct device *dev, ioasid_t id);
> >  	u32 (*sva_get_pasid)(struct iommu_sva *handle);
> >
> >  	int (*page_response)(struct device *dev,
> > --
> > 2.25.1
> >