Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 16 Mar 2022 10:59:29 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     niravkumar.l.rabara@intel.com
Cc:     dinguyen@kernel.org, mchehab@kernel.org, tony.luck@intel.com,
        james.morse@arm.com, rric@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: altera: Add SDRAM ECC check for U-Boot
Message-ID: <YjG1AbShZZrJdTbE@zn.tnic>
References: <20220305014118.4794-1-niravkumar.l.rabara@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220305014118.4794-1-niravkumar.l.rabara@intel.com>
Precedence: bulk

On Sat, Mar 05, 2022 at 09:41:18AM +0800, niravkumar.l.rabara@intel.com wrote:
> From: Rabara Niravkumar L <niravkumar.l.rabara@intel.com>
> 
> A bug in legacy U-Boot causes a crash during SDRAM boot if ECC
> is not enabled in the bitstream but enabled in the Linux config.
> 
> Memory mapped read of the ECC Enabled bit was only enabled
> if U-Boot determined ECC was enabled in the bitstream.
> 
> The Linux driver checks the ECC enable bit using a memory map
> read. In the ECC disabled bitstream case, U-Boot didn't
> enable ECC register memory map reads and since they are not
> allowed this results in a crash.
> 
> This patch always reads the ECC Enable register through a

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

I've removed it now but pls pay attention for the future.

> SMC call which is always allowed and it works with legacy
> and current U-Boot.
> 
> Signed-off-by: Rabara Niravkumar L <niravkumar.l.rabara@intel.com>
> ---
>  drivers/edac/altera_edac.c | 40 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette