Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v6 1/6] fpga: dfl: Allow ports without local bar space.
Thread-Topic: [PATCH v6 1/6] fpga: dfl: Allow ports without local bar space.
Thread-Index: AQHYOQUc6KfnoIn0pECU3HlxJyPskazC0EmA
Date:   Thu, 17 Mar 2022 02:04:41 +0000
Message-ID: <BYAPR11MB3816EAB6CC0047B2DBB5086685129@BYAPR11MB3816.namprd11.prod.outlook.com>
References: <20220316070814.1916017-1-tianfei.zhang@intel.com>
 <20220316070814.1916017-2-tianfei.zhang@intel.com>
In-Reply-To: <20220316070814.1916017-2-tianfei.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f0kwmmUyMyPth1nbVev77bMzVzzEzBNRZs9/zSwj0lyqW5SU9JusRBRONU7O?=
 =?us-ascii?Q?bhIT/vzbirOi02Jip89OgD1ZVUjqIkOTZDfegovKeZV13xmklAHDVpU8opLd?=
 =?us-ascii?Q?1DTxW2K8QK7dEMrkRJDGha75Cp/gJTaGfjK2vJf9wFwJTc29TtpcZ3kmut9A?=
 =?us-ascii?Q?dBMXVlNpjES81Ij/i/lEs4nWxChQ2IdF8rHI0j74D8AM0SdiUUhO0/kCHb2g?=
 =?us-ascii?Q?qsVD7TZ/5HeX7erNBgJWPX9mkK5tbrLAHpEgCkiZ0Oh2Sz8rmvY9nTH/aX2m?=
 =?us-ascii?Q?e1UDtIc+mVC4BjNmgyN2YzO/9A/E3PhWZPABxb+RfD+c++gQ3SGdMjzZRkL3?=
 =?us-ascii?Q?mrZ+PU8lpXgnzlwTNAM7TbZ/BmUKwDovNJ2MMDtD/+e/GuE1Ai6JnbuUmHF7?=
 =?us-ascii?Q?K36yT+xkoYu9+83xSC72dI4yMPR4hcu4AU5LrLrDk1Ac02fhLgV+7ELuU2z6?=
 =?us-ascii?Q?rrR0+FFuLQtm2X7IDxuLzTzd8s4dQ+pOYif0Bk5vb6GnbZ59SbWnGeqcFlsv?=
 =?us-ascii?Q?RUpg0Ro9eEvdBkdqPXow4prlgs3DV7jPb6bb56dJ3ggr4Qug71mnIXpHZIIM?=
 =?us-ascii?Q?hf54wMYimEeC6mhKaB1Li5MQWLL0tCIZ8DUqmIaB+nlyyz7y6dKmfp+OnB/B?=
 =?us-ascii?Q?xwBjVLLrw/M29LB4+1ZMhYsxJ+uss1x6G7f8mMvrnTz/4wLzzKdAhrE3xMMf?=
 =?us-ascii?Q?ulhaabOCOmj7uj6QKBXvwzfo8vkQ0gB0IviwE+bNryGdXNnWtgVV1PUeN1UV?=
 =?us-ascii?Q?F2Ym5oPR5r5dgk4/+0nUhoyZIlBarL8Pln/YdBKbWEhwe14uwD/GWVfkZDMe?=
 =?us-ascii?Q?992Y7GkAJ7H9nv5aAkaFB9mSrwC9hZA1Oot8E/LsYJNg4T3KdrLRKyMnbxHK?=
 =?us-ascii?Q?vkFIFcn+fSEQgIpGxNMPegYJRGy4jnTV6WhmZc1d5T5KoHaE/jkRXIDztECQ?=
 =?us-ascii?Q?dSr9WmSmfxs3O3MJxU8cqDFhFg0MaWY9KM31g7pVKIffAXa9s18OIjpzd69l?=
 =?us-ascii?Q?lKB0Acek5Q7dBGf9XcI+aFHfX1gm49xVGm2beN6AaTIOR1CarhX4e5f4ZuY5?=
 =?us-ascii?Q?2241O8400QjQ+UQA2cN6NQqAWO7NvfaM2dTbuH5YKztlYUy1yJhLu81zddIL?=
 =?us-ascii?Q?wp8474qZJz7H5FlP0JMDgqDXNXyftjKCGxNaBOSZe56dQd423VP6H7aGQsc3?=
 =?us-ascii?Q?UQrGmYMgbj69SfWRgZUZc08j/HFXvmO1DSi4jUzz1Yl/rCyYmriA7ofTjELm?=
 =?us-ascii?Q?sgmpqTpCpwsPs7iQ2FaEebgcDM8dlTz0J5xwkoeYWDJg9ewuUkLoa/GqgGqZ?=
 =?us-ascii?Q?Ze42E7Eq4KF0HaaP8JJdSaVg9NPxYTLvYivxjEcUrN8vUpfyPZ+T7j5V5Wjf?=
 =?us-ascii?Q?j2nvk296G7v+BGtixGN/TdKyAEFqxE253tI5jOaq6cQnOcvrlRWa1GB08Ewb?=
 =?us-ascii?Q?abeUX/dPU9A=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3816.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6615deb9-04b6-4d8a-7349-08da07ba7ff6
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 02:04:41.7734
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qGmjSotoMsB5RdLFDBowZf4IiLUAo3OHrMeXbj6YOAWC7HPhzXwMth3sRNilKU5lGM5EDedI/ZOi5dFZy8HNrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1968
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Zhang, Tianfei <tianfei.zhang@intel.com>
> Sent: Wednesday, March 16, 2022 3:08 PM
> To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu, Yilu=
n
> <yilun.xu@intel.com>; linux-fpga@vger.kernel.org; linux-doc@vger.kernel.o=
rg;
> linux-kernel@vger.kernel.org; rdunlap@infradead.org
> Cc: corbet@lwn.net; Matthew Gerlach <matthew.gerlach@linux.intel.com>;
> Zhang, Tianfei <tianfei.zhang@intel.com>
> Subject: [PATCH v6 1/6] fpga: dfl: Allow ports without local bar space.
>=20
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>=20
> In OFS, each PR slot (AFU) has one port device which include Port
> control, Port user clock control and Port errors. In legacy model,
> the AFU MMIO space was connected with Port device, so from port
> device point of view, there is a bar space associated with this
> port device. But in "Multiple VFs per PR slot" model, the AFU MMIO
> space was not connected with Port device. The BarID (3bits field) in
> PORTn_OFFSET register indicates which PCI bar space associated with
> this port device, the value 0b111 (FME_HDR_NO_PORT_BAR) means that
> no PCI bar for this port device.

The commit message is not matching the change, it's not related to AFU...

Current usage (FME DFL and PORT DFL are not linked together)

FME DFL=20
PORT DFL (located by FME's PORTn_OFFSET register, BAR + offset)

Your proposed new usage is (FME DFL and PORT DFL are linked together)

FME DFL -> PORT DFL
So FME's PORTn_OFFSET can be marked, then driver could skip it.

Is my understanding correct? If yes, please update your title and commit
message, and add some comments in code as well.

Again, the change you did in dfl core code, is not only impacting your
OFS device, but also future DFL devices, it's an extension to DFL.

Thanks
Hao

>=20
> ---
> v3: add PCI bar number checking with PCI_STD_NUM_BARS.
> v2: use FME_HDR_NO_PORT_BAR instead of PCI_STD_NUM_BARS.
>=20
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
>  drivers/fpga/dfl-pci.c | 7 +++++++
>  drivers/fpga/dfl.h     | 1 +
>  2 files changed, 8 insertions(+)
>=20
> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> index 4d68719e608f..2e9abeca3625 100644
> --- a/drivers/fpga/dfl-pci.c
> +++ b/drivers/fpga/dfl-pci.c
> @@ -258,6 +258,13 @@ static int find_dfls_by_default(struct pci_dev *pcid=
ev,
>  			 */
>  			bar =3D FIELD_GET(FME_PORT_OFST_BAR_ID, v);
>  			offset =3D FIELD_GET(FME_PORT_OFST_DFH_OFST, v);
> +			if (bar >=3D PCI_STD_NUM_BARS ||
> +			    bar =3D=3D FME_HDR_NO_PORT_BAR) {
> +				dev_dbg(&pcidev->dev, "skipping port without
> local BAR space %d\n",
> +					bar);
> +				continue;
> +			}
> +
>  			start =3D pci_resource_start(pcidev, bar) + offset;
>  			len =3D pci_resource_len(pcidev, bar) - offset;
>=20
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 53572c7aced0..1fd493e82dd8 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -91,6 +91,7 @@
>  #define FME_HDR_PORT_OFST(n)	(0x38 + ((n) * 0x8))
>  #define FME_HDR_BITSTREAM_ID	0x60
>  #define FME_HDR_BITSTREAM_MD	0x68
> +#define FME_HDR_NO_PORT_BAR	7
>=20
>  /* FME Fab Capability Register Bitfield */
>  #define FME_CAP_FABRIC_VERID	GENMASK_ULL(7, 0)	/* Fabric
> version ID */
> --
> 2.26.2