Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 16 Mar 2022 17:23:31 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Noah Goldstein <goldstein.w.n@gmail.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
        hpa@zytor.com, luto@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] arch/x86: Improve 'rep movs{b|q}' usage in
 memmove_64.S
Message-ID: <YjIPA1IagZDdi7iw@zn.tnic>
References: <20211101044955.2295495-1-goldstein.w.n@gmail.com>
 <20211117210245.843374-1-goldstein.w.n@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211117210245.843374-1-goldstein.w.n@gmail.com>
Precedence: bulk

On Wed, Nov 17, 2021 at 03:02:45PM -0600, Noah Goldstein wrote:
> Add check for "short distance movsb" for forwards FSRM usage and
> entirely remove backwards 'rep movsq'. Both of these usages hit "slow
> modes" that are an order of magnitude slower than usual.
> 
> 'rep movsb' has some noticeable VERY slow modes that the current
> implementation is either 1) not checking for or 2) intentionally
> using.
> 
> All times are in cycles and measuring the throughput of copying 1024
> bytes.

All these claims need to be proven by

 - real benchmarks - not a microbenchmark - where it shows that
 modifications like that are not "in the noise". Others should be able
 to verify those results too.

 - on a bunch of CPUs from different vendors to verify that they don't
   cause performance regressions on any.

HTH.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette