Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Daniel Suchy <danny@danysek.cz>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "rafael.richter@gin.de" <rafael.richter@gin.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: patch problem - mv88e6xxx: flush switchdev FDB workqueue
Thread-Topic: patch problem - mv88e6xxx: flush switchdev FDB workqueue
Thread-Index: AQHYNuMUe6nsPJS+gkWlndMnOWNLUqy9WmoA
Date:   Sun, 13 Mar 2022 14:10:31 +0000
Message-ID: <20220313141030.ztwhuhfwxjfzi5nb@skbuf>
References: <ccf51795-5821-203d-348e-295aabbdc735@danysek.cz>
In-Reply-To: <ccf51795-5821-203d-348e-295aabbdc735@danysek.cz>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n//vC5XKCVceMePwBtId0mEa+fq8iAKpIO6P5hxAAC1dv8bfBZaJfN/XYfHW?=
 =?us-ascii?Q?Ey3wxY7d+qexnZCyz/Zap8imfqGPMYL4cJjSXkXaMyQlBjCM5qU0bQW7Lt2A?=
 =?us-ascii?Q?ORa+fyMPkVb+oO2jlt9gqEJcv5dRuDqcqU3mVBBzp7eg/trNgAY42mHIpNh1?=
 =?us-ascii?Q?QPacJtVJYJFmBnwFLCvPxpLzfsWXeg7BfQuZEBCcMiKQDjhHaXcGP+eGzK1a?=
 =?us-ascii?Q?q1MxcUZYqJ2rGfJPVzCco3EcRpykXoMk+4YygKNYaT9vWGVuND3QdU3c8hO/?=
 =?us-ascii?Q?ZoA786gsdKEpYTu8V82bg/b0FY75vlOH0uCP6lXoqVsPdrmmwDbGBzitVkjJ?=
 =?us-ascii?Q?vS4dzLZN/MDz8Are0hQOYTAWUGI97aeNi8g4aEPDowiRt/d9iJJo7FZb0xnf?=
 =?us-ascii?Q?y0GZ2Cvw2C1wtklKcdnFawCgxoYlPGH1QEgCmK7aBYF2iGamYdnEc9VSYXsy?=
 =?us-ascii?Q?T5XtkwRB5Arr/7aqo7jMiykLMvYfFIK5DRxkK7bzSK9i2HW20dg2T7tAzm9I?=
 =?us-ascii?Q?b4sqx/eCgvI8mv0wmwQfpS/xwSbQUbRQCKTGeR21xDzqdKBLlCS63xv3QYaH?=
 =?us-ascii?Q?Vn8PeoJTQOZ99Dc/RIydDip/RKLftkqK0UBNlOBomW8tnOd+ZXj7OSqXjbog?=
 =?us-ascii?Q?3bCLuGg7D1MQlt/rZGG5eDsjYmEJlgfqUZr+O8Kp7isxMBnW9LzWfZg9pJXk?=
 =?us-ascii?Q?3waiFO+pUSlZFivrbS8y0fuiFmNMaUeJatqBHK+Ho59Oqb5XuFpmisZTrV2f?=
 =?us-ascii?Q?KSCtZbGnu7WstWi9G2CVgnG1vad4P0VJNxsYRIGS5S32bwbolEtJtwvndzr7?=
 =?us-ascii?Q?wVhm6yv8FFbonJXO5BJWNRz6ncfXnHG4AD+UkwmmPIo5C/gS3ffbFCnRV+iA?=
 =?us-ascii?Q?8Owtmy+xx73EgaXZCuYGayimmD0ZOz7yXdM52ueWE6sQSu1rbJjYZ58Bo4k3?=
 =?us-ascii?Q?P9ABg3XXLN38VKIS+UvhwJ6YlfhA0N+OXDpqbVTImaykDUJlzJBVv//ummP/?=
 =?us-ascii?Q?AYZydCCBCwWJ5oTkzuMTmk+4IyKeaxwKmsUJUjeZblBkVWDaiLJRM9vKxcpu?=
 =?us-ascii?Q?NT87p92gfqHHuL/35b8cnMJWOWnsRM0FKU5iQVGXqu5qqkW6giVRbogy04BZ?=
 =?us-ascii?Q?CbL4NO7QVNnawk0VcDGG+HBZLgOP23dEvEbyFH9o30okPmZ7Hj2auz45+ZPz?=
 =?us-ascii?Q?IMgNQCUT9XvjP7zuAZF934dqWUVqNcj51QiFdAPFtwIP8s3USBaGesjJQXp/?=
 =?us-ascii?Q?1+mhMfBkTVs5/at7xa8BmTDbTQvYmadZ3w+seWeglWvs9slyVHiwuJevO7CE?=
 =?us-ascii?Q?9FhIsxYknWjxbFa94KStOvRvG3HW0gPi3wTpCu6+4d+wo0CWWl9MI4Ln87wx?=
 =?us-ascii?Q?HhmvijaA/7K3jp02ipNUn7CBpd4Y1kQplFcX7TQGIHs33RtZPIbEd3D/WsXl?=
 =?us-ascii?Q?yr2d7JEx8eJY61fX5Vl2Qe/nGHdkeCNTKUFfvC1UQy4v43g+ZenBPg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B8543E06734BEB49ACD8CE8595C9207E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c97111d-fbc1-4646-b4d4-08da04fb3beb
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2022 14:10:31.2764
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: upUdbolUT3VdDxODG/NfkvStyeX2OfYIK2rvd8pfgezU+Fmz5+MlPVhW1dNyY02hK4Kz+H45OCwMsOZLGCbK7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3648
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Daniel,

On Sun, Mar 13, 2022 at 03:03:07PM +0100, Daniel Suchy wrote:
> Hello,
>=20
> I noticed boot problems on my Turris Omnia (with Marvell 88E6176 switch
> chip) after "net: dsa: mv88e6xxx: flush switchdev FDB workqueue before
> removing VLAN" commit https://git.kernel.org/pub/scm/linux/kernel/git/sta=
ble/linux.git/commit/?id=3D2566a89b9e163b2fcd104d6005e0149f197b8a48
>=20
> Within logs I catched hung kernel tasks (see below), at least first is
> related to DSA subsystem.
>=20
> When I revert this patch, everything works as expected and without any
> issues.
>=20
> In my setup, I have few vlans on affected switch (i'm using ifupdown2 v3.=
0
> with iproute2 5.16 for configuration).
>=20
> It seems your this patch introduces some new problem (at least for 5.15
> kernels). I suggest revert this patch.
>=20
> - Daniel

Oh wow, I'm terribly sorry. Yes, this patch shouldn't have been
backported to kernel 5.15 and below, but I guess I missed the
backport notification email and forgot to tell Greg about this.
Patch "net: dsa: mv88e6xxx: flush switchdev FDB workqueue before
removing VLAN" needs to be immediately reverted from these trees.

Greg, to avoid this from happening in the future, would something like
this work? Is this parsed in some way?

Depends-on: 0faf890fc519 ("net: dsa: drop rtnl_lock from dsa_slave_switchde=
v_event_work") # which first appeared in v5.16=