Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <f1f242ca-4701-9352-7a88-38c546f3cabe@amd.com>
Date:   Wed, 16 Mar 2022 08:49:33 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 0/3] Move FPU related code from DCN3.1x drivers to DML
 folder
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, airlied@linux.ie,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        daniel@ffwll.ch, harry.wentland@amd.com, Rodrigo.Siqueira@amd.com,
        sunpeng.li@amd.com, Xinhui.Pan@amd.com
Cc:     Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        linux-kernel@vger.kernel.org, Jasdeep Dhillon <jdhillon@amd.com>
References: <20220307154801.2196284-1-mwen@igalia.com>
From:   Rodrigo Siqueira Jordao <rjordrigo@amd.com>
In-Reply-To: <20220307154801.2196284-1-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXZ6c3d4dHdIbkc0Vyttb1dyTDgra3owQWRqNDFnRzJUT0lTbm5VSndCa0Nw?=
 =?utf-8?B?bU0xblRwVldscmt1NjIwSmlhSkM0b3A2eW9zaXFFd01zaHdJVyt1Vldob29G?=
 =?utf-8?B?VXltd2VZeVliSHM4TlVseGhXMnR4ZHV0KzN3V0pPS1VrNmM2bVpOdHUvdTFp?=
 =?utf-8?B?TWJ1enNCUzFHN2VnRVBHU1dIVFpDak5DWUcrcGR2UmQySTFlMDNFZjR2ckxQ?=
 =?utf-8?B?NE1DRzkvcWtSMUh5R1hCa1FQK1JWUEVyQnBiWTF2ZTZwSDVkalR0TitKMUJR?=
 =?utf-8?B?b3k0SEhtK1dmTTVxR1Q5QVVrRGVhY0JML2RHUFFzVncveWZKSHQ5VVI2TmNs?=
 =?utf-8?B?MUt6VWNNc2p2cnJaaEVzanlmVURqd2VKendyV3Vab2R2VW5GQ1lTcTQvcVRz?=
 =?utf-8?B?bnlLUkx0cERiUXlZVnczOVd4c3c0YXBLMENWMlNvWm1CSnVxQnFUeWJkZzJa?=
 =?utf-8?B?bCtCMlgyT2hvVGJDU2xKbmlXcS9kZ2prK1JrK0d2TzVaL3RhdjJxcFN1N2x6?=
 =?utf-8?B?ZVNGS3NvYlNTQmQ3Nys1cG84UE5ESVVBN3FxM2ZTV09HZGY4NUVNd3pHUFZ4?=
 =?utf-8?B?RW5HbmdaUlh6WGQ2UEM3TlhNTFhwU2tnZExIR3JEQlY4aFF2Tm1pRms2SjAw?=
 =?utf-8?B?UjMrUGpTN0dIT2Y5M203aFozejRQeXk5SjhJR1RtTGpiYThQYWQ5N3RRWXNq?=
 =?utf-8?B?VVQ1RWJHMzdVNk0rWFZBM28vTitJNDNFNnZCZXpJQU5LeEI2WlROa1hMbzR2?=
 =?utf-8?B?NlRvK04xT21PNmZMUVZVWERBR0RYS3EyYXZKckROWXJqdVZrWk9zeGhITHpx?=
 =?utf-8?B?eXlBVDBXVlFUbFh2dUo5WUV5YjJ6MHpQOUpYM2pjdjFreGEzYVFEZTEzOGJy?=
 =?utf-8?B?SHJ5VktIRFQzRmptakJsWTJ3c3dpOFk1eHpnVEYyejNvOGdtYWtYazhZbHRz?=
 =?utf-8?B?SExWT2VMakdjQW5DYkI3TWtyV3RybjZMcGZ5TElnaWx6ZWtCalNxM081NGdD?=
 =?utf-8?B?M2Y3UUl3eFZVWExzSUlDcmEycE9kRndwaXU2UjZtTzJMUURXK1FaZG9kK1Qw?=
 =?utf-8?B?STVNaW9lL2RIRjRtNTkxV1I4QUJsQVJqMHRRcVNKTVR5eERnd2ZuT0FBbjVJ?=
 =?utf-8?B?Zk01cHYxUFhXMzFENlhKNUpZc2ZyZjRqNXk2MWhkU1JqdEtybU1SLzJ0dGJU?=
 =?utf-8?B?QzlrNWpyL29JK0VsUnZSeldBVlRPOFZ5WGhTc3IxMTJOcG4wQ3ZVd2c2dWt0?=
 =?utf-8?B?TVFwV3BNV3BLWXAxbUZtZmd0UXFhUFVSdk1XTmRZeWRzRER4YWNDSDRtSlBP?=
 =?utf-8?B?TXpRZkF0cmJmTFJLeU1pakp0Rk1ONlJWR1pUUTVEU25qVVFIM0xNSDhjUzFF?=
 =?utf-8?B?RGlsV0M5U2pKV0J0RXRyeFlFUUFpLzdEZ0UvMFIzam5UZlU1alV2elMxaVJp?=
 =?utf-8?B?U1IzZDFVcVJtSFUra0o1Vm15Q255ckVwR29wSW1oNWRlZ3ptTDJ5S01BQ3Vv?=
 =?utf-8?B?aEZVbDRPOUE4cXZQaTNGK3U1TjJLTmgxUlM5Sm14ck9tcjJ3aVpOWlhiM1Vj?=
 =?utf-8?B?cU05bEVvMnRQWWlIaElHallVbFYxeEVKTEUzbVNtVFFuQ0tJbm5HNy9RelNu?=
 =?utf-8?B?MzRHMlhaNHZMbkdMYXNadDZBKytSVFpnWFVzbDJiellWQkVOYWxpaTN1S0sx?=
 =?utf-8?B?NVM2VVZvOXVmNnJZZXp0UTVyMkpxdFczUFlNMDZFZGxQMU1CakxxZDVMdnZI?=
 =?utf-8?B?R0E3TG9jM1R5MWNKaGpoK0JYa1hVSHh0OUQ0UDE1UklCZUNab29kOVp5ald3?=
 =?utf-8?B?NjlDb01HaUlUdzJvZFdSVXhpWFY4VUQ2d3BGN3pnL3doSzNiQThlMDdpYStE?=
 =?utf-8?B?V2JhKzdPMXVvNWNnODh6dVU4MXhyaC83NmoxT3BXUWJXTm5LRE45L2JFVDA2?=
 =?utf-8?B?SlhUUU1FdldHSWhzaFhiMzhBaHR3K1NZcG1xVnZ3Zk9SNXl2UlZ2NVh5Z0ZZ?=
 =?utf-8?B?ZWhRSnhlUmtIQXF2REVVcisyZ3JMQldFUmQvTk44b2JCSElCQkFyMGJGbnpS?=
 =?utf-8?Q?hBVQ+j?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6355b934-0890-4e44-38e6-08da074b6ce5
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2896.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 12:49:36.0843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WCJyy8DFrkk217OifM2T6JreHmMa2HqeSf2LKiXEkOOO9b7z6N/ewJfbhjvLb8EDEp2PRRItStPXGk8KvQ2koQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5944
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-03-07 10:47, Melissa Wen wrote:
> This series moves FPU code from DCN 3.1x drivers to dml/dcn31 folder to
> isolate FPU operations. For this, it creates dcn31_fpu files to centralize
> FPU operations and structs from dcn31x drivers, that include:
> - _vcs_dpi_ip_params_st and _vcs_dpi_soc_bounding_box_st structs
> - dcn31x_update_bw_bounding_box() functions
> - dcn31_calculate_wm_and_dlg_fp()
> 
> Also, it adds dc_assert_fp_enabled() in public dml-fpu functions, as required,
> and I've checked if their calls are properly wrapped by DC_FP_START/END (and
> removed when inside dml/fpu files too).
> 
> Melissa Wen (3):
>    drm/amd/dicplay: move FPU related code from dcn31 to dml/dcn31 folder
>    drm/amd/display: move FPU related code from dcn315 to dml/dcn31 folder
>    drm/amd/display: move FPU related code from dcn316 to dml/dcn31 folder
> 
>   drivers/gpu/drm/amd/display/dc/dcn31/Makefile |  26 -
>   .../drm/amd/display/dc/dcn31/dcn31_resource.c | 355 +------
>   .../drm/amd/display/dc/dcn31/dcn31_resource.h |   4 +-
>   .../gpu/drm/amd/display/dc/dcn315/Makefile    |  26 -
>   .../amd/display/dc/dcn315/dcn315_resource.c   | 232 +----
>   .../amd/display/dc/dcn315/dcn315_resource.h   |   3 +
>   .../gpu/drm/amd/display/dc/dcn316/Makefile    |  26 -
>   .../amd/display/dc/dcn316/dcn316_resource.c   | 231 +----
>   .../amd/display/dc/dcn316/dcn316_resource.h   |   3 +
>   drivers/gpu/drm/amd/display/dc/dml/Makefile   |   2 +
>   .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.c  | 863 ++++++++++++++++++
>   .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.h  |  44 +
>   12 files changed, 921 insertions(+), 894 deletions(-)
>   create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c
>   create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.h
> 

Hi Melissa,

Thanks a lot for your patchset. We have already tested it with IGT, and 
we are running some manual tests to ensure that everything is fine. We 
will include your patch in this week's DC upstream, and if everything is 
alright, we will merge it next Monday.