Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp973246pxp; Wed, 16 Mar 2022 23:07:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8bZi3yS17izGYXK3GG0GZBDfZ74iJAWpxS/Yt09nW3YWyqTY99kJllyVJNw1AD7EUen/R X-Received: by 2002:a63:d342:0:b0:381:fd6f:4792 with SMTP id u2-20020a63d342000000b00381fd6f4792mr2414084pgi.101.1647497232276; Wed, 16 Mar 2022 23:07:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647497232; cv=none; d=google.com; s=arc-20160816; b=QlbuSIXvc7KO0CKZHKt5RDcUO8imtkVGhZmtflCq/1FBmKsykb9BitM+qX8qrSh0+i DbhsEe21rZ7zBIH48EQfKJI7R7R2Q3D51MX3k1HVYopKRm3au6TNQlnJR26KSM7yjvLW 42Y28+4cr9TfYIC6TfM1YxZ/d+8eH3Guo4he+H4LKaKtgTcr8u9IaMtgyP602hn9rNhU ytekNo97jiIcEX6OcasPVj07PkyXbhq21n+7LCLpvdfCtljhruggro+/m9q28ppCVuID TXYmjJ2q068mVtk3U5rKOZAFMn4szEq8yq2AvHBzH9W7uLJ2nUX2tgu8kZnD+i7D/SR2 v76g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=HoZ1zKt0q25Q5dal4n689oI7sVmSymRUjK0r4Cr8DIk=; b=agc+1HMYXTSCivXuovAoQ6k9KhtmxXOoiBYI3FMrsqvHztKSzvW60evEL+QNVsQEfp pMyBrfcLsHASmt5EwmF+FxlkCMvbv8DHrsUWPQBlIDOHA3FBXNcOO5qBuqUPgL7IZD/Y r0otPszbzE7PR0V5mNalPcg4WKGoe58vl5Sg/ETSYJuAPYQ+TMu/7+aMcg7jPd40R0Yz H0APztp+Ym6gakf3XAumE/DFgrFEM9SK9lMmr+JZ/shtCf7JYa3MPfaaGFmyc8If4LpS Ob2IqhAAipORbQBthicFEWifB1s1/KI/BOY2q0U6txS2Rm6podgL6ViNRIc/KGx5tHVf 9w0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a4ezsPpo; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u16-20020a170903125000b00153c5be01f6si3285492plh.296.2022.03.16.23.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:07:12 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a4ezsPpo; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A2F5929341C; Wed, 16 Mar 2022 22:14:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344284AbiCOBZg (ORCPT + 99 others); Mon, 14 Mar 2022 21:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344280AbiCOBZf (ORCPT ); Mon, 14 Mar 2022 21:25:35 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7177047541 for ; Mon, 14 Mar 2022 18:24:24 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id m67so997950ybm.4 for ; Mon, 14 Mar 2022 18:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HoZ1zKt0q25Q5dal4n689oI7sVmSymRUjK0r4Cr8DIk=; b=a4ezsPpowFS0VU5lUTu7aXKdVc9Jm9lgYKeL1/AXXvepgqPlFMhnlowVa6M2mIsYXu kOtK00n3qmtrC/0oLUY0idkar/9DvyKvtRcosRldvGlBJzNk+Jrq5idPcxSr8sI8ohEt 8V/z4JleVtXOxGkUesXsBCmMJ0wW2YIFEsBGvXfD0iM8D/S6fBD+qVqwPSmzuPPN0Tfv DMiiDy7ObQpNRpZLaGPWn8vvS0nX71mpVzPPUaMM8uab2f6vNZOHmZPxa4JK1fyHMKBj B23K8GCbGl/BvU+3MEVE9RTPU+HC7DSpjD4O8WPM+R50NGkAPjkmHHyiaIxUV0MIvuu4 k1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HoZ1zKt0q25Q5dal4n689oI7sVmSymRUjK0r4Cr8DIk=; b=1I5LT5hgj4ASOF2Pi2vDSz8BrRhbEVXMTvQIaLOJwDHjSsx2RF6jCnceJpPjvAWAmZ PTX1Cscb3QaJloWrexm05FluMKD6O6ErS1mlvK3g6QYZtXE8RUvSboIh3wMGePrBg0gp 4xCArebSwB0RA4TmaAQzTK0uX7x/VdwvJHeWp4TH5BLL7A9qp+060gDOtHn1SujHGY1n UbGvFm7S6eW2JcR6y/O+Zq/egkiLMGRJX6r9z36fL+wrDURAuVOgclnjVZhsYDOFTySw C16Y17QFHoCMSEPtfTvUd4kzr4wosDuzYHaLjduARAgZnxlM3Eac+Ur/hmNNtlAiXdbw G+fA== X-Gm-Message-State: AOAM530Oco05L/16kEUdYcV86Lz2cJ6UD7PabfOF9QT0+gFLSkGw3RdP yHrEk34L26NnQxNtcFnyJwqctAhd0yc4fZBiCwzb6Q== X-Received: by 2002:a25:4e82:0:b0:633:68d7:b864 with SMTP id c124-20020a254e82000000b0063368d7b864mr3400295ybb.514.1647307463666; Mon, 14 Mar 2022 18:24:23 -0700 (PDT) MIME-Version: 1.0 References: <20220307120234.28657-1-linmq006@gmail.com> In-Reply-To: <20220307120234.28657-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 15 Mar 2022 02:24:12 +0100 Message-ID: Subject: Re: [PATCH] pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe To: Miaoqian Lin Cc: Heiko Stuebner , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,SUSPICIOUS_RECIPS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 7, 2022 at 1:02 PM Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: 1e747e59cc4d ("pinctrl: rockchip: base regmap supplied by a syscon") > Fixes: 14dee8677e19 ("pinctrl: rockchip: let pmu registers be supplied by a syscon") > Signed-off-by: Miaoqian Lin Patch applied. Yours, Linus Walleij