Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 15 Mar 2022 09:23:01 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ondrej Zary <linux@zary.sk>
Cc:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, linux-block@vger.kernel.org,
        linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0] pata_parport: add driver (PARIDE replacement)
Message-ID: <20220315082301.GA3502@lst.de>
References: <20220310212812.13944-1-linux@zary.sk> <202203111955.15743.linux@zary.sk> <c0a6065c-3e89-a4be-e257-ce25711e4368@opensource.wdc.com> <202203121221.56068.linux@zary.sk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202203121221.56068.linux@zary.sk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Sat, Mar 12, 2022 at 12:21:55PM +0100, Ondrej Zary wrote:
> > Here, I am assuming that block/paride is the core code used by both
> > PARIDE and PATA_PARPORT. Not sure what PARPORT_PC does nor what its
> > dependency on block/paride code is.
> 
> There's no common core in block/paride. The block/paride/Makefile says:
> obj-$(CONFIG_PARIDE)            += paride.o
> obj-$(CONFIG_PARIDE_ATEN)       += aten.o
> obj-$(CONFIG_PARIDE_...other protocol drivers
> 
> So if PARIDE and all protocol drivers are disabled, nothing is compiled there.

Yeah.  The pattern of unconditionally descending into a subdirectory
isn't entirely uncommon.  I think this is perfectly fine here.