Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp975876pxp; Wed, 16 Mar 2022 23:11:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAkqKzG2FzAArlDm6uYLr3Z66moLViWnaAMVAbCprL6G34nnWvLB5huJAonwR2YHI7xPtu X-Received: by 2002:a17:90b:68c:b0:1c6:308d:81b3 with SMTP id m12-20020a17090b068c00b001c6308d81b3mr3559529pjz.65.1647497507311; Wed, 16 Mar 2022 23:11:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647497507; cv=none; d=google.com; s=arc-20160816; b=OuqxQ66boYirCPkCH5sEAqoGEpHB0HAyHFnditFKpeAPnfgXyXym04YYWsw0xn8cCm +7Pp3I4mnYo7tX9CAHlqxMBtYkAuApPvIiP1+cV0J+/EVdIVynsIsrDNVvdyKtKWQwHj leQVU/yPV8Tm4d3go+qAZOg90ybZ+w1wb8ihhRF6snNfhcwdrADtvnQV+hVS2TeZIGCr Dkt8205dRHNXs8rbPZ1DBzAFRR3T3tEnw2aFRNZ3vb2wt1WJ/B76+zwlvB3Ux7QxWo6D HYagZ21JFPfO4xB+ZMU/KRsQM6vbLJn3Ek2B7LQwT3cDlCe08lhwS+gwuY24UmfPH3bV vRhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gFjMUBwLXOXCYSH/yQEoWs86tnO+QQ4ub8wHv8Xojxo=; b=DumrkJ9PtKzS/dSLL+g556t73ZsxS7vHYC89+AcmBJ8gBI7ZTtXxKhJy4s6xJPX/lt Byz7PxxfN8FrpNhjQT/wcKjPUtQSaaUqrk9UN6ZdffOVBzkfJlajOIOlqCoNH0PoF/uk J6UcuJhJbB2PZfaNflltbFURlHuO+EYSs9ctMSlqzbY/0ncUfb5oSVwlYmUyMTTTp4Xs gJKLaGVCSdq5bEL7uwyskpXEBnyDHNCWN/+TXQz/vdLEIuaai4AFpXRO37mOB9paw++Z fZ+nXbl1oulPk/VIS5340VlGWyG2sWzIBwINf/CR1Jk9Ks/SCXIgO/mbxjPWwBDRHJoZ oDMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JgV1V9m1; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id x6-20020a17090aca0600b001bed521b961si1513308pjt.10.2022.03.16.23.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:11:47 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JgV1V9m1; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E0DFA1D7604; Wed, 16 Mar 2022 21:55:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353846AbiCPGaf (ORCPT + 99 others); Wed, 16 Mar 2022 02:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240322AbiCPGac (ORCPT ); Wed, 16 Mar 2022 02:30:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5981C593AF for ; Tue, 15 Mar 2022 23:29:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E1DD560C04 for ; Wed, 16 Mar 2022 06:29:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A35EC340E9; Wed, 16 Mar 2022 06:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647412158; bh=WPffMnbLy+mRaNgF3nbJhYoZuUmvH1mApTBnDeQ8aOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JgV1V9m1SWB0EHNeCEnd1BWo/M9Mk40nwknqztRUGBEgwz9/uKw1N5UP0qvQCVgnW 95IFKR86aNtYBUEpW5Hw+5RwBgBce5dW6R/Phm4oBfMPobJe3Zs48EhlNLY/kw7O4p 8eEepi/OJCvW/37LreNDnvNMzfAMdumJeoYXmJ+U= Date: Wed, 16 Mar 2022 07:29:08 +0100 From: Greg KH To: Charlie Sands Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2022 at 05:15:07PM -0400, Charlie Sands wrote: > > Always test-build your patches. Applying this change results in a build > > failure :( > My apologies, I ran a build test on a copy of the repository with my changes > stashed in order to look at the original checkpatch warnings. > > > Please fix up and resend. > It should now fix the below issues without build warnings. None of this should be in the changelog, please fix this up and send a version 2 of this patch, properly listing what changed from the previous version. Instructions on how to do that should be in the documentation. thanks, greg k-h