Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp977996pxp; Wed, 16 Mar 2022 23:15:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtLJeMsksMMyzvCBiXrueWBclkz4Izcu76b/HkAh+r2wjtd6FhxbQ7T7z/yVpGGSs8BMyz X-Received: by 2002:a63:cf09:0:b0:372:d564:8024 with SMTP id j9-20020a63cf09000000b00372d5648024mr2480860pgg.251.1647497741735; Wed, 16 Mar 2022 23:15:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647497741; cv=none; d=google.com; s=arc-20160816; b=tW9bwuATJYQu1gRV8l9UMPBmOJvicGSLuLFEQcdEK26YowiB9euYVPxFNAvFWZGG4q Rsq1YIzjRB9z+/sfJ2XZm5L/WIoxHsHA8Yx2FlhCwi8J9oYSipAbCz4lkCuqafIKb20E vUmarK4nt4wwg17oDJsugF3/GU7uU9u21dc7YREr9C3gbkSUjNLSA1Pd1uDVIzz9Bw4p mP+LG2417oK8gwxSbtTft5jxMiuWa2lEUqyBgQfaNqColiKyHwusccBq85yRKyVsiYFX aQ/nEUH5Cif+9EXOkkoz11xliVMLTdZqvePLSXREZ+iNKfEYs+0+zUolN8FWYwYBaH+y 2F5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=bg/byEWlTWIwifYckEgQwSgSeHn+FEnQHWnGn7POTSs=; b=Z1oxQbb0p9fE+enEtZtvxEMtko4CbDOpslW+DA2vm6IMw9X+8oFpEf0s/VmOmRSA4H vEhjhyeqdMZS5wKZChLqTcsbVhdIP7FaVxB2rt7kzzr+cLck98vuoQkDvximVP9v1wB5 S10B6n15O8NHCXIUCUuk+BKMkqD+aO1iK5IxKEMF8obrvIp+ZIfzngfaimQxast4v929 Ybje3+IdCOVTX5hmKxXtRS3e7bnqeJG7LpD8VV8WToUTcwAKMCTdHUU2hlEWjvIZwYhj cuPKnCrtAy/gg1uvj+HSiiPctht9/12cTpltR/l817LPKYlotQo5NJZybcNP13KLdMtx Tfpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=KfoJ64Qq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id f24-20020a633818000000b003816043efd1si1201572pga.454.2022.03.16.23.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:15:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=KfoJ64Qq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0DEE4ECB05; Wed, 16 Mar 2022 21:59:08 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350769AbiCPIv4 (ORCPT + 99 others); Wed, 16 Mar 2022 04:51:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235424AbiCPIvz (ORCPT ); Wed, 16 Mar 2022 04:51:55 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF9064BD2 for ; Wed, 16 Mar 2022 01:50:41 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id u3so3155613ybh.5 for ; Wed, 16 Mar 2022 01:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bg/byEWlTWIwifYckEgQwSgSeHn+FEnQHWnGn7POTSs=; b=KfoJ64Qqg382BsKMbnA/sTahOKPrspF5pI84AyTYRRs+Defudw6y1KfA+aloBCFx3Q aLYxCaA64PlAMKcVvhL0vAi38YRho9oahm15F31M51Kbug6TRYtp/mTueY8xertFLrHY IzRWzhVbvhosIv0oaayfcrbYhzmo0VCvURHtNXvdbzWyEuKre4yCsF4FxKe2hFNwDr88 bMADaAjIKaQ6Ge4zfHuNf4KdgDeSRD5+2P644B+W95jWl5R3OPGkGXqAkfs4KS1KOlX9 eOE80pZBJpa82+6AG1pJoFktg4wZiEzyxZ1b4D528N3ZaXEc2lU3ZQqj8hVyRgmQVoRj JqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bg/byEWlTWIwifYckEgQwSgSeHn+FEnQHWnGn7POTSs=; b=7Up7j+ez3lTWLGhPgtQkopte3VTbhNT68iB+7/2hs9carDlK29r3rB8+0tq7TR6vba 9aYtywhoQxkKF3aN98jEROiJzxHQe4+ALB/sAjYSQd3i4o31Stq6T6TKxRfgdKRV+qnX UzvnAkZvTP/37htVLod0zNfIR3Lh9/jUbVOwNmKcSllyGe38HL/1LeiRpeDDSfPSNkls 6aLGdmlT4DYZtXTs8W0AfKiumYlype2NSxFj8U6dkiwINRNuC6UF33dH7dmwU2qXXlv5 2o5CAOQNCMKUE6yqh54KHQmACgHebxDV8smdi+CdF7oQPY5QITt9Vp7G5E987i+clqLU 9pqw== X-Gm-Message-State: AOAM53148u7c2FseZ3cpO8uzjvFFXvLgbS8uvOobR18zeccRK0aeCbkR zW3FjgfNshq65fp6FNfnQvyt71ByiCzz1siCsy2/cg== X-Received: by 2002:a25:dc4:0:b0:629:2337:f9ea with SMTP id 187-20020a250dc4000000b006292337f9eamr27008652ybn.6.1647420641261; Wed, 16 Mar 2022 01:50:41 -0700 (PDT) MIME-Version: 1.0 References: <20220316031602.377452-1-luofei@unicloud.com> In-Reply-To: <20220316031602.377452-1-luofei@unicloud.com> From: Muchun Song Date: Wed, 16 Mar 2022 16:48:51 +0800 Message-ID: Subject: Re: [PATCH v2] hugetlb: Fix comments about avoiding atomic allocation of vmemmap pages To: luofei Cc: Mike Kravetz , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2022 at 11:16 AM luofei wrote: > > Since there is no longer an atomic allocation of vmemmap pages, > but a fixed flag(GFP_KERNEL | __GFP_NORETRY | __GFP_THISNODE) is > used. The description of atomicity here is some what inappropriate. > > And the atomic parameter naming of update_and_free_page() may > be misleading, add a comment here. > > Signed-off-by: luofei Reviewed-by: Muchun Song Thanks.