Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 16 Mar 2022 15:27:37 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     Zhang Qiao <zhangqiao22@huawei.com>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Zhao Gongyi <zhaogongyi@huawei.com>,
        Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH 4.19 01/34] cgroup/cpuset: Fix a race between
 cpuset_attach() and cpu hotplug
Message-ID: <YjHz2bifJBuCs/UK@kroah.com>
References: <20220228172207.090703467@linuxfoundation.org>
 <20220228172208.566431934@linuxfoundation.org>
 <20220308151232.GA21752@blackbody.suse.cz>
 <Yi73dKB10LBTGb+S@kroah.com>
 <aa25447a-f6ff-2ff2-72e9-3bbab1d430e9@huawei.com>
 <20220314111940.GC1035@blackbody.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220314111940.GC1035@blackbody.suse.cz>
Precedence: bulk

On Mon, Mar 14, 2022 at 12:19:41PM +0100, Michal Koutn? wrote:
> Hello.
> 
> In my opinion there are two approaches:
> a) drop this backport (given other races present),

I have no problem with that, want to send a revert patch?

> b) swap the locks compatible with v4.19 as this patch proposes.
> 
> On Mon, Mar 14, 2022 at 05:11:50PM +0800, Zhang Qiao <zhangqiao22@huawei.com> wrote:
> > +       /*
> > +        * It should hold cpus lock because a cpu offline event can
> > +        * cause set_cpus_allowed_ptr() failed.
> > +        */
> > +       cpus_read_lock();
> 
> Maybe just a nit, the old kernels before commit c5c63b9a6a2e ("cgroup:
> Replace deprecated CPU-hotplug functions.") v5.15-rc1~159^2~5
> would be more consistent with get_online_cpus() here (but they're
> equivalent functionally so the locking order is correct).

A fixed up patch would also be appreciated :)

thanks,

greg k-h