Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 14 Mar 2022 20:45:11 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yongzhi Liu <lyz_cs@pku.edu.cn>
Cc:     leon@kernel.org, yishaih@mellanox.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, fuyq@stu.pku.edu.cn
Subject: Re: [PATCH] RDMA/mlx5: Fix memory leak
Message-ID: <20220314234511.GD172564@nvidia.com>
References: <1647018361-18266-1-git-send-email-lyz_cs@pku.edu.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1647018361-18266-1-git-send-email-lyz_cs@pku.edu.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pBtIj/JzZLS32A8qUdhIiShHollNdGP9I73OYfbspvG3zPxsFJTNmat5AS5N?=
 =?us-ascii?Q?h1HQS5FfjcINAOm/b8AK/JFccOhwiXdKQIju6UEQdUg7mJG8HmhkisZBNdZh?=
 =?us-ascii?Q?WkxaNIxQs0r1UudwrGd2nmsg99N0Hi8HG5oi9PuC8wm/2xdri9GkN8um/IIT?=
 =?us-ascii?Q?8W6YCTAwoK9lFk5DnQnCDpOXRFfdrqAwAnHKos2kgiOGoEJxD1M7vVqcsmxI?=
 =?us-ascii?Q?DQ9t0TXm74ZYGSWwrOZaAYSgj/+yxu+bFpa8Ya4M5PluaKL72arRHDjHTx1f?=
 =?us-ascii?Q?r5tmMfcphLloiUI+ddMpSXNGvvEzsQPM1PGaqgmSqqkDmOxvBETd/ljX9TDr?=
 =?us-ascii?Q?W4cie9BKTXONy2qKIuyLKlxJAC8Ou6/yZnbRkxJoCbdocXpEL7lQQE6fY1u/?=
 =?us-ascii?Q?+cTTxD/FE+fZJ21t30/c+Yf1032gnl6oNOuURYLenzkt2k2h0tU8rforeUx3?=
 =?us-ascii?Q?AkO+VC3UKO+Uu+Rwr/35ZndMy7/kkkxoyvt1vNN4NzLpf5TDTj0Hu1oPW72Q?=
 =?us-ascii?Q?y7dxbqnONCqtFY2bkZxAgQ3p61WwbmIgYolbSXj6LHM/a8RkqdD884+BvdQ7?=
 =?us-ascii?Q?/T5+DAbDaV6vkuIC1dNSu2rHYVebbC98+OqEvWAGeSYOAkQFPpRtvpWxDtZC?=
 =?us-ascii?Q?4Cm8mX22c7dadSfU93iOZ5n88leL5s1ehC+2Q2KRtFqpzdIx40G7ls1tNRE9?=
 =?us-ascii?Q?7OlGXTgTfeyBTuzSJzWd6+J88Ai1o/n6gai4frGj8vZjy6IaX7UfKBk+najs?=
 =?us-ascii?Q?KRrtVUTaAUMohqdUo374T8zGeyAaKHZg2/4+g0lVzCa4Xqt53lj7pdzJMwao?=
 =?us-ascii?Q?wDy12CvqbiZIrv4ofDtZytLKG2G4yNkvSfPyJ7RtZx7Ii6K5UjekZzLbYOHD?=
 =?us-ascii?Q?CZuE9PnyL+6rdanC0ktt7G9zZ1uQOVph7bSjOxvfrhr9ATSA8C1BJKytuSss?=
 =?us-ascii?Q?FyrYYqM7tYqup6yb4V9zA4l+XhZEKXRISzNJYVAIVLZ0ZRALpLrrGT6grfE7?=
 =?us-ascii?Q?we7V2A2hJKRPzux2NRzlcUHLKTrEF73WM+Z9nK6/bp2uP7Twrz6Nbb8rREmn?=
 =?us-ascii?Q?u1YHqVpVO1L+/zilY9sSb4cRThekJTqRCz6tZbNyaPrLATLrDX5WqtB1c9uq?=
 =?us-ascii?Q?m7H4GaOrIVk7vaU3EC8eAz8JEZkdnnE2GuuEqUICuc/wFGCGTIAvf6FlqZio?=
 =?us-ascii?Q?74AVNSpCw/dPH9ln/RjyNobUGAEDsgMHRGwNTPBsinEHfGohgUzefvNMNJo7?=
 =?us-ascii?Q?CIfTNCZwGIEyfMFVpeKOaIEhpWyBG+pyt1ippGygpNJlHWXzvhDYHhNIQ2Ju?=
 =?us-ascii?Q?MMpfPmFbFUpbXQegQ1iRMtF6zG0yKgX8Gm1ZaaUeOzIQhZMrGJuwZ9Z475e2?=
 =?us-ascii?Q?m1rNlOdFP1sCbzHwDzDgx30esXBd/I1YyFwlQcPwAAg8/puVlNUCMaBTs+Ui?=
 =?us-ascii?Q?GZkmISJ+gHduHmExfrUL3OS9VDBCbJGB?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19f35aac-3595-4fd2-99cf-08da0614ae7a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2022 23:45:12.3979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eVaNyDtiwQlOp/ppZHqHRtgNIWz1bbf6NDRpWZLxLfpefnVV4sm34IFyTlxV2c52
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5989
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 11, 2022 at 09:06:01AM -0800, Yongzhi Liu wrote:
> [why]
> xa_insert is failed, so caller of subscribe_event_xa_alloc
> cannot call other function to free obj_event. Therefore,
> Resource release is needed on the error handling path to
> prevent memory leak.
> 
> [how]
> Fix this by adding kfree on the error handling path.
> 
> Fixes: 7597385 ("IB/mlx5: Enable subscription for device events over DEVX")
> 
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> ---
>  drivers/infiniband/hw/mlx5/devx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to for-next with Leon's commit message

Thanks,
Jason