Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp985391pxp; Wed, 16 Mar 2022 23:31:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzp5+EfVMhKpMg/V5MxoCxlOYuQot2FsdnmddI7QLTWZUA+scLkItPTMtj3iBJ0zcsjU8wF X-Received: by 2002:a17:90a:6441:b0:1c6:8de6:9fc0 with SMTP id y1-20020a17090a644100b001c68de69fc0mr526977pjm.163.1647498677999; Wed, 16 Mar 2022 23:31:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647498677; cv=none; d=google.com; s=arc-20160816; b=dx0N9CMIKZ7TdHBF19Huqr+apYKZ75dmfbbDQLSKMov22GMDF8fxNHj+Xxe1wUp477 UpvB7U+KjoYCh4qmWbl7z6ZC3eupiLR3D1Q5tykjqtOpEVuOy9HiFFdK0LiUs/cd/PnE i3n8ZFD/8vSKtHQOVv857p3Bqh/zbOPVJmBS82zYouJizMp2kiAB9sZtOddVY+po14Cx aqafwDvtx5wFK4ZM5nbIpoDpbyejypTFseZ7cVsGT3tNkDBQsgr+z5I0i5UU1NQnU5yB 7dxp5W7rJsy/tWaUIMX4KE9+q/TV14vbllKklqz3iK4AKzqzkVbikawaQiAvZ6TfqErS 9c/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Wcv8MQGxOeNCAfjC845UcGOBCjCeQW2oeC2dh5eLnTA=; b=FhrJQSieuf1mydE5PJHXEdhXVSborSmpyaR35dKMNrw6/HIugs5fTq+prV7+/0OPMY TcXunyAfh8YS6QXqfWT/la5UikHG4645p3kUTACcJOuZQZVLDhIxVE+eR736BhLbld/3 C+fPGgO8I8UlP1FpmYFabpiIBDaiV9K8Wo0Fq4KWmCbOOVI/ZCGvuO9lbH5NpUxR+ncW c55MRN/Vl7rSmpdpH2ZSkCBh3QISYlan2IYqfDQd3nK3rbxghqqZn2PI4df2q+5HhnAx VI/urIUr3//xpZVN/29/iaYMEna+PqqzLGUCS6hgHu2fcfd9MSvXNfuN+EDgsixRwrXI +BnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vKzVxOXv; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id k13-20020a056a00134d00b004f7550f7f55si4440509pfu.225.2022.03.16.23.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:31:17 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vKzVxOXv; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3645BE9C91; Wed, 16 Mar 2022 22:17:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240517AbiCNQKE (ORCPT + 99 others); Mon, 14 Mar 2022 12:10:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231785AbiCNQKC (ORCPT ); Mon, 14 Mar 2022 12:10:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 925CB38BCF; Mon, 14 Mar 2022 09:08:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AFC07611E2; Mon, 14 Mar 2022 16:08:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1801FC340E9; Mon, 14 Mar 2022 16:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647274131; bh=1ry5Be+DEJ/WTlPDuvzh39VOlKL+9h9m5A2hzUz9Pzg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vKzVxOXvTsEwyEgJKstMcx1XD8H5DHo6/TtHpV5/bgtRck/JjMiqOdXClV06oX/DV EtT5monyWeXLh2Y6O3RVVk0DJ5j4wuHhqrFSMa2mPs3Sg1T8Rc22vqG8Avn715LP6a /XS3/PmlMzDZ4GbH1jQDiygFT9AaXnjsRIcUl4dGfEHhUA6Nv3nArlbht/z4U/tgm+ Emc3R25ayY9qv9yu/U7yHk7YqLCeiOorvNpiWb/l9cwOJ5lYdq1ypHwQefzOyE0dkI ynP2v/g/T2JiSRcYnb9oLNE/2LqyhaYI8bfR5Xa5N4FCmhkUizfkBnZwwUt7nYgMHp y4i6fwWUTC8og== Received: by mail-ej1-f45.google.com with SMTP id dr20so34414546ejc.6; Mon, 14 Mar 2022 09:08:51 -0700 (PDT) X-Gm-Message-State: AOAM533wMTaQap8RrOk+rLgaUUCF+rNRbTMqfgjc6tfTyf7uhQiyvSmm gRp/FgievorZTXuQjKZyZ+Zrc0YFNpEMiwZGXw== X-Received: by 2002:a17:906:58ce:b0:6da:b548:1bbb with SMTP id e14-20020a17090658ce00b006dab5481bbbmr19130367ejs.14.1647274125897; Mon, 14 Mar 2022 09:08:45 -0700 (PDT) MIME-Version: 1.0 References: <20211214135852.2934670-1-vladimir.oltean@nxp.com> <87k0cwzgy0.wl-maz@kernel.org> In-Reply-To: <87k0cwzgy0.wl-maz@kernel.org> From: Rob Herring Date: Mon, 14 Mar 2022 10:08:33 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 devicetree] Revert "arm64: dts: freescale: Fix 'interrupt-map' parent address cells" To: Marc Zyngier Cc: Vladimir Oltean , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Shawn Guo , Li Yang , Biwen Li , Zhiqiang Hou , Kurt Kanzenbach , Rasmus Villemoes , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2022 at 9:34 AM Marc Zyngier wrote: > > On Mon, 14 Mar 2022 15:15:15 +0000, > Rob Herring wrote: > > > > On Tue, Dec 14, 2021 at 6:59 AM Vladimir Oltean wrote: > > > Therefore, the premise of the patch being reverted here is invalid. > > > It doesn't matter whether the driver, in its non-standard use of the > > > property, complies to the standard format or not, since this property > > > isn't expected to be used for interrupt translation by the core. > > > > I disagree. The non-standard part is that 'interrupt-map' translation > > is not transparent. 'interrupt-map' that can't be parsed in the > > standard way is just wrong, and I imagine was never the intention > > here. We simply cannot have platforms defining their own format for > > standard properties. > > That ship sailed a long while ago. We have a list of offenders, and we > can make sure we don't get additional ones. > > > Reverting this will cause dtc warnings now (IIRC) and just kicks the > > can down the road. Reverting is fine for now (I gave Arnd the okay on > > IRC), but I think the parsing will need to be updated to honor > > #address-cells and detect an old DT (probably by looking at the total > > size of 'interrupt-map') and mark that change for stable. That would > > only leave a new dt with an old kernel without stable updates broken. > > Seems unlikely a device is getting firmware updates, but not OS > > updates. > > Being able to rollback firmware and OS independently is important. The > tooling can be taught about the broken instances, which should be > enough. Adding to the parsing only makes things harder to maintain, > for no real gain. It's up to individual platforms to care about that. If they don't, then compatibility has been broken multiple times most certainly because in general there is 0 testing for it. Why make our lives more complicated in those cases? Rob