Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp986604pxp; Wed, 16 Mar 2022 23:33:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSh/1AoNSMtof9SxzANAbWQ4SezqMpH6tUdPUKesMTPr8PAFUlbY7eitrvD/bKE2liPcyx X-Received: by 2002:aa7:968b:0:b0:4f6:fa51:c239 with SMTP id f11-20020aa7968b000000b004f6fa51c239mr2954993pfk.48.1647498809606; Wed, 16 Mar 2022 23:33:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647498809; cv=none; d=google.com; s=arc-20160816; b=Edm3HhDRpfWf1W+dlU29N7do+TKIug/WE+LeLz5U1BGYLg++TTYZAjzIyjjMvbdfm6 nS/pQWj9aoweNKs9DeeJre28W+AEliMvFQPbI7PWaAojSBTvzY5+xKePErDtpL1baXqR jIxtBq7DCM0wJhvCoglMps7GF4X72cECpv7Gve2VWebAW22wXNtpgLs14ibx9yYXUs5d XZJrnCQsTCSAopsLtVQ/3QbrAzmo8cCnGfjmGxxMgaY4bvO5TimVjGyI21MWZ3l5+9Sn fDWAsuUrxf78BOzdGn8lwSfF2snOPpI6Uz0osYAjSB+MoosYD1hDLZVoNDFj1LZAIL43 RzDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=WQym2S0A87bJH3s4smjaJjbGcncP4tM/+udAF8lqFTo=; b=XMqMO26F0Glix8Mbz27ueqOz0NAOnkjN2Rl6Q6MiNButrBMgK6QCPiMEC+0dc4h4Er TXjzI1WmKDS5+hdnxfKLcISP6YG5sS/5JujmDBooZttcDkg5x1BDvamJNkhn6ktrNlOh A0tIKrNVUUxmDCorB37r6mUXewHf462f/+E6HO02R3QWOYzOpzcFWmHy+mYXGE2jr/Z/ CA93XQqH0CSy73lJPcsCna8P+IYskjy69oyOo4J4Om7gB2BHVivSsAy2ZHUsn5OOxrxc shN9Er4JQP3McO+15jOWwLBDlYLnIaztCZgwLmMpy/X1OpmE+LUtmd09+3UxDhTRxOph n7GA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id bj17-20020a056a02019100b003816043f044si1276223pgb.569.2022.03.16.23.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:33:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 47D0D2A85C7; Wed, 16 Mar 2022 22:19:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358443AbiCQC6X (ORCPT + 99 others); Wed, 16 Mar 2022 22:58:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234652AbiCQC6V (ORCPT ); Wed, 16 Mar 2022 22:58:21 -0400 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59A0D20F4F for ; Wed, 16 Mar 2022 19:57:05 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Mar 2022 10:57:06 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 17 Mar 2022 10:57:03 +0800 From: Haowen Bai To: , , CC: , , "Haowen Bai" Subject: [PATCH] macintosh: windfarm_pm121: Fix warning comparing pointer to 0 Date: Thu, 17 Mar 2022 10:57:02 +0800 Message-ID: <1647485822-16717-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai --- drivers/macintosh/windfarm_pm121.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c index ba1ec6f..f0aa263 100644 --- a/drivers/macintosh/windfarm_pm121.c +++ b/drivers/macintosh/windfarm_pm121.c @@ -650,7 +650,7 @@ static void pm121_create_cpu_fans(void) /* First, locate the PID params in SMU SBD */ hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); - if (hdr == 0) { + if (!hdr) { printk(KERN_WARNING "pm121: CPU PID fan config not found.\n"); goto fail; } @@ -969,7 +969,7 @@ static int pm121_init_pm(void) const struct smu_sdbp_header *hdr; hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL); - if (hdr != 0) { + if (hdr) { struct smu_sdbp_sensortree *st = (struct smu_sdbp_sensortree *)&hdr[1]; pm121_mach_model = st->model_id; -- 2.7.4