Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp991018pxp; Wed, 16 Mar 2022 23:42:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTHJPdUqjX/IWcaJV3Jhmd6MsDdxM1GQmZh7nLgQ3vrXE/ASnk8g+DO8uuemF1ByXXAMqO X-Received: by 2002:a17:90a:168f:b0:1b9:453a:fe79 with SMTP id o15-20020a17090a168f00b001b9453afe79mr14390157pja.107.1647499343411; Wed, 16 Mar 2022 23:42:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647499343; cv=none; d=google.com; s=arc-20160816; b=Vvm6JqFVP/GSAKVrYiTCp8s8WFYQdGp7M6jPSeIYvMg7C0d5RM5gAiyE4SdKrv/0h4 oYx1xou0px3ATumMN391WE+FOoaBT0vuP1oqFCjZQv+g0gKME4IGINuIDPOqo/Ow8z1P FZye0WXQIjSFPsl9Efr1SHsWUnzV1+IwCcd4BxAZ/zXNxmCDBxFgiqMcXHcUWYQas8x4 D0aky7Zn4UycMvD59kg6bdBAtLr/Ulsejuad9L4Nznw5hbIA8BCRX7ilEcxUt2xdzKUC AipepkvKxFH5o1c4F9vJKu2f+/+HhOIUaSXIeSJ0fF33n89FaYNE6kVp6fuyyMzc09vl N6Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=gLVkITMmXyyq0fqv8xW0/yoICDYPA15xakBEIFRrmU8=; b=wyBIGRwebtxEX+OG+GLki5utKTwdITZbRJ+rP36S5WdndYG6mX6+/seQpojnShiKsy I3O7lII8sff4ITCwP8HnyBX2/h5PcK1oGqVpYZxqYxyACxT/gBtjYjFzjgqvpdGzQvmi pbdqB95V7HlckHFitAVUV8Ovd5Var0xi7gzVLLcxs00NDnybcG56WZTvlvqD3Aupn6mI waxb82iweRhKc5vfygEQcM7JhtDFJhhOj+gAkRy2ci5C2ZnwPrsEESzdOXU8D1JddRLM VXNukqGV8YEUWma2MsZ7wX+a+l31vtPrLYeedfeTI+aFDuuI0E9MeecSVeq3an0jIirl 1Udw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id p21-20020a635b15000000b003816043ee75si1181442pgb.106.2022.03.16.23.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:42:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6400826480F; Wed, 16 Mar 2022 22:25:55 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231370AbiCPNhi (ORCPT + 99 others); Wed, 16 Mar 2022 09:37:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbiCPNhg (ORCPT ); Wed, 16 Mar 2022 09:37:36 -0400 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33DB447075; Wed, 16 Mar 2022 06:36:22 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:35184) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nUTp6-00BMHf-2H; Wed, 16 Mar 2022 07:36:20 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:37920 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nUTp4-00Bptv-1e; Wed, 16 Mar 2022 07:36:19 -0600 From: "Eric W. Biederman" To: Geert Uytterhoeven Cc: Yang Li , Oleg Nesterov , linux-m68k , Linux Kernel Mailing List , Abaci Robot References: <20220315235148.54253-1-yang.lee@linux.alibaba.com> Date: Wed, 16 Mar 2022 08:35:59 -0500 In-Reply-To: (Geert Uytterhoeven's message of "Wed, 16 Mar 2022 08:20:09 +0100") Message-ID: <87pmmm58ao.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nUTp4-00Bptv-1e;;;mid=<87pmmm58ao.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18H+qCfF1DyV5JF2Ghckp/00rukoXyHPSg= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-DCC: XMission; sa08 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Geert Uytterhoeven X-Spam-Relay-Country: X-Spam-Timing: total 1456 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 13 (0.9%), b_tie_ro: 11 (0.8%), parse: 0.86 (0.1%), extract_message_metadata: 11 (0.8%), get_uri_detail_list: 1.20 (0.1%), tests_pri_-1000: 5 (0.4%), tests_pri_-950: 1.54 (0.1%), tests_pri_-900: 1.19 (0.1%), tests_pri_-90: 136 (9.3%), check_bayes: 131 (9.0%), b_tokenize: 6 (0.4%), b_tok_get_all: 8 (0.5%), b_comp_prob: 2.2 (0.1%), b_tok_touch_all: 110 (7.6%), b_finish: 1.54 (0.1%), tests_pri_0: 1269 (87.1%), check_dkim_signature: 0.68 (0.0%), check_dkim_adsp: 9 (0.6%), poll_dns_idle: 0.42 (0.0%), tests_pri_10: 3.9 (0.3%), tests_pri_500: 11 (0.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH -next] ptrace: Remove duplicated include in ptrace.c X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Geert Uytterhoeven writes: > Hi Yang, > > CC Eric > > On Wed, Mar 16, 2022 at 12:52 AM Yang Li wrote: >> Fix following includecheck warning: >> ./arch/m68k/kernel/ptrace.c: linux/ptrace.h is included more than once. >> >> Reported-by: Abaci Robot >> Signed-off-by: Yang Li > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven > >> --- a/arch/m68k/kernel/ptrace.c >> +++ b/arch/m68k/kernel/ptrace.c >> @@ -19,7 +19,6 @@ >> #include >> #include >> #include >> -#include >> >> #include >> #include > > This is due to commit 153474ba1a4aed0a ("ptrace: Create > ptrace_report_syscall_{entry,exit} in ptrace.h"), which is not yet > in the m68k tree, but only in next-20220315, so I cannot do anything > about it before v5.18-rc1. > > Eric: Can you still fix this in the original commit? Not unless it is something very serious. Replacing the commit means invalidating testing and review. Which I would rather not do. In this case I can merge a trivial fix to remove the duplicate. Let me find Lang Li's patch and merge that. Eric