Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp992677pxp; Wed, 16 Mar 2022 23:45:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyximQXhVVtJubMxiicHCRU2LoHmMdd0kIAJ/6LsVuybDiP9i8gRThg118q24WFhydXW2VJ X-Received: by 2002:a62:30c4:0:b0:4f7:2b29:984 with SMTP id w187-20020a6230c4000000b004f72b290984mr3412085pfw.11.1647499543477; Wed, 16 Mar 2022 23:45:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647499543; cv=none; d=google.com; s=arc-20160816; b=zI4IV3HxVGxnFxQxa0CYHD/MWAGDVILSVHbPIpNFsb2cT4vYtBTYUBpi6Vp29sVOmC MTGLTktbuejrFdNLdYn+7duO7/zeV0+SRNUImRYtrEkgeBFoZnmeD3QRXsHrKKlKPzBk BdhS/fhAMzMHL+hXn5/53MtOpxhyycSE0l6lla7mTeH+ijquHb7HF4taNw72r6TtZqfM Vq4g4/HcNEjudVWaNmcL2GcWZwb3Bmw6HhM+0ptw3RxifXPLy60vwjB/bguSyQz6UG6H OFnDHAnYevCIq80szb5TMfPx3yeKwa7+iHqIdr6VjRKRAFnc5k4xTmZ9hOtbOBKUrQ8s ivHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=82Q89pVpb0gOjDpDC75YHKViZBUBFI5LlrebtZPWhgQ=; b=j0Pa+je4gV3BLyy7+x/eO88N1QBmTLfM4NljRJi3cDJg5owxvGiY0mvu8AwRmFL2kd UxZeF4n4M3jLY8vHZCN7w3MYhFCMnQSHVhDo9k6AQ21tiuFchqzI3Un13hAz4j+XAqxv mFQLFWjAMww3qVnmj9Depq3dodvnODJxxX8s0HN1vCwEQA962gLApJ3Crx+OnN+SHZXA jv0mGNjOu79qAz/+Y3EiA5+LcV48ZGzoJBJr2toNRAzQ5/8mvKsvu7Jg5Un18lHxYEvn XM0jKv7mAolV8M2GjTiUxD6g8s/24wkj01/derHRSLI/SD4ULToG6WwVcB4r5SBrfPYw qWdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a22-20020a656416000000b003816043ef53si490594pgv.328.2022.03.16.23.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:45:43 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CBC162DB5B7; Wed, 16 Mar 2022 22:30:31 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358447AbiCQCeB (ORCPT + 99 others); Wed, 16 Mar 2022 22:34:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358444AbiCQCeA (ORCPT ); Wed, 16 Mar 2022 22:34:00 -0400 Received: from mail.meizu.com (edge01.meizu.com [14.29.68.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436C720190 for ; Wed, 16 Mar 2022 19:32:43 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail04.meizu.com (172.16.1.16) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Mar 2022 10:32:42 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 17 Mar 2022 10:32:40 +0800 From: Haowen Bai To: , , CC: , , "Haowen Bai" Subject: [PATCH] macintosh: windfarm_pm81: Fix warning comparing pointer to 0 Date: Thu, 17 Mar 2022 10:32:39 +0800 Message-ID: <1647484359-12402-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai --- drivers/macintosh/windfarm_pm81.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/windfarm_pm81.c b/drivers/macintosh/windfarm_pm81.c index 82c67a4..1dfced5 100644 --- a/drivers/macintosh/windfarm_pm81.c +++ b/drivers/macintosh/windfarm_pm81.c @@ -400,7 +400,7 @@ static void wf_smu_create_cpu_fans(void) /* First, locate the PID params in SMU SBD */ hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); - if (hdr == 0) { + if (!hdr) { printk(KERN_WARNING "windfarm: CPU PID fan config not found " "max fan speed\n"); goto fail; @@ -704,7 +704,7 @@ static int wf_init_pm(void) const struct smu_sdbp_header *hdr; hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL); - if (hdr != 0) { + if (hdr) { struct smu_sdbp_sensortree *st = (struct smu_sdbp_sensortree *)&hdr[1]; wf_smu_mach_model = st->model_id; -- 2.7.4