Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1d21ee8a-837d-807d-14a4-4ee1af640089@vivo.com>
Date:   Thu, 17 Mar 2022 14:51:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] selftests: net: fix warning when compiling selftest/net
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Shuah Khan <shuah@kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "zhengkui_guo@outlook.com" <zhengkui_guo@outlook.com>
References: <20220316115040.10876-1-guozhengkui@vivo.com>
 <20220316202251.382b687e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Guo Zhengkui <guozhengkui@vivo.com>
In-Reply-To: <20220316202251.382b687e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGIrMExrSHRWK2xaZW1ZVFlBOFM4TzNBNEVVa1YrQzJ3V2tXaVBRaTNZRWpl?=
 =?utf-8?B?K2dyVTc2eW1oYzdWdW1SdkMxZyttKy9BS0pqU2pvRVplVS8veEt5Mkx0Z3Vr?=
 =?utf-8?B?RWxyUEJTYnFXRUJRdVdmRE9pVzRWZ1pock5HUW8rSU04OHpRTUpyVklGSXpY?=
 =?utf-8?B?b01sNXp0cWlDMCttM3diQ3VIOVQ2VVJTa0xQdkRmUzlHbUtZbURncnVGSXBB?=
 =?utf-8?B?dVYxS0lnNWlzSjBBZFVtejhTL05SUmNtc3ZyV1JROWd2eEhkYnZDVXhDeTI1?=
 =?utf-8?B?djJJZjlBQ2wxdncwa0gyM1JOU3EvNTFYcmRMVTBsb282RlB4RUpST3FRcVhM?=
 =?utf-8?B?VUxSMGMwU29WTzhVa2VNOFRCTEJwdmJ6QnZjTDJJTmk4UjlRRU1QZkxrcTBG?=
 =?utf-8?B?bGZpdVVQWWMvRnZ4TjhCREd2UUR3bFdGK2tZSmRubHRrcTlMY0d5YUhsdk5Y?=
 =?utf-8?B?ZmNoUmU5Y3krRDEyaXlEUXJQaXRoOFpObFBxL04xdHlaMGhUTlVvS3RjQTZE?=
 =?utf-8?B?ejB4Q0lxQUd4Uk4xVzlrQy9FV2E5YThKQmlSV1dwdDE2cFJPSmxLR3h3b2ls?=
 =?utf-8?B?ODl5K2FhNlZQbEFhSmVaTWtUNHY4WTZhVFA0RzBkZXBMZms3SFhrTXJaK05Q?=
 =?utf-8?B?SmpzdDI3V2F3dmJVbFdGQUY4L29sc3ZkV2hBck95UVFMLzJ0bGFHNlFydnda?=
 =?utf-8?B?Y1FMODlmL2FnZS9HV24xT1l2eXBORk9PZnJabnpJeks4encrL0VxZ0NNbVpN?=
 =?utf-8?B?K3hzZjRJcnB2cDMyQVNVa0VJeTdKazkxZHUrYXVsRWpEUHBTblJrMWFhUDRk?=
 =?utf-8?B?TEJMbExUeXRzZENwemorNTliKzVvRHg5cWFiajVZejhMWXliYWhERFhmOGpp?=
 =?utf-8?B?Y1daT1BjZUk1NGRTR1RxL29MWVpNTzVHblBzeC9Ib2NYeTV1TTRySnJpb1Nm?=
 =?utf-8?B?akFTMGhIeEVnUWpUS2FGWEpOV3Zpd0hOam5FY29NZ1R0cHVxOENWV2syVEpm?=
 =?utf-8?B?NGk3R0tSYlVUL3F4QUF2MHB5NzA5L1RzWWJZOGYxUEJWcUMxaVZRTmI4T1I1?=
 =?utf-8?B?b2J1TzZSdm9hWHpvTmx0N1MwRFhhZFNoRHo2cXNkcnNrZzNtMHFRb3Q0UURy?=
 =?utf-8?B?d0ZpZG5aSFhYRkNsZXprZU1nUW1aMDNHblpJZEdrWEU5SUFmeWY5TUljRmRO?=
 =?utf-8?B?b2tFU2FFZGZwMlY4UzJJMS96dDc2UWpuUkZJTHV5K29vNS9pS3FlTytaVEti?=
 =?utf-8?B?eHptOElZeTk1SVcxZm9hTHJ6RFB5OGRpMndzQlpDUXFIZ1ZnSjdod1JvMW5y?=
 =?utf-8?B?NUNEMGFWTkdGd044YzlISFBRR3hrVkU2NEkrbFMyWlpVUzgzTUVpMzZFdmU3?=
 =?utf-8?B?a2lDM1VwcDc1QmRiRmZWbDQzdEkyZUVvS1NuL2NjQ2ppaXlQeStHNHRrMFBw?=
 =?utf-8?B?Ulc0MFNuSE1PbjkrUFVqQW51Z2ZsR2FYMkIxNlE3Wk5MdmdxRTJtVXlmVGtV?=
 =?utf-8?B?VkRQckxJTzZOa0FSSzhjcFJpZHd5THdyeVdVSStOcEtwTlprcDRjUGMwL3RM?=
 =?utf-8?B?RU13SkRrZTFWbU0xNTJYQjdqbENwcVNuVncyUHRScEVvbDNSTGE1UVdJTG1R?=
 =?utf-8?B?dWg5Wm00c0FnVUF3emcvVGZaTTAreEU3UHp0Y0I3S3FIeUE3VFJ2d0taZW8x?=
 =?utf-8?B?cS9nQWZLU1Z4RmJFS2RLWVBOa0xQQ2FxYThjd1cySGZWY2h0NFU3REY3RXdO?=
 =?utf-8?B?UnkrWlVQYUtEaFZkQ0NFS1JJQ1EyR1l5N1EzNnV1ZkdiczJPMnlUdE8zblh5?=
 =?utf-8?B?bVRSOVppaU1neWxGeFpHeXl1NEFTSS83Z0FmSkNIR1hDZEdHTmtlM2ltSUps?=
 =?utf-8?B?ckRRMkg5RjY1Y05zaW1LWXhPVVpLT1pOUnRLS1Q5RjRibmQxbUJkTkcyRG40?=
 =?utf-8?Q?Z5knw/XHgmIK3VDQcceddstDo6EpwDhc?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abe26f91-b6af-42af-90ab-08da07e29f4c
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 06:51:54.8100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vp4lyXToj6zCfv0VDlgSoExcM84TXbh2gU4VshT5siL2Idizhp2p+EDwMkSrKxo2dATpVRKt2keTP3zLronFXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4082
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/3/17 11:22, Jakub Kicinski wrote:
> On Wed, 16 Mar 2022 19:50:40 +0800 Guo Zhengkui wrote:
>> When I compile tools/testing/selftests/net/ by
>> `make -C tools/testing/selftests/net` with gcc (Debian 8.3.0-6) 8.3.0,
>> it reports the following warnings:
>>
>> txtimestamp.c: In function 'validate_timestamp':
>> txtimestamp.c:164:29: warning: format '%lu' expects argument of type
>> 'long unsigned int', but argument 3 has type 'int64_t'
>> {aka 'long long int'} [-Wformat=]
>>     fprintf(stderr, "ERROR: %lu us expected between %d and %d\n",
>>                             ~~^
>>                             %llu
>>       cur64 - start64, min_delay, max_delay);
>>       ~~~~~~~~~~~~~~~
>> txtimestamp.c: In function '__print_ts_delta_formatted':
>> txtimestamp.c:173:22: warning: format '%lu' expects argument of type
>> 'long unsigned int', but argument 3 has type 'int64_t'
>> {aka 'long long int'} [-Wformat=]
>>     fprintf(stderr, "%lu ns", ts_delta);
>>                      ~~^      ~~~~~~~~
>>                      %llu
>> txtimestamp.c:175:22: warning: format '%lu' expects argument of type
>> 'long unsigned int', but argument 3 has type 'int64_t'
>> {aka 'long long int'} [-Wformat=]
>>     fprintf(stderr, "%lu us", ts_delta / NSEC_PER_USEC);
>>                      ~~^
>>                      %llu
>>
>> `int64_t` is the alias for `long long int`. '%lld' is more suitable.
> 
> That's on 32bit machines, I think what you need to use is PRId64.
> Or just cast the result / change variable types to long long.

But it should be '%ld' instead of '%lu', right?

Zhengkui