Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v6 2/6] fpga: dfl: tracking port conntected with AFU
Thread-Topic: [PATCH v6 2/6] fpga: dfl: tracking port conntected with AFU
Thread-Index: AQHYOQUdByxZzeJi+E+POSFjFU02WqzDPQvw
Date:   Thu, 17 Mar 2022 08:25:33 +0000
Message-ID: <DM6PR11MB3819F26BDA4AA2826AFD5CA285129@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220316070814.1916017-1-tianfei.zhang@intel.com>
 <20220316070814.1916017-3-tianfei.zhang@intel.com>
In-Reply-To: <20220316070814.1916017-3-tianfei.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CafAabVSggk7WJRTgscuKrSGsUJ8WOQmCqin6LRo70Z4Fle+5SJjb9piYsiH?=
 =?us-ascii?Q?cpyTkohsR3JlXYQ+k83XqrsrSF3C70EdzZLLcbrYWHPqjxg4LEw5gEaogH3U?=
 =?us-ascii?Q?HlgFVBbXkR+3hCx2Z9LEVHd2IdQNJfpXMgkPts9qeEKNhxdMGRwR+E9JNnIh?=
 =?us-ascii?Q?qnCvkrO7+eTHzudaYnqGGkVo7N6em9/DmN2XCiiUfhKqMNgxwlFyLw+OIIgl?=
 =?us-ascii?Q?i6QXkPVwm0OEVqGsQiby5P4gb15/dax3U+w/TmPpgai/UxzOsYL61Aysr20o?=
 =?us-ascii?Q?JuLSoEto3GDxTT/UKY3UyOAxTYGPINpJ0/RffrEddVBRbiztl+J5HltGiBZt?=
 =?us-ascii?Q?05nTQdrfQUWfdnBsVIibKDElnE/oq7KNyLnxLzO9vyj6v0XwJP2YFdlmEmZy?=
 =?us-ascii?Q?igW5LUldvuANTj1ego2KPFKovgk0qc+/hi/MQp3o4+jwlkfjo0JU7k1+Us7b?=
 =?us-ascii?Q?AloWTEB4k+CsejM2u5oe7IIDY7gBphG1jl8FCMSdc70kTMoogGMSgxRSNwoX?=
 =?us-ascii?Q?YITXjrE+kmiXPyyH4pHSdL8bcSA6Xhl5gXkJ69YWrmNbtpKDsTb1fMeMzGxf?=
 =?us-ascii?Q?eph2EAY+yqQ0pY1aSKgv5aHkobDZFCCyqjqHZnEOBTPYb2E9g5HH++g/w+OV?=
 =?us-ascii?Q?jQW7FhWRjh+BP/SqyqvFrM74ZQ2JrX0rvNU6wQXvrWukXb6eg/MHFopvzdcF?=
 =?us-ascii?Q?Fmo6VITu6g3jgkoMeehEJ6Bp2EWZnncrxFzUJSIhBmTj6vGa/npB7ZW7D2C4?=
 =?us-ascii?Q?dIRMC3JjrBcCXbSAdonPDg1W9/pMuoqWyS7SOM04TglsVCi6tjUlvKH6nQ1b?=
 =?us-ascii?Q?0+3KKUTTG+BYhCP9VeDJ16g1UQ2yYDwTIfPbUK0a/ef/t5otftv8UqkzQUOW?=
 =?us-ascii?Q?YIny6pfT3cGQy9Syo0RNTEPHxJXF1U/hegLMceZEc5NXui5eSQGLWzXL6Rt+?=
 =?us-ascii?Q?MtofpysVsnB4UhJfCShyXwngy1f4GxcV+oi/DA4XxcLlmlVp8Nzny2UqMu96?=
 =?us-ascii?Q?O6qPKu/Qp64CWzp+IwCDo7B2RSHTEYFUly4ebiz85y9aM3Vx93JJWyYTiN8o?=
 =?us-ascii?Q?ld7iqDrzTDhewdEpVmYf0L8SaudsXfEXQinZ5iu+pMfLVZExV32Z5r8Tm2v7?=
 =?us-ascii?Q?0FMAww7uZ3+Odg2PLQga3Xgho1Kr1AksYpfLJNpQwqkEDxjhmg7yb611qxgh?=
 =?us-ascii?Q?l8ppJtrEbO1HzCwLXUuxx2/KBsFLolIau0XO3Q9c3bxL4LooUhlIPZmlsHe3?=
 =?us-ascii?Q?pgBweSn3jOhIKq7fn3XJEZclLc5KoDYswybE9rjq7uKfF9AHnwfzuZL/S5Gu?=
 =?us-ascii?Q?Pqhy1ZfKBrVRYCYc8dcRtHjTrAqlyJ41bKnNE0oXFWDt6li0lG7gqdrYB7TK?=
 =?us-ascii?Q?cZJVTt0lN9DxGQhlqAv7hbnNCg88xbM3HLgvstpP5+CGR6f1vbhxsnIHFiVy?=
 =?us-ascii?Q?1TrJE/5SQis=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21ab222e-672d-4d57-fe86-08da07efb4c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 08:25:33.5349
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gRT2Vqm1GqSlR7bZ0s/QvReFl/5ZX+zQXOkiZeaQMH5CHzM7h9FoxWnOhE2x9uMKCs/YZhYyDzd1og0bgnNCvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4153
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Zhang, Tianfei <tianfei.zhang@intel.com>
> Sent: Wednesday, March 16, 2022 3:08 PM
> To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu, Yilu=
n
> <yilun.xu@intel.com>; linux-fpga@vger.kernel.org; linux-doc@vger.kernel.o=
rg;
> linux-kernel@vger.kernel.org; rdunlap@infradead.org
> Cc: corbet@lwn.net; Zhang, Tianfei <tianfei.zhang@intel.com>; Matthew
> Gerlach <matthew.gerlach@linux.intel.com>
> Subject: [PATCH v6 2/6] fpga: dfl: tracking port conntected with AFU
>=20

"conntected" -> "connected"

> From: Tianfei zhang <tianfei.zhang@intel.com>
>=20
> Introducing flags in dfl_fpga_cdev to track extensions
> or new features discovered during DFL enumeration. It uses
> some lowest bits of flags to track the port status which
> the AFU was connected to port device or not. In legacy
> model, the AFU was connected to Port device, but in "multiple
> VFs per PR slot" model, the AFU or PR slot without connected
> to Port device directly.

It's "Port with AFU vs "Port without AFU", so why we have this flag
in container device not for each port device?=20
and probably you need to describe why we need this flag. What I am
thinking is that port driver can use this flag to decide if afu related
interface will be visible or not...does it make more sense to have
this flag for port device itself?


>=20
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
> ---
>  drivers/fpga/dfl.c | 11 ++++++++++-
>  drivers/fpga/dfl.h | 12 ++++++++++++
>  2 files changed, 22 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index 599bb21d86af..712c53363fda 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -1124,8 +1124,10 @@ static void build_info_complete(struct
> build_feature_devs_info *binfo)
>  static int parse_feature_fiu(struct build_feature_devs_info *binfo,
>  			     resource_size_t ofst)
>  {
> +	struct dfl_fpga_cdev *cdev =3D binfo->cdev;
>  	int ret =3D 0;
>  	u32 offset;
> +	u32 port;
>  	u16 id;
>  	u64 v;
>=20
> @@ -1160,8 +1162,15 @@ static int parse_feature_fiu(struct
> build_feature_devs_info *binfo,
>  	v =3D readq(binfo->ioaddr + NEXT_AFU);
>=20
>  	offset =3D FIELD_GET(NEXT_AFU_NEXT_DFH_OFST, v);
> -	if (offset)
> +	if (offset) {
> +		if (dfh_id_to_type(id) =3D=3D PORT_ID) {
> +			port =3D FIELD_GET(PORT_CAP_PORT_NUM,
> +					 readq(binfo->ioaddr +
> PORT_HDR_CAP));
> +			cdev->flags |=3D dfl_feat_port_connect_afu(port);
> +		}
> +
>  		return parse_feature_afu(binfo, offset);
> +	}
>=20
>  	dev_dbg(binfo->dev, "No AFUs detected on FIU %d\n", id);
>=20
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1fd493e82dd8..bc56b7e8c01b 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -461,6 +461,16 @@ int dfl_fpga_enum_info_add_irq(struct
> dfl_fpga_enum_info *info,
>  			       unsigned int nr_irqs, int *irq_table);
>  void dfl_fpga_enum_info_free(struct dfl_fpga_enum_info *info);
>=20
> +/*
> + * Bitfields in flags of dfl_fpga_cdev.
> + *
> + * 0 - (DFL_PORT_CONNECT_BITS -1): AFU was connected with Port device.
> + * DFL_PORT_CONNECT_BITS - 63: reserved.
> + */
> +#define dfl_feat_port_connect_afu(port) (BIT_ULL(port))
> +#define DFL_PORT_CONNECT_BITS  MAX_DFL_FPGA_PORT_NUM
> +#define DFL_FEAT_PORT_CONNECT_MASK ((1UL <<
> (DFL_PORT_CONNECT_BITS)) - 1)
> +
>  /**
>   * struct dfl_fpga_cdev - container device of DFL based FPGA
>   *
> @@ -470,6 +480,7 @@ void dfl_fpga_enum_info_free(struct
> dfl_fpga_enum_info *info);
>   * @lock: mutex lock to protect the port device list.
>   * @port_dev_list: list of all port feature devices under this container=
 device.
>   * @released_port_num: released port number under this container device.
> + * @flags: extensions discovered during DFL enumeration.
>   */
>  struct dfl_fpga_cdev {
>  	struct device *parent;
> @@ -478,6 +489,7 @@ struct dfl_fpga_cdev {
>  	struct mutex lock;
>  	struct list_head port_dev_list;
>  	int released_port_num;
> +	u64 flags;
>  };
>=20
>  struct dfl_fpga_cdev *
> --
> 2.26.2