DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=B2Dp+VbE4+wiZzqMPjk3eqU27wCw649tNDOHDrtZiGcpvnc5wyGxSNR1txRh34mMko0Nl+Wxn0VlmD64YviC3SaR+bRV86GANJO8rDh191gCBaDIOnF4vSHm6zKFM1UlFI8yK0KbhWvquV2ueNb9LbOYWfs78KtAvBuT/D/vXl0=
Message-ID: <d120d5000702230706u4e7576du6661ce1b58e058aa@mail.gmail.com>
Date: Fri, 23 Feb 2007 10:06:14 -0500
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Pete Zaitcev" <zaitcev@redhat.com>
Subject: Re: input.c: start on release
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20070222212919.850ceafe.zaitcev@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070222212919.850ceafe.zaitcev@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1493
Lines: 38

On 2/23/07, Pete Zaitcev <zaitcev@redhat.com> wrote:
> Here's a curious code I found in drivers/input/input.c (2.6.21-rc1):
>
> void input_release_device(struct input_handle *handle)
> {
> ....
>        if (handle->handler->start)
>                handle->handler->start(handle);
> }
>
> Is the above supposed to be this way, or you meant ->stop here?

It should be ->start(). You are probably confused a little by the name
of the function. input_release_device() is called when userspace
issues ioctl(fd, EVIOCGRAB, 0) releasing (or ungrabbing) the device
(as opposed to xxx_release(file, inode) type functions that are called
when last user of a file drops off). In our case we want to give
handlers a chance to resume their control over device. Right now
standard keyboard driver uses start method do bring back in sync LED
state of a keyborad-like device after it was released (ungrabbed).

>
> The commit comment says:
>        Input: fix list iteration in input_release_device()
> It says me precisely nothing about the way it's supposed ot be, sorry...
>

It reason for ->start was explained in the patch it was introduced in,
the changeset you are referring to literally fixes issue with
iteration through list in this function.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/