Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1387619pxp; Thu, 17 Mar 2022 08:26:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnXr5WREyLG0rbrROPirlIYJfS1pX0Hqx6Zlc5zizkpDq94JPZ4Hddb+8r+gANyImaMuT4 X-Received: by 2002:a17:903:1248:b0:151:9708:d586 with SMTP id u8-20020a170903124800b001519708d586mr5519907plh.15.1647530768670; Thu, 17 Mar 2022 08:26:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647530768; cv=none; d=google.com; s=arc-20160816; b=r8Zu+d6YjcyVnAyRQyPB+O9C4ymNIlTDrn9KTnhPOUTWhuoTASxsoSi8IiewjQuAoQ JcWLhorKOLqShfJMFwzTi2xZFW0nazDgj/xGpAAwS/kxUfNyzrfEJRazkp7mtnLovca8 9sQd9P7qDVuMh7PJzlmqHIdkUXTG79J/nmtsXv8N6W4yb12IBuL1bx8KJUTd3a9XQHMd DYeYWlRnOnPm1NOon0Vncx052DKp2MCor9n5dFfEiRrn4vPnHf3m7GHsdSbbY/bUtcTO sNoKCU25hFfAoBWvmbUbv72GislPzS7lN7G+z87FDWUM4RwXyP9MGD3r+59sxH5w7vuz 2z4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=smpp0szDqkqAUO4tvjx7+8JUXPCKyqHczCF0+7kJh90=; b=ehFO2ErqvuQea2DE84lxdPVMWZWqY1BrHC6y802HSn0XqghdisjQUfsZQ+i3b0hMTJ AnHq7/6FsEdhBbNlZ3SCiptXre+m8oX520SgH+E0u+MYKAaHjPtd/6MIjcDux7iHdVak c6Nzp7HB0B8kMugu2NnR5Z7K2YV51S5e/YHdCxnhyYzH6dvFkmkIVahdNjF3XB/PjCLv PEr2IRkdy6jDENT9F/3MZC+kLa1JWv8gVi85mREp5d4h4DZoRy+kz/5CmMCU70wnkG6M 5+q9h74UItqEkFimNkLtHXcYhf+ssz2OMPKBp1ztZXMZAdBvirI+iMqOhIECJme0h3nB cy2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x34-20020a634862000000b003816043f17asi2220007pgk.879.2022.03.17.08.25.43; Thu, 17 Mar 2022 08:26:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230027AbiCQKGo (ORCPT + 99 others); Thu, 17 Mar 2022 06:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbiCQKGm (ORCPT ); Thu, 17 Mar 2022 06:06:42 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 358331DC998 for ; Thu, 17 Mar 2022 03:05:24 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Mar 2022 18:05:22 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 17 Mar 2022 18:05:22 +0800 From: Haowen Bai To: , , , CC: , , Haowen Bai Subject: [PATCH] firmware: edd: Remove redundant condition Date: Thu, 17 Mar 2022 18:05:20 +0800 Message-ID: <1647511520-26455-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The logic !A || A && B is equivalent to !A || B. so we have to make code clear. Signed-off-by: Haowen Bai --- drivers/firmware/edd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index 69353dd..5cc2389 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev) int i; for (i = 0; (attr = edd_attrs[i]) && !error; i++) { - if (!attr->test || - (attr->test && attr->test(edev))) + if (!attr->test || attr->test(edev)) error = sysfs_create_file(&edev->kobj,&attr->attr); } -- 2.7.4