Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1514359pxp; Thu, 17 Mar 2022 10:36:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNxI+shyP5W2HUkSuuwm11EI8430jhoPYtCFYhqJ0A8JDt9tTC1hdEBvEk/uGQU84XLqA8 X-Received: by 2002:aa7:de10:0:b0:418:d60d:aab8 with SMTP id h16-20020aa7de10000000b00418d60daab8mr5832950edv.322.1647538617588; Thu, 17 Mar 2022 10:36:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647538617; cv=none; d=google.com; s=arc-20160816; b=vGzx2f3IOSoC0ps4uWl99N7xgbsucViKZ6ONOaprQ1oTkGQ0O/7FR4ZmQ13zXvQ0SZ z59kIKoar0GITz6Moq5W2By6UdmRxt21EFxSPisnbE4xoTpV7JrcVoup4JScqId438DM KgX76Rk0AW/a5LCMt3s4Yz5rucRD7g6Ok0oXgnZ7VoF3TrbYE6NjHfEg4Rpon/HU33us L7R3MIQSQWTm31zUQOHUS9lwZNgV6CyGQRZ9OnfrjWrvtUfI6TLk3QK+trxfKylzfodu A65smhkq0IYWapRVqcacIadjY0V9j5sRQcNSidUQ1K65HxJN2kEx8E1xW5dMfbilEWl6 oQfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=wywg4x91ht1wDsZE8LDgwKs/937jDdBiI3aoJq8Icig=; b=DRp34SV0XPIhnS5jal9z5qgLs7huv3uS5W/fOwoG9j1cFiSBgjkSyUkSEIZU84oWWc 1xL3PK7EavS9GxpA3GwPZDVsHejl+vmmhNmD8V31TtlXhWOfogfNcMI8nuV5riWDSK1A 4Mbk0yepjU2n0XMwBP1degq5LJJm/LFuARP7/iN2dharY1EUbNYT/34F5MavpGT8gJAQ Tmg/gLHyTZFc8XRlvh7QB7l0nQJwQMjWLGQXGRD1nXAFb46qmCSFEBXKo+Nk3vTgmNBf 3z6m17I88ZhSsKvdvfFPAvG4gSXycVBoGGstpOFF0ODKnB+cPsvcHqD9PePIeVQbr8+8 vmZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=EcRFu47w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o22-20020a509b16000000b00418c2b5bdf6si1406208edi.216.2022.03.17.10.36.28; Thu, 17 Mar 2022 10:36:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=EcRFu47w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236367AbiCQQNA (ORCPT + 99 others); Thu, 17 Mar 2022 12:13:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236368AbiCQQM6 (ORCPT ); Thu, 17 Mar 2022 12:12:58 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A18EA214FA2 for ; Thu, 17 Mar 2022 09:11:40 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id m11-20020a17090a7f8b00b001beef6143a8so5891772pjl.4 for ; Thu, 17 Mar 2022 09:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=wywg4x91ht1wDsZE8LDgwKs/937jDdBiI3aoJq8Icig=; b=EcRFu47wdTKbqMSAq17bN6l3fW68je9I7sz6dNGS5tKD2WRbtx22XzizUZtR0qkyAQ QWP1OHwCDN5A0Nw0t3Q7qmd76Q7jNga+edrTyslT2xibkPds1nD37wWbuAnO8SwFuhrO gsVcYZtwJfnoFR7QpeZ53g8ha9BP7vQeAQagIeRfmuB8NZSh871Oy/O22T8GKZQsso7+ GAqKZ5LuYXbJaI8VOrspWlTrq9NYT2zp8TS48/UvpIibmW0S8anvsp+TLqAO1q5KW6Bh lxRLQvTEz/3EMFmPsbBbDBLIo1E7GTCaZssTwBenfG227MP1XIuXr1IbCZbQ1ApUnFqh aueg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=wywg4x91ht1wDsZE8LDgwKs/937jDdBiI3aoJq8Icig=; b=n3XCZQ+Pol0fcAlkeUgzvTXWlaUbFM5BCpqqY7snRD8/RManGDpVGqegJ3+nY+mtNg n6lgZMOep9nfs2rGC/NjX/q9I2qB4GGbYmNp+VrTCTh9ruWQfvpmcagDlcV1SLqUu5r3 bDCBmTbEv/O6+GZJv/Q1iAa815Y9CyXXPZD/Bc0iOnrvS7YN37FQmAkRzhxYuvcT+V13 gHMdWMwY819iMc/LwWPIqoTJwTj4hIFUWdhwv8Gp7fm3k30odTvbeI838PhMIjXGbCAx uVeCRrnFmiSzqSDV2VjWUz8soZUQRePzPqG/cd+ClMfHZ8bADk9Ykh7Iy+tIXnCWd3TQ 0uDw== X-Gm-Message-State: AOAM532JQAotlJvOod7O3Mgb4nRFAWoUUZQAh2szqLhznxa38hxPV3p/ M7WYHXWhLqR3sMBOajy7oat7zw== X-Received: by 2002:a17:902:7613:b0:151:6e1c:c49c with SMTP id k19-20020a170902761300b001516e1cc49cmr5906213pll.109.1647533499805; Thu, 17 Mar 2022 09:11:39 -0700 (PDT) Received: from [127.0.1.1] ([2620:10d:c090:400::5:d2fd]) by smtp.gmail.com with ESMTPSA id q10-20020a056a00088a00b004f7ceff389esm7702590pfj.152.2022.03.17.09.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 09:11:39 -0700 (PDT) From: Jens Axboe To: linux-kernel@vger.kernel.org, Randy Dunlap Cc: Arnd Bergmann , linux-scsi@vger.kernel.org, Greg Kroah-Hartman , Igor Kotrasinski , Valentina Manea , Florian Westphal , Peter Zijlstra , Karol Herbst , Eli Cohen , Pekka Paalanen , Herbert Xu , "James E.J. Bottomley" , x86@kernel.org, netfilter-devel@vger.kernel.org, Jozsef Kadlecsik , Shuah Khan , Ingo Molnar , Amit Shah , "H. Peter Anvin" , "Martin K. Petersen" , "David S. Miller" , Andy Lutomirski , Shuah Khan , Sebastian Andrzej Siewior , linux-block@vger.kernel.org, Saeed Mahameed , linux-usb@vger.kernel.org, coreteam@netfilter.org, "Michael S. Tsirkin" , Borislav Petkov , Krzysztof Opasiak , netdev@vger.kernel.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Stefan Hajnoczi , Paolo Bonzini , nouveau@lists.freedesktop.org, Jason Wang , Steven Rostedt , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Felipe Balbi , Dave Hansen , virtualization@lists.linux-foundation.org, Leon Romanovsky , Jussi Kivilinna , linux-rdma@vger.kernel.org, Pablo Neira Ayuso , Jakub Kicinski , Joachim Fritschi In-Reply-To: <20220316192010.19001-1-rdunlap@infradead.org> References: <20220316192010.19001-1-rdunlap@infradead.org> Subject: Re: (subset) [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Message-Id: <164753349550.89091.10994175450707575992.b4-ty@kernel.dk> Date: Thu, 17 Mar 2022 10:11:35 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2022 12:20:01 -0700, Randy Dunlap wrote: > There are a number of drivers that use "module_init(init)" and > "module_exit(exit)", which are anonymous names and can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > [...] Applied, thanks! [1/9] virtio_blk: eliminate anonymous module_init & module_exit commit: bcfe9b6cbb4438b8c1cc4bd475221652c8f9301b Best regards, -- Jens Axboe