Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     "pmalani@chromium.org" <pmalani@chromium.org>,
        "bleung@chromium.org" <bleung@chromium.org>,
        "groeck@chromium.org" <groeck@chromium.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "chrome-platform@lists.linux.dev" <chrome-platform@lists.linux.dev>,
        "Regupathy, Rajaram" <rajaram.regupathy@intel.com>,
        "Rao, Abhijeet" <abhijeet.rao@intel.com>
Subject: RE: [PATCH] "Active" sysfs attribute of typeC class should reflect
 the current state of active mode.
Thread-Topic: [PATCH] "Active" sysfs attribute of typeC class should reflect
 the current state of active mode.
Thread-Index: AQHYOgwLvZiU/qLGfUSkQB00qNXW76zDr9Jg
Date:   Thu, 17 Mar 2022 15:16:43 +0000
Message-ID: <CO1PR11MB48354543F7894941A843AD6296129@CO1PR11MB4835.namprd11.prod.outlook.com>
References: <20220317142731.3526-1-rajat.khandelwal@intel.com>
In-Reply-To: <20220317142731.3526-1-rajat.khandelwal@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7feMr2i3HhB3hzPZXOa0XFM8RnHtMD8fOQhv/jIjleZj2Px2MnE1Zh/TKSBj?=
 =?us-ascii?Q?jqDcMOtodYZIfasKt4y9Lz8h5lL7O9vp5N/d9lHs3aVGf1xIvLPoic5JTeZi?=
 =?us-ascii?Q?j59TLIaU5MQlcudQzTjtU7yErN0zfGjWgihuOl63cY+khgSB/cJ29HrTNX10?=
 =?us-ascii?Q?UbZh4UXAPxAtRry2ukN3h7j7hI8z/M+LioOjnFLCpB2LaY4tNRNKg8zbFvXh?=
 =?us-ascii?Q?nuHEqdSzrsSgIN1jxGehXhP23XWd5i1AEX7FOiKtVo9B1xZKll/x+PnpTskN?=
 =?us-ascii?Q?hT7N8g/DOl2inGc72xFu/p56OOWvOj4yqLDY7Ci6xNQvG6SEr/hzW/1qlNV1?=
 =?us-ascii?Q?TFUulNtQ0Lx8OuL1JMauNB3aa+zCw4vSEVBagi8odJKA4eLke4h4iEyxlQuZ?=
 =?us-ascii?Q?+3b8ee7izbt7lDLTjrXxwy2LYmB0cx6L69yblzRoTS4Ulz5L30ixsnILjpRS?=
 =?us-ascii?Q?4QnBic2fTBvclll31+fYigCe04vW5fqI/RGevYGAMCyi+8RCvaoWHTokkP+D?=
 =?us-ascii?Q?+SOj+4RSfd9bxMafmSSXLfkj6DlHaDtjq3eEGR+70NWewfkJlZdmbc316j+A?=
 =?us-ascii?Q?dSliGhxqGW7I596xWUQVvWYkeb9DVMEUlfR9ueSohM3nFv1N0G19RRemqgUq?=
 =?us-ascii?Q?96ZOT+ELHoOhelI21HTZi+fkNLAsAcPPSclwkA115dAei0vutsKSqwnshVWB?=
 =?us-ascii?Q?LPwCL6nyINjrt3bcCtH01gAthZ9P9r0MmjBpCYWNJMVhXzT+7pWJlu3el70I?=
 =?us-ascii?Q?z/qUjV1XdnrYZ1kIT0Ur0c1PL2WmOlVkXeIZLJYe4dFWpHf251RfOlB2ftTl?=
 =?us-ascii?Q?YcVaGvD6kUNYXsJgT1NZkAYV9c5YpwEx8XN+EVJ3K1P3EtCFvpkHC9895trv?=
 =?us-ascii?Q?QzmaF+v2XJSbd6/jkhpybou4iB/cmMj6lQGzwuhg/flVWynkcxvoL8aSQfGy?=
 =?us-ascii?Q?px57/Ia5Nne3xY3oFKsXCCoT4YwBwM4PDBGaytcA/7Jyyc2OWHJ/YDOiJWsY?=
 =?us-ascii?Q?SlBJQ+Zo+P4AuUTD+vzE4Z3Xekwhl0bSc+IuSM4zRZTxUCGBGG4uvxeaZI3o?=
 =?us-ascii?Q?HicjoiHVVhbKDhPTz1gdUocf+33UV47Crdr0DJnFJomFPZnfD6qG1NFRikpM?=
 =?us-ascii?Q?BtK151IdYt/yqVUbJng0epsBx63SiYwmMega4ECMzf6FTC/5ZYBfm5CL8kgA?=
 =?us-ascii?Q?oiNbpmDpEQgOTlS9lokn3gm1aDA8zzTUNJXeDjdvGD/8KMSod2jmlBgDv3jG?=
 =?us-ascii?Q?knqrDFaf25yHoEtkdz6cEyiUQeEQslxWO5wTvCQY0enbr9cW5j23Gu+mjktN?=
 =?us-ascii?Q?/9hn+EKRdujuVlxxMwpPc8w0jF27zNDmeg5GehLYy6En8eZzKGc34ukyMGvh?=
 =?us-ascii?Q?THdDwb/yWVbctMuJ7RJtGZQNf2gRKL4MmTRywHo4JK8FX52aWtwiHqYXX7d1?=
 =?us-ascii?Q?RJxgnzkVGvFegblQjI5J4ved6IXYZYHDH0nK1hhaWzY0VOu9Vx8g/w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e572ef04-69fc-4b17-204d-08da0829252e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 15:16:43.6182
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zDXA3DJi5Ceynk2woUINAurBMWSoX0FILQP4mJzGsN3jyFBd49XPFTWJMAXZCPKOZqNqYgZF/VSIjYaPgNIaDRs6nXSGc+9V8GHI2Ba9zZs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4815
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Abhijeet

-----Original Message-----
From: Khandelwal, Rajat <rajat.khandelwal@intel.com>=20
Sent: Thursday, March 17, 2022 7:58 PM
To: pmalani@chromium.org; bleung@chromium.org; groeck@chromium.org
Cc: linux-kernel@vger.kernel.org; chrome-platform@lists.linux.dev; Khandelw=
al, Rajat <rajat.khandelwal@intel.com>; Regupathy, Rajaram <rajaram.regupat=
hy@intel.com>
Subject: [PATCH] "Active" sysfs attribute of typeC class should reflect the=
 current state of active mode.

The "active" attribute of typeC class doesn't reflect the current status of=
 active mode. For eg., if the device is in DP alt mode, the corresponding a=
ctive sysfs attribute doesn't reflect the output to be "yes". It still disp=
lays "no". Same goes for TBT alt mode.
As an eg, cat /sys/bus/typec/devices/port0-partner.1/active --> displays "n=
o"! port0-partner.1 is the partner SVID created for TBT mode. On entering T=
BT mode, the active sysfs attribute should display "yes", but it displays "=
no". This patch fixes this.

Signed-off-by: Rajat-Khandelwal <rajat.khandelwal@intel.com>
---
 drivers/platform/chrome/cros_ec_typec.c | 41 +++++++++++++++++++++++--
 1 file changed, 39 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr=
ome/cros_ec_typec.c
index 5de0bfb0bc4d..798c58c75a7c 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -32,6 +32,12 @@ enum {
 	CROS_EC_ALTMODE_MAX,
 };
=20
+/* Supported alt modes and their SVIDs. */ enum {
+	CROS_EC_ALTMODE_DP_SVID =3D 0xff01,
+	CROS_EC_ALTMODE_TBT_SVID =3D 0x8087,
+};
+
 /* Container for altmode pointer nodes. */  struct cros_typec_altmode_node=
 {
 	struct typec_altmode *amode;
@@ -396,6 +402,7 @@ static int cros_typec_enable_tbt(struct cros_typec_data=
 *typec,  {
 	struct cros_typec_port *port =3D typec->ports[port_num];
 	struct typec_thunderbolt_data data;
+	struct cros_typec_altmode_node *node, *n;
 	int ret;
=20
 	if (typec->pd_ctrl_ver < 2) {
@@ -438,7 +445,14 @@ static int cros_typec_enable_tbt(struct cros_typec_dat=
a *typec,
 	port->state.data =3D &data;
 	port->state.mode =3D TYPEC_TBT_MODE;
=20
-	return typec_mux_set(port->mux, &port->state);
+	ret =3D typec_mux_set(port->mux, &port->state);
+
+	list_for_each_entry_safe(node, n, &port->partner_mode_list, list) {
+		if (node->amode->svid =3D=3D CROS_EC_ALTMODE_TBT_SVID && !ret)
+			typec_altmode_update_active(node->amode, true);
+	}
+
+	return ret;
 }
=20
 /* Spoof the VDOs that were likely communicated by the partner. */ @@ -448=
,6 +462,7 @@ static int cros_typec_enable_dp(struct cros_typec_data *typec,=
  {
 	struct cros_typec_port *port =3D typec->ports[port_num];
 	struct typec_displayport_data dp_data;
+	struct cros_typec_altmode_node *node, *n;
 	int ret;
=20
 	if (typec->pd_ctrl_ver < 2) {
@@ -480,7 +495,14 @@ static int cros_typec_enable_dp(struct cros_typec_data=
 *typec,
 	port->state.data =3D &dp_data;
 	port->state.mode =3D TYPEC_MODAL_STATE(ffs(pd_ctrl->dp_mode));
=20
-	return typec_mux_set(port->mux, &port->state);
+	ret =3D typec_mux_set(port->mux, &port->state);
+
+	list_for_each_entry_safe(node, n, &port->partner_mode_list, list) {
+		if (node->amode->svid =3D=3D CROS_EC_ALTMODE_DP_SVID && !ret)
+			typec_altmode_update_active(node->amode, true);
+	}
+
+	return ret;
 }
=20
 static int cros_typec_enable_usb4(struct cros_typec_data *typec, @@ -518,8=
 +540,23 @@ static int cros_typec_configure_mux(struct cros_typec_data *typ=
ec, int port_num,
 	struct cros_typec_port *port =3D typec->ports[port_num];
 	struct ec_params_usb_pd_mux_ack mux_ack;
 	enum typec_orientation orientation;
+	struct cros_typec_altmode_node *node, *n;
 	int ret;
=20
+	if (mux_flags !=3D USB_PD_MUX_DP_ENABLED && mux_flags !=3D USB_PD_MUX_HPD=
_IRQ &&
+	mux_flags !=3D USB_PD_MUX_HPD_LVL) {
+		list_for_each_entry_safe(node, n, &port->partner_mode_list, list) {
+			if (node->amode->svid =3D=3D CROS_EC_ALTMODE_DP_SVID)
+				typec_altmode_update_active(node->amode, false);
+		}
+	}
+
+	if (mux_flags !=3D USB_PD_MUX_TBT_COMPAT_ENABLED) {
+		list_for_each_entry_safe(node, n, &port->partner_mode_list, list) {
+			if (node->amode->svid =3D=3D CROS_EC_ALTMODE_TBT_SVID)
+				typec_altmode_update_active(node->amode, false);
+		}
+	}
+
 	if (mux_flags =3D=3D USB_PD_MUX_NONE) {
 		ret =3D cros_typec_usb_disconnect_state(port);
 		goto mux_ack;
--
2.17.1