Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 17 Mar 2022 11:15:39 -0300
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Mika =?utf-8?B?UGVudHRpbMOk?= <mpenttil@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com,
        vbabka@suse.cz
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice
 instead of char dev
Message-ID: <20220317141539.GD64706@ziepe.ca>
References: <20220311033050.22724-1-mpenttil@redhat.com>
 <20220314182439.GB64706@ziepe.ca>
 <d9b9c82e-4012-cf0a-d966-d9669a684a27@redhat.com>
 <20220315183922.GC64706@ziepe.ca>
 <8e836d75-97b0-d301-4d6a-92025e91cad5@redhat.com>
 <0f53c5ff-1711-861d-9a12-0634d4ab9fca@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0f53c5ff-1711-861d-9a12-0634d4ab9fca@redhat.com>
Precedence: bulk

On Thu, Mar 17, 2022 at 08:58:52AM +0200, Mika Penttilä wrote:
> @@ -1225,7 +1232,11 @@ static int dmirror_device_init(struct dmirror_device
> *mdevice, int id)
> 
>         cdev_init(&mdevice->cdevice, &dmirror_fops);
>         mdevice->cdevice.owner = THIS_MODULE;
> -       ret = cdev_add(&mdevice->cdevice, dev, 1);
> +       device_initialize(&mdevice->device);
> +       dev_set_name(&mdevice->device, "%s", dmirror_device_names[id]);
> +       mdevice->device.devt = dev;
> +
> +       ret = cdev_device_add(&mdevice->cdevice, &mdevice->device);
>         if (ret)
>                 return ret;

Right, miscdev isn't that helpful in the end..

Jason