Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1622285pxp; Thu, 17 Mar 2022 12:57:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyICVR2OY0+qdXsL1prX0xGkt84Pmpv2EGc5pP2oMt2tDa4b/0kp6XKJOWxq/CsZ+OlSfll X-Received: by 2002:a65:424a:0:b0:375:6d8b:8d44 with SMTP id d10-20020a65424a000000b003756d8b8d44mr5123868pgq.170.1647547048586; Thu, 17 Mar 2022 12:57:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647547048; cv=none; d=google.com; s=arc-20160816; b=kNI/YSv5AsTZiyI+jXsGcyleduCvgdXBR04KlVLZtrZwrbzCe/G90YWYwiGgcrBIWh F3NNAgCIuYLdq20hlnnPedw5tKGEFeYNjqqqB0TChKoG9Qfm2ux/xkYPOWai0X4LGGrb IEl7TbEzw5+tOuUZhD8N8HJsDnly2jYO8y+Bum4dJrFGhRgnx1ud9mdmFKu4/bQ6eOqc 6sFb90THHNyqraiDSj5rbgBuDBYxNtYXm3OONvTGlDDkaodJPZakz0omDwxw6OOL5XdS zPkGRpLAfwD71YJ7NfxbazHTAcSljDKFS7f7k3/FwPhkZTHZc1+b3zpCyCqUOuiuqCnx dV1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/Mc60t6jnP26cNcgLqwnqOalbdPk9xGun1aPafuftzo=; b=E8antCEt9CN9B49avkDcgnuEiYnE+QvhHDHxf89gdbYR6rea7wMrCCYRbhB/Ywg5M5 L/OshB6/ffYg03Da1zNN+nPA4TgPCtsOvN1Pz6N1EHtmN13nlb51TeUXMNEPnsqdIYnI C5h7/UfgMs6Ee+kekoEyj1aj0eVIt6FwqfSlHAWKTekH/B5BawZwdDLXSAco9EYdc6eG Bg6E8CLV7F8zdRVRolG/+RGsD6GfUMdFUP+26D15Tg/3elZdZykbYpJQ9WCiWdRBrwRK 6mFzUQzS5U51lfWHGbDtD23NOEfpbZbUiihQ+wBwQNrwJNRLIPCqF6MsI7Av82VjONkj ainA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dqJaZKXY; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id il15-20020a17090b164f00b001c664b49d24si3784323pjb.168.2022.03.17.12.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 12:57:28 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dqJaZKXY; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C5AFF275CAD; Thu, 17 Mar 2022 12:51:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234147AbiCQMwP (ORCPT + 99 others); Thu, 17 Mar 2022 08:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234023AbiCQMvt (ORCPT ); Thu, 17 Mar 2022 08:51:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7951F83D0; Thu, 17 Mar 2022 05:49:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 033D161228; Thu, 17 Mar 2022 12:49:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F1CBC340E9; Thu, 17 Mar 2022 12:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647521376; bh=k8jhjV4CJs7IhI95iarqfAAHzfd8JtOKmNL1gm3q48s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dqJaZKXYE/IB7R2aqwqaBdhpc4+3Wgcs0fB0mNyiGzyNauMqLDigoh9cWbRD0TpEJ 8PmnFpqaU1EStAIicW5q3nEEG/03iSyFZGmzUPhTViEiReMGL+6KidMDwPep/vhM1k E4TgkZSdbUECvrIZvuabrKQOGtII99ed96Sfn+94= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, TOTE Robot , Jia-Ju Bai , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 14/23] atm: firestream: check the return value of ioremap() in fs_init() Date: Thu, 17 Mar 2022 13:45:55 +0100 Message-Id: <20220317124526.374629426@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220317124525.955110315@linuxfoundation.org> References: <20220317124525.955110315@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai [ Upstream commit d4e26aaea7f82ba884dcb4acfe689406bc092dc3 ] The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 0ddd611b4277..43a34aee33b8 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1675,6 +1675,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev); -- 2.34.1