Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <00000000000085b1b305da5a66f3@google.com> <CAHk-=wjLNbf7viXP74K59jK=sRkg6mUbj0i3qpQvy9_2S4Lbtg@mail.gmail.com>
 <s5h5yoc651j.wl-tiwai@suse.de>
In-Reply-To: <s5h5yoc651j.wl-tiwai@suse.de>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 17 Mar 2022 11:56:20 -0700
Message-ID: <CAHk-=wh61USn+ATUDM-_hX+8p6Yhsq3RWHh+XR4BihfqFYJX8w@mail.gmail.com>
Subject: Re: [syzbot] WARNING: kmalloc bug in snd_pcm_plugin_alloc (2)
To:     Takashi Iwai <tiwai@suse.de>
Cc:     syzbot <syzbot+72732c532ac1454eeee9@syzkaller.appspotmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        alsa-devel@alsa-project.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Willy Tarreau <w@1wt.eu>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 17, 2022 at 7:13 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> And, we want not only avoiding the overflow but also limiting the
> actual size, too.  Practically seen, more than 1MB temporary buffer is
> unrealistic, and better to bail if more than that is requested.

Looks sane to me, although I obviously can't judge how well that 1M
limit works since I don't know the uses.

Thanks,
              Linus