Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <db194b66-67fb-5ef3-4b3c-9bd140ca1c5b@amd.com>
Date:   Thu, 17 Mar 2022 13:46:22 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system
 suspend
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Rob Clark <robdclark@gmail.com>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        freedreno <freedreno@lists.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Rob Clark <robdclark@chromium.org>,
        Sean Paul <sean@poorly.run>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        David Airlie <airlied@linux.ie>,
        Akhil P Oommen <quic_akhilpo@quicinc.com>,
        Jonathan Marek <jonathan@marek.ca>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Vladimir Lypak <vladimir.lypak@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220310234611.424743-1-robdclark@gmail.com>
 <20220310234611.424743-3-robdclark@gmail.com>
 <YjMGac4Hnjmg1wE8@phenom.ffwll.local>
 <3945551d-47d2-1974-f637-1dbc61e14702@amd.com>
 <CAF6AEGv36V8bLoDn5O1SW3iTUtzd3O1XeuT5gJxyLMxd1E-o3Q@mail.gmail.com>
 <865abcff-9f52-dca4-df38-b11189c739ff@amd.com>
From:   Andrey Grodzovsky <andrey.grodzovsky@amd.com>
In-Reply-To: <865abcff-9f52-dca4-df38-b11189c739ff@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mm1IZzFXM0h4SFdlemN2akp6Zmp3T1M2QlRDZFNEaThSMWd3eGlNOGkydkFK?=
 =?utf-8?B?T28rdHN4dzdzRUFXdEJVcHM4N04yNm9lNmZMZ0ltVmo0K2JTb3pjYXlqUmpu?=
 =?utf-8?B?emZhVnRMcTJPd200RXczQzNFQTlBcnpmOHVHZG1zbWpUR1ZFc0EySVdmODdV?=
 =?utf-8?B?Y3E2eVJIT2Y0VVZHeTNudUpaWnpoQjF4eE1iVU8xSFQ1U3MyUmtnNmRkTmJk?=
 =?utf-8?B?Vk9Nc2xWYUhxczVaRFBxSC9VZkNrMVlxd3FnV1daM1FBcVEyeWpDUG0wVEpQ?=
 =?utf-8?B?L0hLcGE1R2Z2OTJtV00wVWZWNUpsdkh4a25PZDBqdUtaOVY2aGZ5SDZBdmFH?=
 =?utf-8?B?bXMxNGZtN2dUMkZGc1cvN0tVaFB0YnJyQXhzWTJtVk1XRE05S1A5UmRkdDha?=
 =?utf-8?B?L2VZQ0dWbVMvQUkvcTZCUFVhMmlWU2hpTkVhYUhtc2RBVmU4VVp4UjM4ZlJt?=
 =?utf-8?B?M004VlhRTFFtM2dUenc4Z3NJYUJiZ3FBVHc4a25kUlpxb0Zad2xMYlROSitV?=
 =?utf-8?B?SEc3TDRCelo0QkRVbUFhZVMzVmQ4cVlYRC9PbkdXc3NMMVVkSFA1RWVNc2FI?=
 =?utf-8?B?YkdhcDVCNEhLcVhrZ1VlenM0aVd1VVNaK2JjbWRaay9GeGdaVkJmbUJ3OEEz?=
 =?utf-8?B?aHV0Y1NaR1dveG4vVElWcnpJVkZVU1pickprSzZWYlpWdkowUWJOM1l3NW1E?=
 =?utf-8?B?dSs4UTdJUFZzK3hzN1orVEdsZzdQd0E0c3dFaXdDNTZ6UlpHaDZUZEJYb0hh?=
 =?utf-8?B?elphMmxrRlZiUDhhSWQ3RmkvMWVGaVBoQ0l0dHpad1RPY2dJOWszbEtpU0F6?=
 =?utf-8?B?QjNPWVlKTzJIY3Z5YVc4SEpkNVBQZDFHQXpJRFNPRDlRd2JxeGlxN1pwSGd4?=
 =?utf-8?B?WmE4UmRIQ1U1WkpGdDcrS01CbGlWZTdUMVRkK2Q0NzZPV3JONUljVlhFU2dS?=
 =?utf-8?B?eVFzRkFvU29GeHNhYkNHMWZuZlZld1o1VXNYaVJuWm8xRjQ2WjRLZ1YrUllM?=
 =?utf-8?B?MkUxRkVVcHhuSnJjN0sxVThKaWpWQVFkdkxjbTJSMEhYWUJBMXVaNEs4ZVZz?=
 =?utf-8?B?YlJlT0JjeFMzNWFzei9ReUNBZmMzYW9yUms0a1dncGJHcUZ3MGRoeC94Um5H?=
 =?utf-8?B?MEgyajRJMVJQcUIxRkxjNUM3Rnk2ZTdoYTVFbkpHL1ZScFQ5N0ZvOG8wUmJN?=
 =?utf-8?B?b0JqcURpTWEzcU9SQ01DY2tsTHJJRVBSdE84dHhSR0FYQTM3NVRpWmtWZGVI?=
 =?utf-8?B?Q2hYV2NQTjZCNDU4K29JVklkcFViV05rV0dDeVV5bGd5ajU5ZDFIbllHVHY2?=
 =?utf-8?B?clZKTlVoNURpbm12ZVlITGh2L0xmeFdkMVlWMnBISStFWDFmZU9nVVFvWjVM?=
 =?utf-8?B?S1lzbHNSLy9XcTlWbTlFeGs1K2FDb0JEU01BalUzM05pdDZEY0tLUHdjOE45?=
 =?utf-8?B?TzFpaTkrbVV3dkhhUUk4dWh4QmdnblZmb2NKWHR6ZHdFQmV3Z2w2OFhWTXhi?=
 =?utf-8?B?QWlHM0NMc2lEZGIyVm96dlpZSlpIdkdjbU9EYkYvUGFVSzZhWFZnbnBEeHQv?=
 =?utf-8?B?YmxEYzdGVGYxSFlGRUtUbmljSkM3bndaQlFUdEJDaW51N0czdVF0V0NZS095?=
 =?utf-8?B?SnJ4U2FOaU9nTXp1WHI2aVdPR1FFRzlEY0l6Zks5MGpORDc5dEdWRTlXNi8v?=
 =?utf-8?B?TDBVc256VmQ0NU1LOXdYSHN3clo1RkpoWEY5cWZEMVFqbjBqNE9LWGJRdVA5?=
 =?utf-8?B?WENmUlVaeVF2WWxXS2h6MHM4S094amJkNmtMbi95WjgrWUQweDQ3dXdRMkVC?=
 =?utf-8?B?anZtSWs2VDlpYkRyelVQTDZpZVVDamw2aTlWbVplaEJlK2h1UzRuZVozbXJY?=
 =?utf-8?B?aHZwbUx4d1JPN0dyYmRDYWJjM052OWZMT29JUlNxeGsvVmFrWnF4d3hwcitM?=
 =?utf-8?B?ZjYzTGFCeGorR21PMjc4eklMN1RSa04yN2xOWERDUHdYZUVVZ0dDRUZQeDNX?=
 =?utf-8?B?MitJbmZ5cmtTTVdMdldFUkw1Sk96eTFvWDI2cmoyS2M5Q1BRcG5TT0F4ZWN2?=
 =?utf-8?Q?/bHQY1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f06da03-9011-4b04-2501-08da083e0ebf
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1947.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 17:46:25.7561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m2Ery/8xSlYCGVVBUw1D+GaF0HRUe3D1boNe1aeaoTiPM10Uhva5gDPx1KjZUj/OFPbjbk3Tn0AOgoRHtu/i/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3434
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-03-17 12:04, Christian König wrote:
> Am 17.03.22 um 16:10 schrieb Rob Clark:
>> [SNIP]
>> userspace frozen != kthread frozen .. that is what this patch is
>> trying to address, so we aren't racing between shutting down the hw
>> and the scheduler shoveling more jobs at us.
>
> Well exactly that's the problem. The scheduler is supposed to 
> shoveling more jobs at us until it is empty.
>
> Thinking more about it we will then keep some dma_fence instance 
> unsignaled and that is and extremely bad idea since it can lead to 
> deadlocks during suspend.
>
> So this patch here is an absolute clear NAK from my side. If amdgpu is 
> doing something similar that is a severe bug and needs to be addressed 
> somehow.


 From looking at latest amd-stagin-drm-next we only use directly 
kthread_park during in debugfs IB hooks.
For S3  suspend (amdgpu_pmops_suspend) we will only  flush all the HW 
fences (amdgpu_fence_wait_empty) so we don't freeze the scheduler thread 
and don't flush scheduler entities.

Andrey


>
> Regards,
> Christian.
>
>>
>> BR,
>> -R
>>
>