Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1637929pxp; Thu, 17 Mar 2022 13:18:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqqJmzxla+Kvb7ymssg6UfNszgfkWLtDfvhXV5yoLqDcFrRg2VzNFbT4KDUGQW/22nk7Rx X-Received: by 2002:a17:90a:10c8:b0:1bc:e369:1f2c with SMTP id b8-20020a17090a10c800b001bce3691f2cmr17751416pje.193.1647548287001; Thu, 17 Mar 2022 13:18:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647548286; cv=none; d=google.com; s=arc-20160816; b=SalJd1o7hMy540RYPkRFcIIw8DPRt7Bq2/bXSfrW+SYsQvijKVOV0GIs3Jm7Xx/gzL 3WaLns8J2jkaNatYT0QESH+PA0TIPDYCKNbfx+4OUOvsQu8xYPa//V+EYcvyiKZFYaIw 1fFYvnT/Us4Tki9CF5UTKTDl7QItiSYXqTFjtl7ECoNdxT2nEyrCALDTZLFPFK1nXQa2 685ilBfDaCmBykiO6/Rxq+sXAz7KVsosFueOX09zyac/turhoNPS4qsB6Qu2NRr7CRli jrOumWeCoPLWuIzWrVGNEj17NlKx4lXbwZydLI/HW69cQ+yxwcmGisbeNf+eJFbw3RRp Ug6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ReP8M04SJoKF0SqbkKFJg1YeCepaYDw468D8AlLIelA=; b=l+tWedzpKFm11UXtg3Xvo0zImnccs5OQzMtzruXvuMbtO7x5frLCL7zYk9zjmkLloA ZZb12CXvjIr+7ba8Ak7LGH5NNpkPeuNn6tVv6mHKlgZu7LxDQhCA7DB4hw0kGmLZF2+6 W9NYQn7vtR46vQDiYDY+sJKRo1+8ESKc4j+/Z4Jb9LxGEpo3iDauZLxr/eGbF0DOHoco 4/StJecRbxfZUK1FhaV8FBvtdNqePftsCcu3+nKum4q5IxOvFm2IJn8ZrLPDBmfyiJ/p 0OmXHhoX1GbVbw05Jxs5bajMN+eyVdZ7l1bbQwJfvKjIPvjjNZHRAW/0+UM7JzcbtmeS ZZCA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id s73-20020a63774c000000b003816043f04asi3080785pgc.575.2022.03.17.13.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 13:18:06 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 28A4714D7A4; Thu, 17 Mar 2022 12:59:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238013AbiCQTWp (ORCPT + 99 others); Thu, 17 Mar 2022 15:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238000AbiCQTWf (ORCPT ); Thu, 17 Mar 2022 15:22:35 -0400 Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E62E2296FE for ; Thu, 17 Mar 2022 12:21:13 -0700 (PDT) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 67a4b5b8-a627-11ec-9ac0-0050568cd888; Thu, 17 Mar 2022 19:21:11 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 86B53194B05; Thu, 17 Mar 2022 20:21:10 +0100 (CET) Date: Thu, 17 Mar 2022 20:21:06 +0100 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Lu Wei Cc: thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, marijn.suijten@somainline.org, angelogioacchino.delregno@somainline.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH,v2] drm/panel: Fix return value check in nt35950_probe() Message-ID: References: <20220317083707.237039-1-luwei32@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317083707.237039-1-luwei32@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 04:37:07PM +0800, Lu Wei wrote: > In function nt35950_probe(), mipi_dsi_device_register_full() is called > to create a MIPI DSI device. If it fails, a pointer encoded with an error > will be returned, so use IS_ERR() to check the return value. Besides, use > PTR_ERR to return the actual errno. > > Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") > Signed-off-by: Lu Wei Acked-by: Sam Ravnborg